From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 55204@debbugs.gnu.org
Subject: bug#55204: [PATCH v2] 29.0.50; Improve quoting consistency in Eshell predicates/modifiers
Date: Sun, 01 May 2022 20:22:43 +0200 [thread overview]
Message-ID: <877d75dsek.fsf@gnus.org> (raw)
In-Reply-To: <88fcb2cf-213f-b1c1-8d95-b71fba5e4055@gmail.com> (Jim Porter's message of "Sun, 1 May 2022 11:18:49 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> I've also moved a stray Eshell entry from the "Lisp Changes" section
> into the Eshell subsection of "Changes in Specialized Modes". It was
> more of a user-facing change, so it's probably best to put it there
> alongside all the other similar changes (I added a pointer to the
> manual section too).
Thanks; looks good. But this leads to a couple of test failures, like
the one below. (Note -- this doesn't fail when "make eshell-tests", but
with "make check".)
Test eshell-test/redirect-buffer backtrace:
signal(ert-test-failed (((should (equal (buffer-string) "hi")) :form
ert-fail(((should (equal (buffer-string) "hi")) :form (equal "" "hi"
#f(compiled-function () #<bytecode 0xb0e2b90f44d2f2e>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name eshell-test/redirect-buffer :document
ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/eshell-tests"
command-line()
normal-top-level()
Test eshell-test/redirect-buffer condition:
(ert-test-failed
((should
(equal
(buffer-string)
"hi"))
:form
(equal "" "hi")
:value nil :explanation
(arrays-of-different-length 0 2 "" "hi" first-mismatch-at 0)))
FAILED 19/25 eshell-test/redirect-buffer (0.001028 sec) at lisp/eshell/eshell-tests.el:117
Test eshell-test/redirect-buffer-escaped backtrace:
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-05-01 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 4:37 bug#55204: 29.0.50; Improve quoting consistency in Eshell predicates/modifiers Jim Porter
2022-05-01 4:50 ` bug#55204: [PATCH] " Jim Porter
2022-05-01 8:40 ` bug#55204: " Lars Ingebrigtsen
2022-05-01 18:18 ` bug#55204: [PATCH v2] " Jim Porter
2022-05-01 18:22 ` Lars Ingebrigtsen [this message]
2022-05-01 18:36 ` Jim Porter
2022-05-01 18:40 ` Lars Ingebrigtsen
2022-05-01 18:41 ` Lars Ingebrigtsen
2022-05-01 18:42 ` Lars Ingebrigtsen
2022-05-01 23:55 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d75dsek.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=55204@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.