Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

[Andreas Schwab]

On Jun 24 2022, Lars Ingebrigtsen wrote:

> branch: master
> commit cd479aa8bd498da4d7980a7fe7a37e238761482f
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix some byte-compilation warnings about subr-x
>     
>     * lisp/term/haiku-win.el (require):
>     * lisp/replace.el (require):
>     * lisp/progmodes/elisp-mode.el (require):
>     * lisp/isearch.el (require):
>     * lisp/files.el (require): Require subr-x when compiling.

Loading /home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/files.el (source)...
Eager macro-expansion failure: (void-function file-relative-name)
Eager macro-expansion failure: (void-function file-relative-name)
Eager macro-expansion failure: (void-function file-relative-name)
Eager macro-expansion failure: (void-function file-relative-name)
Eager macro-expansion failure: (void-function file-relative-name)

Error: void-function (file-relative-name)
  mapbacktrace((closure ((prin1 . prin1) t) (evald func args _flags) (let ((args args)) (if evald (progn (princ "  ") (funcall prin1 func) (princ "(")) (progn (princ "  (") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args))) (princ " "))) (princ ")\n"))))
  (let ((print-escape-newlines t) (print-escape-control-characters t) (print-escape-nonascii t) (prin1 (if (and (fboundp 'cl-prin1) (require 'cl-print nil t)) #'cl-prin1 #'prin1))) (mapbacktrace #'(lambda (evald func args _flags) (let ((args args)) (if evald (progn (princ "  ") (funcall prin1 func) (princ "(")) (progn (princ "  (") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args))) (princ " "))) (princ ")\n")))))
  debug-early-backtrace()
  debug-early(error (void-function file-relative-name))
  (file-relative-name load-file-name)
  (concat (file-relative-name load-file-name) ": ")
  (if (stringp load-file-name) (concat (file-relative-name load-file-name) ": ") "")
  (message "%sWarning: %s" (if (stringp load-file-name) (concat (file-relative-name load-file-name) ": ") "") msg)
  (if compile-only nil (message "%sWarning: %s" (if (stringp load-file-name) (concat (file-relative-name load-file-name) ": ") "") msg))
  (unless compile-only (message "%sWarning: %s" (if (stringp load-file-name) (concat (file-relative-name load-file-name) ": ") "") msg))
  (cond ((null msg) form) ((macroexp-compiling-p) (if (and (consp form) (gethash form macroexp--warned)) form (puthash form form macroexp--warned) (macroexp--warn-wrap (or arg form) msg form category))) (t (unless compile-only (message "%sWarning: %s" (if (stringp load-file-name) (concat (file-relative-name load-file-name) ": ") "") msg)) form))
  macroexp-warn-and-return("Unknown defun property ‘gv-setter’" nil nil nil gv-setter)
  (cond (f (apply (car f) name arglist (cdr x))) ((and (featurep 'cl) (memq (car x) '(special inline notinline optimize warn))) (push (list 'declare x) cl-decls) nil) (t (macroexp-warn-and-return (format-message "Unknown %s property `%S'" construct (car x)) nil nil nil (car x))))
  (let ((f (cdr (assq (car x) declarations-alist)))) (cond (f (apply (car f) name arglist (cdr x))) ((and (featurep 'cl) (memq (car x) '(special inline notinline optimize warn))) (push (list 'declare x) cl-decls) nil) (t (macroexp-warn-and-return (format-message "Unknown %s property `%S'" construct (car x)) nil nil nil (car x)))))
  (closure ((cl-decls) (declarations-alist (advertised-calling-convention byte-run--set-advertised-calling-convention) (obsolete byte-run--set-obsolete) (interactive-only byte-run--set-interactive-only) (pure byte-run--set-pure "If non-nil, the compiler can replace calls with their return value.\nThis may shift errors from run-time to compile-time.") (side-effect-free byte-run--set-side-effect-free "If non-nil, calls can be ignored if their value is unused.\nIf `error-free', drop calls even if `byte-compile-delete-errors' is nil.") (compiler-macro byte-run--set-compiler-macro) (doc-string byte-run--set-doc-string) (indent byte-run--set-indent) (speed byte-run--set-speed) (completion byte-run--set-completion) (modes byte-run--set-modes)) (construct . defun) (clauses (gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) (arglist x) (name . cl-fifth) t) (x) (let ((f (cdr (assq (car x) declarations-alist)))) (cond (f (apply (car f) name arglist (cdr x))) ((and (featurep 'cl) (memq (car x) '(special inline notinline optimize warn))) (push (list 'declare x) cl-decls) nil) (t (macroexp-warn-and-return (format-message "Unknown %s property `%S'" construct (car x)) nil nil nil (car x))))))((gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store))))
  mapcar((closure ((cl-decls) (declarations-alist (advertised-calling-convention byte-run--set-advertised-calling-convention) (obsolete byte-run--set-obsolete) (interactive-only byte-run--set-interactive-only) (pure byte-run--set-pure "If non-nil, the compiler can replace calls with their return value.\nThis may shift errors from run-time to compile-time.") (side-effect-free byte-run--set-side-effect-free "If non-nil, calls can be ignored if their value is unused.\nIf `error-free', drop calls even if `byte-compile-delete-errors' is nil.") (compiler-macro byte-run--set-compiler-macro) (doc-string byte-run--set-doc-string) (indent byte-run--set-indent) (speed byte-run--set-speed) (completion byte-run--set-completion) (modes byte-run--set-modes)) (construct . defun) (clauses (gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) (arglist x) (name . cl-fifth) t) (x) (let ((f (cdr (assq (car x) declarations-alist)))) (cond (f (apply (car f) name arglist (cdr x))) ((and (featurep 'cl) (memq (car x) '(special inline notinline optimize warn))) (push (list 'declare x) cl-decls) nil) (t (macroexp-warn-and-return (format-message "Unknown %s property `%S'" construct (car x)) nil nil nil (car x)))))) ((gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))))
  (let* ((cl-decls nil) (actions (mapcar #'(lambda (x) (let ((f (cdr (assq (car x) declarations-alist)))) (cond (f (apply (car f) name arglist (cdr x))) ((and (featurep 'cl) (memq (car x) '(special inline notinline optimize warn))) (push (list 'declare x) cl-decls) nil) (t (macroexp-warn-and-return (format-message "Unknown %s property `%S'" construct (car x)) nil nil nil (car x)))))) clauses))) (cons actions cl-decls))
  byte-run--parse-declarations(cl-fifth (x) ((gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) defun ((advertised-calling-convention byte-run--set-advertised-calling-convention) (obsolete byte-run--set-obsolete) (interactive-only byte-run--set-interactive-only) (pure byte-run--set-pure "If non-nil, the compiler can replace calls with their return value.\nThis may shift errors from run-time to compile-time.") (side-effect-free byte-run--set-side-effect-free "If non-nil, calls can be ignored if their value is unused.\nIf `error-free', drop calls even if `byte-compile-delete-errors' is nil.") (compiler-macro byte-run--set-compiler-macro) (doc-string byte-run--set-doc-string) (indent byte-run--set-indent) (speed byte-run--set-speed) (completion byte-run--set-completion) (modes byte-run--set-modes)))
  (and declare-form (byte-run--parse-declarations name arglist (cdr declare-form) 'defun defun-declarations-alist))
  (let* ((parse (byte-run--parse-body body t)) (docstring (nth 0 parse)) (declare-form (nth 1 parse)) (interactive-form (nth 2 parse)) (body (nth 3 parse)) (warnings (nth 4 parse)) (declarations (and declare-form (byte-run--parse-declarations name arglist (cdr declare-form) 'defun defun-declarations-alist)))) (setq body (nconc warnings body)) (setq body (nconc (cdr declarations) body)) (if interactive-form (setq body (cons interactive-form body))) (if docstring (setq body (cons docstring body))) (if (null body) (setq body '(nil))) (let ((def (list 'defalias (list 'quote name) (list 'function (cons 'lambda (cons arglist body)))))) (if declarations (cons 'prog1 (cons def (car declarations))) def)))
  (closure (t) (name arglist &rest body) "Define NAME as a function.\nThe definition is (lambda ARGLIST [DOCSTRING] [INTERACTIVE] BODY...).\nDECL is a declaration, optional, of the form (declare DECLS...) where\nDECLS is a list of elements of the form (PROP . VALUES).  These are\ninterpreted according to `defun-declarations-alist'.\nINTERACTIVE is an optional `interactive' specification.\nThe return value is undefined.\n\n(fn NAME ARGLIST [DOCSTRING] [DECL] [INTERACTIVE] BODY...)" (or name (error "Cannot define '%s' as a function" name)) (if (null (and (listp arglist) (null (delq t (mapcar #'symbolp arglist))))) (error "Malformed arglist: %s" arglist)) (let* ((parse (byte-run--parse-body body t)) (docstring (nth 0 parse)) (declare-form (nth 1 parse)) (interactive-form (nth 2 parse)) (body (nth 3 parse)) (warnings (nth 4 parse)) (declarations (and declare-form (byte-run--parse-declarations name arglist (cdr declare-form) 'defun defun-declarations-alist)))) (setq body (nconc warnings body)) (setq body (nconc (cdr declarations) body)) (if interactive-form (setq body (cons interactive-form body))) (if docstring (setq body (cons docstring body))) (if (null body) (setq body '(nil))) (let ((def (list 'defalias (list 'quote name) (list 'function (cons 'lambda (cons arglist body)))))) (if declarations (cons 'prog1 (cons def (car declarations))) def))))(cl-fifth (x) "Return the fifth element of the list X." (declare (gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) (nth 4 x))
  (defun cl-fifth (x) "Return the fifth element of the list X." (declare (gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) (nth 4 x))
  (prog1 (defun cl-fifth (x) "Return the fifth element of the list X." (declare (gv-setter (lambda (store) `(setcar (nthcdr 4 ,x) ,store)))) (nth 4 x)) (eval-and-compile (function-put 'cl-fifth 'speed '-1) (put 'cl-fifth 'byte-optimizer 'byte-compile-inline-expand)))
  eval-buffer(#<buffer  *load*-971593> nil "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/cl-lib.el" nil t)
  (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))
  (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))
  (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))))
  (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer)))
  (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t)
  (if (null (file-readable-p fullname)) (and (null noerror) (signal 'file-error (list "Cannot open load file" file))) (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t))
  load-with-code-conversion("/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/cl-lib.el" "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/cl-lib.el" nil t)
  require(cl-lib)
  (progn (require 'cl-lib))
  eval((progn (require 'cl-lib)) t)
  (list 'quote (eval (cons 'progn body) lexical-binding))
  (closure (t) (&rest body) "Like `progn', but evaluates the body at compile time if you're compiling.\nThus, the result of the body appears to the compiler as a quoted\nconstant.  In interpreted code, this is entirely equivalent to\n`progn', except that the value of the expression may be (but is\nnot necessarily) computed at load time if eager macro expansion\nis enabled." (list 'quote (eval (cons 'progn body) lexical-binding)))((require 'cl-lib))
  (eval-when-compile (require 'cl-lib))
  eval-buffer(#<buffer  *load*-56046> nil "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/subr-x.el" nil t)
  (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))
  (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))
  (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))))
  (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer)))
  (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t)
  (if (null (file-readable-p fullname)) (and (null noerror) (signal 'file-error (list "Cannot open load file" file))) (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t))
  load-with-code-conversion("/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/subr-x.el" "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/emacs-lisp/subr-x.el" nil t)
  require(subr-x)
  (progn (require 'pcase) (require 'easy-mmode) (require 'subr-x))
  eval((progn (require 'pcase) (require 'easy-mmode) (require 'subr-x)) t)
[  285s]   (list 'quote (eval (cons 'progn body) lexical-binding))
  (closure (t) (&rest body) "Like `progn', but evaluates the body at compile time if you're compiling.\nThus, the result of the body appears to the compiler as a quoted\nconstant.  In interpreted code, this is entirely equivalent to\n`progn', except that the value of the expression may be (but is\nnot necessarily) computed at load time if eager macro expansion\nis enabled." (list 'quote (eval (cons 'progn body) lexical-binding)))((require 'pcase) (require 'easy-mmode) (require 'subr-x))
  (eval-when-compile (require 'pcase) (require 'easy-mmode) (require 'subr-x))
  eval-buffer(#<buffer  *load*> nil "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/files.el" nil t)
  (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))
  (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))
  (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-mulSymbol's function definition is void: file-relative-name
tibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t))))
  (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer)))
  (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t)
  (if (null (file-readable-p fullname)) (and (null noerror) (signal 'file-error (list "Cannot open load file" file))) (let ((buffer (generate-new-buffer " *load*")) (load-in-progress t) (source (string-suffix-p ".el" fullname))) (unless nomessage (if source (message "Loading %s (source)..." file) (message "Loading %s..." file))) (when purify-flag (push (purecopy file) preloaded-file-list)) (unwind-protect (let ((load-true-file-name fullname) (load-file-name fullname) (set-auto-coding-for-load t) (inhibit-file-name-operation nil) shorthands) (with-current-buffer buffer (set-buffer-multibyte t) (let (deactivate-mark) (insert-file-contents fullname)) (setq shorthands (and hack-read-symbol-shorthands-function (funcall hack-read-symbol-shorthands-function))) (if (and enable-multibyte-characters (or (eq (coding-system-type last-coding-system-used) 'raw-text))) (set-buffer-multibyte nil)) (set-buffer-modified-p nil)) (let ((read-symbol-shorthands shorthands)) (if eval-function (funcall eval-function buffer (if dump-mode file fullname)) (eval-buffer buffer nil (if dump-mode file fullname) nil t)))) (let (kill-buffer-hook kill-buffer-query-functions) (kill-buffer buffer))) (do-after-load-evaluation fullname) (unless (or nomessage noninteractive) (if source (message "Loading %s (source)...done" file) (message "Loading %s...done" file))) t))
  load-with-code-conversion("/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/files.el" "/home/abuild/rpmbuild/BUILD/emacs-29.0.50/lisp/files.el" nil nil)
  load("files")
  load("loadup.el")
make[2]: *** [Makefile:924: bootstrap-emacs.pdmp] Error 255

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Eager macro-expansion failure: (void-function file-relative-name)
>
> Error: void-function (file-relative-name)
>   mapbacktrace((closure ((prin1 . prin1) t) (evald func args _flags)
> (let ((args args)) (if evald (progn (princ " ") (funcall prin1 func)
> (princ "(")) (progn (princ " (") (setq args (cons func args)))) (if
> args (while (progn (funcall prin1 (car args)) (setq args (cdr args)))
> (princ " "))) (princ ")\n"))))

Ouch.  I've now reverted that patch and will investigate more tomorrow.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 25 Jun 2022 00:21:11 +0200
> 
> Andreas Schwab <schwab@linux-m68k.org> writes:
> 
> > Eager macro-expansion failure: (void-function file-relative-name)
> >
> > Error: void-function (file-relative-name)
> >   mapbacktrace((closure ((prin1 . prin1) t) (evald func args _flags)
> > (let ((args args)) (if evald (progn (princ " ") (funcall prin1 func)
> > (princ "(")) (progn (princ " (") (setq args (cons func args)))) (if
> > args (while (progn (funcall prin1 (car args)) (setq args (cdr args)))
> > (princ " "))) (princ ")\n"))))
> 
> Ouch.  I've now reverted that patch and will investigate more tomorrow.

Perhaps related to this: I get the following warnings with the current
master:

  In end of data:
  progmodes/elisp-mode.el:1795:36: Warning: the function `string-limit' is not known to be defined.

  In end of data:
  term/haiku-win.el:238:36: Warning: the function `string-empty-p' is not known to be defined.

  In isearch-fold-quotes-mode:
  isearch.el:4570:25: Warning: `replace-regexp-in-string' called with 2 arguments, but requires 3-7
  isearch.el:4571:25: Warning: `replace-regexp-in-string' called with 2 arguments, but requires 3-7
  isearch.el:4572:25: Warning: `replace-regexp-in-string' called with 2 arguments, but requires 3-7

  In end of data:
  isearch.el:4568:23: Warning: the function `thread-last' is not known to be defined.

  In end of data:
  files.el:5079:13: Warning: the function `string-empty-p' is not known to be defined.

  In end of data:
  replace.el:270:27: Warning: the function `string-remove-suffix' is not known to be defined.

Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Ouch.  I've now reverted that patch and will investigate more tomorrow.
>
> Perhaps related to this: I get the following warnings with the current
> master:

Yes, that was what the patch meant to fix (but it had a side effect of
making bootstrap fail).

I've now redone the fix, and the warnings should be gone again.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master cd479aa8bd: Fix some byte-compilation warnings about subr-x

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: schwab@linux-m68k.org,  emacs-devel@gnu.org
> Date: Sat, 25 Jun 2022 12:33:16 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Ouch.  I've now reverted that patch and will investigate more tomorrow.
> >
> > Perhaps related to this: I get the following warnings with the current
> > master:
> 
> Yes, that was what the patch meant to fix (but it had a side effect of
> making bootstrap fail).
> 
> I've now redone the fix, and the warnings should be gone again.

Yes, compiles cleanly now, thanks.