From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Size of xterm.c doubled since Emacs 28 Date: Thu, 14 Jul 2022 09:00:23 +0800 Message-ID: <877d4gtsns.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 14 03:02:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBnFN-0000wn-9w for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jul 2022 03:02:29 +0200 Original-Received: from localhost ([::1]:43356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBnFL-0006tD-RK for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Jul 2022 21:02:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBnDd-000678-8A for emacs-devel@gnu.org; Wed, 13 Jul 2022 21:00:41 -0400 Original-Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:42655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBnDb-0002io-7p for emacs-devel@gnu.org; Wed, 13 Jul 2022 21:00:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657760437; bh=pv3dNs4E9MYKrdjUZaJ297QOykNW0hWkWQZZki76bBs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=AQAxXABvglEb6WvqW2uDc0nXXKfVMnAKpdGc+EUaxc9ab3Kve5elJOVqjasF8yVU5zfR0mqJKh03hHz4FI9UarRyPy5iietwkGa0DyavFpSPbENCPw3qMUOhZQHpFfNAOquLfw31g0ab7DKC/jwlNHVlBRcG87GYeILg8JpAYsZnzFr5ryToLMowFjL73BZ4uMmA7fAGRDcbM8AfLrmU0u+YQ9frCcRHUbymZGCqgv0IyC0Oy/tN3ydWwddvyBmApm7GkTu2fdU40rhIeVccUC0RMDfNGcy+S25SIl9dt4atdq4Dw+qk23QhsACjutmOwvWOTrKKcZMVuy6aui3ARQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657760437; bh=I3MKDvA4NAa1qMYnC/OuQWC3wyAP3JExxV76AynwUgG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=e2NU6wwqd47ePAd+r3Vti4apIxqLIeJ2ZqbyRz+u7DNjaz8R4BV0QNhS7gqCbmIC8HDv0YeDR7iUulzZrKgCIZigAyErz9UX/dCCIdqZDMx/9etiwPZMsxbcBF5J/bDR3U/JWd7+Ofett2BM7AIdRp1sOFbzaFBPs7ee9wsFfMUfXrXjOfm+ziqHLhUZoh//FlBHBZeaGrtcx/JJZ14VREla3RzfbAWVs7iqY8QpMtB7O6n3H3419UCosa2s18cHpA2uR2Trqj7r3gepx4DakMGPh1dlNQx98uw83I4YXw8Oxzf2mKXa8x5nyT4oeQUNS7qFlRQbn8a8pKHifLhkCA== X-YMail-OSG: C_8ulB4VM1kF_kBCAIHsaODzpXaGgfQ61o2CdPfDUOM4C9aB7cD4l7U6CispKNu dtLX1dVIgCJLB15F1Y0YK0.Orm1DYxvYe6DIpQ2xH4E70sBLLq5Gq450szRdE1FHOAtoUqh69mMe IL5fW.m7dON1NUV5WZnwhvASp2iuXM23H4tedRuLPOVCSAy90AL9_5Owy3QjC._4ECVNK42_QKK9 xR2YdDwee25q4UWV6ZBKyakftqhLAnBnZPhL79zji3KP1juvp_nf01I_6g8R3rHsCaVDxSfW0pUL QW2aoPmcRDVM2iFsXCo.8CK9HVlezxfe3Jcg1U6XPeJ.lW_7upXE4SKP9zUPPr4XdxAjiUMaBYCV .0H9ogu8AoLkNhC80ftYPOvQpi1W.lzjEZ007OeTTLwbJAYDO4VUIfAR4IsR_9ico.l3pihNA7_t il4yCpVvRnW51Ccv2rL02jCj9dC4YlCqya3prnYZC300dzXjSlOXBYxo_MuFBOS1LyhAjeLqzy8i SAX2KTbUiGq5p.ldsm3gYroW4x6U7gv5zR_Rwo7Hm7Xu7BA8T3JvlTf78BWRNUPMLyEN5cP993Rm .b1_5XIhEKnYn1mekEPA7G_7fLg_ACFS72VzdL_zPVV.tWgW8T1xfRHObsGpOnlibLq0KviYfG55 Z68HJ1U8rX44ssXNkKigFeVh_31rX4YJ9_0ggFCtrwSkz74f0OMkJjtn3wrm5pp6ZbkW6agh51NO jv.fMWmU2dWWTJbmZelgIlMjrT4horHfnUFTJoDos.CGWbuWNsaEb80EEpoahV3k0OB.c7LxB.Vd wbpQUdiOfd5j6zgDkWxe.LiJWejBFVdKoLFk63emWF X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Thu, 14 Jul 2022 01:00:37 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-hh5lh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5196d11901261939e7e5521c217491e3; Thu, 14 Jul 2022 01:00:33 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Wed, 13 Jul 2022 09:18:21 -0700") X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.148; envelope-from=luangruo@yahoo.com; helo=sonic305-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292118 Archived-At: Stefan Kangas writes: > Hi, > > I have noticed that xterm.c has seen a lot of activity recently, and > increased in size from ~14,000 lines to ~28,000 lines of code between > emacs-28 and master. I wanted to ask if parts of that file should > perhaps better be put in one or more separate files, for the usual > reasons. Most of that is taken up by the drag-and-drop code and the input extension code. There is no chance of the input extension code being put in a separate file until someone redoes the X terminal code from scratch (which isn't likely.) The drag-and-drop code also needs very detailed interaction with the event loop, and proved to be too difficult to place in a separate file when I first wrote it. But on the bright side, the size of the file hasn't really proven to be a problem.