From: Po Lu <luangruo@yahoo.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: Size of xterm.c doubled since Emacs 28
Date: Thu, 14 Jul 2022 09:00:23 +0800 [thread overview]
Message-ID: <877d4gtsns.fsf@yahoo.com> (raw)
In-Reply-To: <CADwFkmnhh45_OTWgJyH+cW6kED3et1ypmddQ+dG3iv95h3kq=A@mail.gmail.com> (Stefan Kangas's message of "Wed, 13 Jul 2022 09:18:21 -0700")
Stefan Kangas <stefan@marxist.se> writes:
> Hi,
>
> I have noticed that xterm.c has seen a lot of activity recently, and
> increased in size from ~14,000 lines to ~28,000 lines of code between
> emacs-28 and master. I wanted to ask if parts of that file should
> perhaps better be put in one or more separate files, for the usual
> reasons.
Most of that is taken up by the drag-and-drop code and the input
extension code.
There is no chance of the input extension code being put in a separate
file until someone redoes the X terminal code from scratch (which isn't
likely.)
The drag-and-drop code also needs very detailed interaction with the
event loop, and proved to be too difficult to place in a separate file
when I first wrote it.
But on the bright side, the size of the file hasn't really proven to be
a problem.
next prev parent reply other threads:[~2022-07-14 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 16:18 Size of xterm.c doubled since Emacs 28 Stefan Kangas
2022-07-14 1:00 ` Po Lu [this message]
2022-07-14 10:06 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d4gtsns.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.