From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend Date: Sat, 16 Jul 2022 11:04:34 +0800 Message-ID: <877d4dn4fx.fsf@yahoo.com> References: <87wnch16as.fsf@elite.giraud> <87k08gtsz0.fsf@yahoo.com> <87cze8t4i9.fsf@elite.giraud> <87k08goud8.fsf@yahoo.com> <87h73jq1dp.fsf@elite.giraud> <874jzjp1st.fsf@yahoo.com> <87ilnysi72.fsf@elite.giraud> <87v8rymt15.fsf@yahoo.com> <87edymsdz8.fsf@elite.giraud> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40756"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 56538@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 05:05:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCY7Q-000AMm-JF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 05:05:24 +0200 Original-Received: from localhost ([::1]:57162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCY7O-0006xY-EX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 23:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCY74-0006xJ-Lt for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 23:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCY74-00080i-D8 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 23:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCY74-0004od-6a for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 23:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 03:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56538-submit@debbugs.gnu.org id=B56538.165794069918499 (code B ref 56538); Sat, 16 Jul 2022 03:05:02 +0000 Original-Received: (at 56538) by debbugs.gnu.org; 16 Jul 2022 03:04:59 +0000 Original-Received: from localhost ([127.0.0.1]:42588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCY70-0004oJ-SB for submit@debbugs.gnu.org; Fri, 15 Jul 2022 23:04:59 -0400 Original-Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:42092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCY6w-0004o0-6Q for 56538@debbugs.gnu.org; Fri, 15 Jul 2022 23:04:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657940687; bh=SEvDEsP7WAy425D6KAsXkpxRhyMrfUE2pzaSG08lf8w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=LCOe+e+4Hcz/5/Cvs/do09APEuUBxrha9Uq6eaRcyk+CrZ6ivvvCq3F0HPZjwuFsW2TaKYdIUl1rLJldyqpeVxq9/yVCxtrWHpbUa1iNuBOS2WlU9ekri0xRYOmVlAh3p7QaaMcIbLJZ0NqDid44mHlO1zXJ+r75NsXr+70HUG8CGemAL26ul1yWPLXpFaQjE4WUltNAgSy82F0bPXT2eBZIK5R5n7enGCY5gvv1RJIyDTIZbSgnQVuwII7MUavsTuE2HKYzCEINVrcFUpZrUANVMjGBRchIZ36RRfrH9yFi7RAgvsivPO1d4FBMaQQDCvgyjsvGwXG8aGVkyc1p9Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657940687; bh=0JgvGsncGmUs9h5e6ZL0SzlAqAvclEyvuSxTLKrXQz9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RH5T1gjUaP7hXUMB03T2KRocTEnAGkoQIeEWecUXNQPZqD/2zgPbk3DUw4qz8TT7M+/g7Go+hylmBkz0UogqtFEXqVvUsLQJNUe+q+cyxKgBZ6MHO9NAeYXcVhTaj/W7jU3fZya6/1RQfW7eCuP5tqaFpYm20FagNpBJWrAHuxY7zi9fGhJEGbvFeGK4FEDpa0VebB7FH6Dd8f1H1MNhyzSZUPcn3402Wc/aDcrrsELsfRn5R37P1ua51XZH0qD4dKPI8pXOjnLNoysMi9dXY0qC0jTfGO6WJF+w3INfDSPv59f6zyshUm5SWcdybfBYtQfW0TS3H6k2C3kEZOqXqA== X-YMail-OSG: tsI5vy8VM1kJY.YyzJIjBssb8CiEXSB6oN36UwT0BQWLYu.Kh646Z.rs1sNMsHk qUreJB_l9rB.I4TsgElxC6f4vtE2iL4YozskEdWnOG7xcXw9TTNNb1Nhr_0Yab_GjU9_R2jtg22G _LpBxzLm2pF8us_zMEsSyoTfOH09WjMQ2SZJ8tR4DAeq3EagvtcprpBHEsdvskVaAFrka0IkLm0c bwTck6l9uBNiaEjMg26KIUZ_nJ4.0prgONJNp29eKIocF8uSigto5YVEEEqYFSXV0fIVkB67jb_P SmvgQif6qEwSVYSuxCaMLz6k.4Kpr8aKO.sPD6zx8IkzOO9qyrsUFeKvo9SE9Gl1anqg9Yyj0817 rsu_ZXTQOr6lq75UCQQqWvscVDUkNimtC313qUK8wZFApUR9wuARozEr6yAbA2rlWFSl0Qp_VC2l GEaUlLj6rG5.W6iKUt0QVzLwPOpAUU7xOoRyAeEjqyWKxjnq.z.cy1aOK554K02lmayBD8UHicBK uamMpJ4Tjha0dvOGnl.ocSHECD5WqPlUqipqXXamPc.3ZsVKvNgqF7NFu9zPqlSPUqdhpn0WsF4j 9dVxaaCrV31eFJkYhzTg53Bx6qzmbuk2YRcqOWKB_7bVgQ_ABvgDMNkqdfk66_leY79yYPtGDtFA x8IySa6z9j7nEs_OqSIV9PDDDTXL5nuS.LmL9OHYF7HUjALIcYAuK250OguyCntV9SPiyL1WXRxJ 8ltQjTjNeNlEjOrlEc7NZSrwv_Wuop8uwDeUfULtN9ljNQydZStDP9E.IE59.ihOrWJKRbj7GSoa L54ngJvFCLb8dEWXv3Bafx5BT5ArEySQhXE0MaJCJI X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 03:04:47 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0489fe2465483ea8efb262be3d86e94b; Sat, 16 Jul 2022 03:04:41 +0000 (UTC) In-Reply-To: <87edymsdz8.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 15 Jul 2022 15:27:23 +0200") X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237133 Archived-At: Manuel Giraud writes: >> Shouldn't this say "the menu item highlighted by the mouse"? Otherwise, >> what "highlighted" means is not exactly clear. > > I did not add "by the mouse" because menus could also be navigated with > keyboard arrows. Do you have any other suggestions to make it clearer? How about "by the mouse or key navigation"? >>> +** New X resources: "highlightForeground" and "highlightBackground" >>> +Only in the Lucid build, this controls colors used for highlighted >>> +menu item widget. >> >> And here, shouldn't "widget" be in plural? > > Ok. I'll add it to the next patch when the previous issue is resolved. Thanks.