bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

[-- Attachment #1: Type: text/plain, Size: 5073 bytes --]

Severity: minor

Hi Philip,

Nice job on the v3 stuff. I happened across a couple capabilities being
requested that don't officially exist, a distinction you've probably
picked up on in the course of pursuing this work [1]. The couple that
slipped by are always NAK'd but basically harmless, so you may just want
to leave 'em or otherwise go your own way. If so, please ignore this.

Thanks,
J.P.

P.S. The CTCP "KEEPALIVE" in the ergo session below jumped out at me;
just FYI in case that's of any interest.


[1] For others who may be wondering, the specs are still a bit rough
    when it comes to denoting with any consistency when an extension has
    a corresponding ("requestable") capability. For example, some
    extensions (like STS) have caps that are strictly server-only,
    meaning you, a client, shouldn't REQ them. Other caps are only
    effectively server-only, meaning it doesn't matter if you REQ them
    or not (negated or otherwise). And some extensions (like the two in
    this bug) don't offer caps at all. This has confused me enough over
    the years that I've taken to looking to other clients as well as WG
    chatter on Github for clues, which can get old pretty fast.


In GNU Emacs 29.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-10-15 built on localhost
Repository revision: ca3d7234d39fd55e6cd4521e5e583aba12434402
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Fedora 34 (Workstation Edition)

Configured using:
 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs
 --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu
 --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin
 --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share
 --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec
 --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man
 --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png
 --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3
 --with-gpm=no --with-xwidgets --with-modules --with-harfbuzz
 --with-cairo --with-json build_alias=x86_64-redhat-linux-gnu
 host_alias=x86_64-redhat-linux-gnu CC=gcc 'CFLAGS=-O0 -g3'
 LDFLAGS=-Wl,-z,relro
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
seq gv subr-x byte-opt bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads
xwidget-internal dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 16 50942 5933)
 (symbols 48 6632 1)
 (strings 32 18373 2087)
 (string-bytes 1 622208)
 (vectors 16 13731)
 (vector-slots 8 186505 9804)
 (floats 8 21 35)
 (intervals 56 259 0)
 (buffers 992 10))

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-request-phony-capabilities-in-rcirc.patch --]
[-- Type: text/x-patch, Size: 1913 bytes --]

From 2d7f5116525e0679721519faa240d7fd7ca23ccf Mon Sep 17 00:00:00 2001
From: "F. Jason Park" <jp@neverwas.me>
Date: Fri, 15 Oct 2021 22:17:18 -0700
Subject: [PATCH] Don't request phony capabilities in rcirc

* lisp/net/rcirc.el (rcirc-implemented-capabilities): Remove
non-capability extensions but document that they're supported.
---
 lisp/net/rcirc.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 52d74a3394..f8c7ea41bc 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -622,11 +622,9 @@ rcirc-implemented-capabilities
   '("message-tags"                      ;https://ircv3.net/specs/extensions/message-tags
     "server-time"                       ;https://ircv3.net/specs/extensions/server-time
     "batch"                             ;https://ircv3.net/specs/extensions/batch
-    "message-ids"                       ;https://ircv3.net/specs/extensions/message-ids
     "invite-notify"                     ;https://ircv3.net/specs/extensions/invite-notify
     "sasl"                              ;https://ircv3.net/specs/extensions/sasl-3.1
     "multi-prefix"                      ;https://ircv3.net/specs/extensions/multi-prefix
-    "standard-replies"                  ;https://ircv3.net/specs/extensions/standard-replies
     ;; The following capabilities should be implemented as soon as
     ;; their specifications are undrafted:
     ;;
@@ -644,6 +642,11 @@ rcirc-acked-capabilities
 (defvar-local rcirc-finished-sasl t
   "Check whether SASL authentication has completed.")
 
+;; Other supported extensions
+;;
+;;   message-ids                         https://ircv3.net/specs/extensions/message-ids
+;;   standard-replies                    https://ircv3.net/specs/extensions/standard-replies
+
 (defun rcirc-get-server-method (server)
   "Return authentication method for SERVER."
   (catch 'method
-- 
2.31.1


[-- Attachment #3: rcirc-ergo.log --]
[-- Type: text/plain, Size: 3816 bytes --]

[2021-10-15T21:53:38 localhost] SENTINEL: #<process localhost> "open
"
[2021-10-15T21:53:38 localhost] CAP REQ :message-tags
[2021-10-15T21:53:38 localhost] CAP REQ :server-time
[2021-10-15T21:53:38 localhost] CAP REQ :batch
[2021-10-15T21:53:38 localhost] CAP REQ :message-ids
[2021-10-15T21:53:38 localhost] CAP REQ :invite-notify
[2021-10-15T21:53:38 localhost] CAP REQ :sasl
[2021-10-15T21:53:38 localhost] CAP REQ :multi-prefix
[2021-10-15T21:53:38 localhost] CAP REQ :standard-replies
[2021-10-15T21:53:38 localhost] NICK tester
[2021-10-15T21:53:38 localhost] USER user 0 * :unknown
[2021-10-15T21:53:38 localhost] PRIVMSG tester :\x01KEEPALIVE 1634360018.784283\x01
[2021-10-15T21:53:38 localhost] :irc.foonet.org CAP * ACK message-tags
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * ACK server-time
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * ACK batch
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * NAK message-ids
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * ACK invite-notify
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * ACK sasl
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * ACK multi-prefix
@time=2021-10-16T04:53:38.784Z :irc.foonet.org CAP * NAK standard-replies
@time=2021-10-16T04:53:38.784Z :irc.foonet.org 451 * :You need to register before you can use that command
[2021-10-15T21:53:38 localhost] CAP END
[2021-10-15T21:53:38 localhost] @time=2021-10-16T04:53:38.791Z :irc.foonet.org 001 tester :Welcome to the foonet IRC Network tester
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 002 tester :Your host is irc.foonet.org, running version oragono-2.6.1-937b9b02368748e5
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 003 tester :This server was created Sat, 16 Oct 2021 04:49:18 UTC
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 004 tester irc.foonet.org oragono-2.6.1-937b9b02368748e5 BERTZios CEIMRUabefhiklmnoqstuv Iabefhkloqv
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 005 tester AWAYLEN=390 BOT=B CASEMAPPING=ascii CHANLIMIT=#:100 CHANMODES=Ibe,k,fl,CEMRUimnstu CHANNELLEN=64 CHANTYPES=# ELIST=U EXCEPTS EXTBAN=,m FORWARD=f INVEX KICKLEN=390 :are supported by this server
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 005 tester MAXLIST=beI:60 MAXTARGETS=4 MODES MONITOR=100 NETWORK=foonet NICKLEN=32 PREFIX=(qaohv)~&@%+ STATUSMSG=~&@%+ TARGMAX=NAMES:1,LIST:1,KICK:1,WHOIS:1,USERHOST:10,PRIVMSG:4,TAGMSG:4,NOTICE:4,MONITOR:100 TOPICLEN=390 UTF8MAPPING=rfc8265 UTF8ONLY WHOX :are supported by this server
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 005 tester draft/CHATHISTORY=100 :are supported by this server
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 251 tester :There are 0 users and 3 invisible on 1 server(s)
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 252 tester 0 :IRC Operators online
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 253 tester 0 :unregistered connections
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 254 tester 1 :channels formed
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 255 tester :I have 3 clients and 0 servers
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 265 tester 3 3 :Current local users 3, max 3
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 266 tester 3 3 :Current global users 3, max 3
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 422 tester :MOTD File is missing
@time=2021-10-16T04:53:38.791Z :irc.foonet.org 221 tester +i
@time=2021-10-16T04:53:38.791Z :irc.foonet.org NOTICE tester :This server is in debug mode and is logging all user I/O. If you do not wish for everything you send to be readable by the server owner(s), please disconnect.
[2021-10-15T21:55:08 localhost] @time=2021-10-16T04:55:08.792Z PING tester
[2021-10-15T21:55:08 localhost] PONG :tester
[2021-10-15T21:56:38 localhost] @time=2021-10-16T04:56:38.794Z PING tester
[2021-10-15T21:56:38 localhost] PONG :tester

[-- Attachment #4: rcirc-inspircd.log --]
[-- Type: text/plain, Size: 11249 bytes --]

[2021-10-15T22:27:14 testnet.inspircd.org] SENTINEL: #<process testnet.inspircd.org> "open
"
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :message-tags
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :server-time
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :batch
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :message-ids
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :invite-notify
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :sasl
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :multi-prefix
[2021-10-15T22:27:14 testnet.inspircd.org] CAP REQ :standard-replies
[2021-10-15T22:27:14 testnet.inspircd.org] NICK rcirc-tester
[2021-10-15T22:27:14 testnet.inspircd.org] USER user 0 * :unknown
[2021-10-15T22:27:14 testnet.inspircd.org] :testnet.inspircd.org NOTICE * :*** Raw I/O logging is enabled on this server. All messages, passwords, and commands are being recorded.
:testnet.inspircd.org NOTICE * :*** Looking up your ident...
:testnet.inspircd.org NOTICE * :*** Looking up your hostname...
:testnet.inspircd.org NOTICE * :*** Could not resolve your hostname: Domain not found; using your IP address (localhost) instead.
:testnet.inspircd.org CAP * ACK :message-tags
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.537Z :testnet.inspircd.org CAP * ACK :server-time
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.537Z :testnet.inspircd.org CAP * ACK :batch
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.537Z :testnet.inspircd.org CAP * NAK :message-ids
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.537Z :testnet.inspircd.org CAP * ACK :invite-notify
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.537Z :testnet.inspircd.org CAP * ACK :sasl
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.538Z :testnet.inspircd.org CAP * ACK :multi-prefix
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.538Z :testnet.inspircd.org CAP * NAK :standard-replies
[2021-10-15T22:27:14 testnet.inspircd.org] CAP END
[2021-10-15T22:27:14 testnet.inspircd.org] @time=2021-10-16T05:27:14.538Z PING :Ul~K~iamlM
[2021-10-15T22:27:14 testnet.inspircd.org] PONG :Ul~K~iamlM
[2021-10-15T22:27:15 testnet.inspircd.org] @time=2021-10-16T05:27:15.055Z :testnet.inspircd.org NOTICE rcirc-tester :*** Could not find your ident, using ~user instead.
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 001 rcirc-tester :Welcome to the InspIRCd Testnet IRC Network rcirc-tester!~user@localhost
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 002 rcirc-tester :Your host is testnet.inspircd.org, running version InspIRCd-3
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 003 rcirc-tester :This server was created 14:03:20 Oct 15 2021
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 004 rcirc-tester sadie.testnet.inspircd.org InspIRCd-3 BDHILNRSTWcdghikorswxz ABCDEFHIJKLMNOPQRSTXYZabcdefghijklmnopqrstuvwz :BEFHIJLXYZabdefghjkloqvw
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 005 rcirc-tester ACCEPT=30 AWAYLEN=200 BOT=B CALLERID=g CASEMAPPING=ascii CHANLIMIT=#:20 CHANMODES=IXYZbegw,k,BEFHJLdfjl,ACDKMNOPQRSTcimnprstuz CHANNELLEN=64 CHANTYPES=# ELIST=CMNTU ESILENCE=CcdiNnPpTtx EXCEPTS=e :are supported by this server
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 005 rcirc-tester EXTBAN=,ACGNOQRSTUacjmnprswz HOSTLEN=64 INVEX=I KEYLEN=32 KICKLEN=255 LINELEN=512 MAXLIST=I:100,X:100,b:100,e:100,g:100,w:100 MAXTARGETS=20 MODES=20 MONITOR=30 NAMELEN=128 NAMESX NETWORK=InspIRCd\x20Testnet :are supported by this server
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 005 rcirc-tester NICKLEN=30 PREFIX=(qaohv)~&@%+ REMOVE SAFELIST SECURELIST=60 SILENCE=32 STATUSMSG=~&@%+ TOPICLEN=307 UHNAMES USERIP USERLEN=10 USERMODES=,,s,BDHILNRSTWcdghikorwxz WATCH=30 :are supported by this server
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 005 rcirc-tester WHOX :are supported by this server
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 251 rcirc-tester :There are 0 users and 8 invisible on 2 servers
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 252 rcirc-tester 1 :operator(s) online
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 253 rcirc-tester 1 :unknown connections
[2021-10-15T22:27:15 testnet.inspircd.org] @time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 254 rcirc-tester 8 :channels formed
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 255 rcirc-tester :I have 8 clients and 1 servers
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 265 rcirc-tester :Current local users: 8  Max: 8
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 266 rcirc-tester :Current global users: 8  Max: 8
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 375 rcirc-tester :testnet.inspircd.org message of the day
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :  _____                        _____   _____    _____      _
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : |_   _|                      |_   _| |  __ \  / ____|    | |
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :   | |    _ __    ___   _ __    | |   | |__) || |       __| |
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :   | |   | '_ \  / __| | '_ \   | |   |  _  / | |      / _` |
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :  _| |_  | | | | \__ \ | |_) | _| |_  | | \ \ | |____ | (_| |
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : |_____| |_| |_| |___/ | .__/ |_____| |_|  \_\ \_____| \__,_|
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :  _____________________| |__________________________________
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : |_____________________|_|__________________________________|
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : 
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :                          \x1dPowering IRC communities since 2006\x0f
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : 
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :        /\     /\
[2021-10-15T22:27:16 testnet.inspircd.org] @time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       {  `---'  }  \x02WELCOME TO THE \x0313I\x0304N\x0307S\x0308P\x0303I\x0310R\x0312C\x0306D\x0f\x02 TEST NETWORK\x0f
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       {  O   O  }
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ~~>  V  <~~    This server is operated by Sadie 🐈
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :        \  \|/  /        Hosted in Roubaix, France 🇫🇷
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :         `-----'____
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :         /     \    \_
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :        {       }\  )_\_   _
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :        |  \_/  |/ /  \_\_/ )
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :         \__/  /(_/     \__/
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :           (__/
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester : 
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┏━━━━━━━━━━━━┫ SERVER LISTENERS ┣━━━━━━━━━━━━━┓
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃                                             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃ \x02IRC PORTS:\x02                                  ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃                                             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃    \x026667\x02 - plain text (STS only)             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃    \x026697\x02 - TLS                               ┃
[2021-10-15T22:27:17 testnet.inspircd.org] @time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃    \x028067\x02 - plain text WebSocket (STS only)   ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃    \x028097\x02 - WebSocket over TLS                ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃                                             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃ \x02OTHER PORTS:\x02                                ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃                                             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃    \x026443\x02 - HTTP over TLS (test:test)         ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┃                                             ┃
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 372 rcirc-tester :       ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 376 rcirc-tester :End of message of the day.
@time=2021-10-16T05:27:15.055Z :testnet.inspircd.org PRIVMSG rcirc-tester :*** Raw I/O logging is enabled on this server. All messages, passwords, and commands are being recorded.
@time=2021-10-16T05:27:15.055Z :sadie.testnet.inspircd.org 396 rcirc-tester localhost.IP :is now your displayed host
@time=2021-10-16T05:27:15.055Z :rcirc-tester!~user@localhost.IP MODE rcirc-tester :+iwx
@time=2021-10-16T05:27:15.055Z :testnet.inspircd.org NOTICE rcirc-tester :*** You are connected to testnet.inspircd.org using TLS (SSL) cipher 'TLS1.3-ECDHE-RSA-AES-256-GCM-AEAD'
[2021-10-15T22:27:20 testnet.inspircd.org] @time=2021-10-16T05:27:20.061Z :rcirc-tester!~user@localhost.IP JOIN :#inspircd
@time=2021-10-16T05:27:20.061Z :sadie.testnet.inspircd.org 332 rcirc-tester #inspircd :Welcome to the InspIRCd test network. Please make sure you're wearing adequate PPE to ensure your safety.
@time=2021-10-16T05:27:20.061Z :sadie.testnet.inspircd.org 333 rcirc-tester #inspircd Sadie :1633385189
@time=2021-10-16T05:27:20.061Z :sadie.testnet.inspircd.org 353 rcirc-tester = #inspircd :jwheare rcirc-tester &@ChanServ Testah ilbelkyr ~@Sadie genius3000
@time=2021-10-16T05:27:20.061Z :sadie.testnet.inspircd.org 366 rcirc-tester #inspircd :End of /NAMES list.

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

"J.P." <jp@neverwas.me> writes:

> The couple that slipped by are always NAK'd but basically harmless

Not to suggest that NAK'ing implies invalidation or even a denial of
support (as in you oughtn't try again later) or really *anything* other
than what caps weren't enabled. (I'm sure this is old news, but it took
me a while to fully process, as usual.)

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[Philip Kaludercic]

"J.P." <jp@neverwas.me> writes:

> Severity: minor
>
> Hi Philip,
>
> Nice job on the v3 stuff. I happened across a couple capabilities being
> requested that don't officially exist, a distinction you've probably
> picked up on in the course of pursuing this work [1]. The couple that
> slipped by are always NAK'd but basically harmless, so you may just want
> to leave 'em or otherwise go your own way. If so, please ignore this.

I have to be honest, I was not familiar with this distinction.  As you
say, I assuming that anything that wasn't implemented by a server would
be NAK'd.

What confuses me is how standard-replies doesn't have to be requested.
message-ids is clear, because they rely on message-tags and if a that is
provided, sending message IDs even if they were not requested wouldn't
pose any issues.  The thing is that standard-replies introduces new
types, that the client must be able to parse.  Just sending them to any
non IRCv3-capable client would presumable confuse it.  From reading the
spec, I don't immediately see that it says the capability should be
requested.  Could you explain this?

-- 
	Philip Kaludercic

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

Philip Kaludercic <philipk@posteo.net> writes:

> What confuses me is how standard-replies doesn't have to be requested.
> message-ids is clear, because they rely on message-tags and if a that is
> provided, sending message IDs even if they were not requested wouldn't
> pose any issues.  The thing is that standard-replies introduces new
> types, that the client must be able to parse.  Just sending them to any
> non IRCv3-capable client would presumable confuse it.  From reading the
> spec, I don't immediately see that it says the capability should be
> requested.  Could you explain this?

Standard replies are quite mysterious. From what I can gather:

  - Future extensions are to favor this form of reply whenever possible.
  - These *aren't* for recasting existing replies.

So there's no need to explicitly request them because support is implied
when asking for an extension that uses them, much like with message IDs.

However, I *have* noticed at least one progressive IRCd sending standard
replies not defined in any spec [1]. I can only guess they assume
clients not privy to the new syntax are resilient enough to take these
in stride [2]. And while being privy does buy a client more useful info
for presenting to the user, it's still the particulars, like the
specific reply code and the shape/meaning of the "context params", that
allow it to respond decisively to a given situation (IMO). Thanks.


[1] https://github.com/ircv3/ircv3-specifications/pull/276

[2] As in recognize these messages as at least adhering to the standard
    IRC format and therefore capable of withstanding whatever treatment
    is normally reserved for extracting the most degenerate
    understanding (like simply printing the message to the server buffer
    as a quasi error), in much the same way Libera likely doesn't worry
    much about its nonstandard numerics 479 and 435(?) causing much of a
    stir.

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

"J.P." <jp@neverwas.me> writes:

> However, I *have* noticed at least one progressive IRCd sending
> standard replies not defined in any spec [1].
>
> [...]
>
> [1] https://github.com/ircv3/ircv3-specifications/pull/276

That link is bogus/unrelated (sorry). It's actually a

  :irc.org FAIL NICK NICKNAME_RESERVED tester :Nickname is reserved ...

that I encountered, but it's not documented anywhere (that I could
find). It's sent by Ergo 2.6.1 whether or not you request any caps.
NICKNAME_RESERVED was ostensibly created to prevent confusion with the
traditional 433/ERR_NICKNAMEINUSE, which accompanies it in the same
burst.

Whether it's safe to expect such redundancy across the board when
nothing dependent has been negotiated is anyone's guess, but the
existence of the vendor cap inspircd.org/standard-replies [1] perhaps
tips things in favor of the yeas. This cap gives permission for a server
to send undeclared replies in standard-replies form, possibly in lieu of
traditional ones, like 433.

> I can only guess they assume clients not privy to the new syntax are
> resilient enough to take these in stride [2].

Yeah, "new syntax" is just confusing. What I meant was rather than
extending the IRC message format, a standard-replies declaration merely
specifies a concrete reply within the constraints of the broader
protocol, meaning

  [@tags] [:src] cmd    p0     p1     p2     ... pn-1    :pn
  [@tags] [:src] <type> <req> <code> [<cxt0> ... <ctxn>] :<desc>

from the spec is just a way of getting us ready for specific interface
descriptions, like those for setname [2]. So when folks talk about
safely degrading in this context [3], they mean devolving to a catch-all
handler (usually NOTICE) for all unrecognized/unhandled replies. Thanks.

[1] https://docs.inspircd.org/3/modules/cap/
[2] https://ircv3.net/specs/extensions/setname#errors
[3] https://github.com/inspircd/inspircd/issues/1809

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[Philip Kaludercic]

(Sorry that it took me a while to respond)

"J.P." <jp@neverwas.me> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> What confuses me is how standard-replies doesn't have to be requested.
>> message-ids is clear, because they rely on message-tags and if a that is
>> provided, sending message IDs even if they were not requested wouldn't
>> pose any issues.  The thing is that standard-replies introduces new
>> types, that the client must be able to parse.  Just sending them to any
>> non IRCv3-capable client would presumable confuse it.  From reading the
>> spec, I don't immediately see that it says the capability should be
>> requested.  Could you explain this?
>
> Standard replies are quite mysterious. From what I can gather:
>
>   - Future extensions are to favor this form of reply whenever possible.
>   - These *aren't* for recasting existing replies.
>
> So there's no need to explicitly request them because support is implied
> when asking for an extension that uses them, much like with message IDs.

I understand the issue, but am still hesitant. If this is vague, then it
seems better to err on the side of safety and request a message even if
the request constitutes a noop. Or are there any real downsides to being
more explicit?

-- 
	Philip Kaludercic

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

Philip Kaludercic <philipk@posteo.net> writes:

>> Standard replies are quite mysterious. From what I can gather:
>
> [...]
>
> I understand the issue, but am still hesitant. If this is vague, then
> it seems better to err on the side of safety

What's mysterious and vague isn't the existence of a capability called
standard-replies. No such capability currently exists. As mentioned in
my last reply (not sure if you saw that one), the closest thing is
inspircd.org/standard-replies. Hope that makes sense.

> Or are there any real downsides to being more explicit?

No downsides at present because you request one cap per line. And you
have no interdependent caps as yet. So long as both remain true, there's
nothing to worry about. And rcirc doesn't make you accrue flood debt,
so early messages (even spurious ones) don't cost extra.

In ERC's case, we *do* have to worry because we implement 302 and have
multiple dependencies. If any one gets NAK'd, there goes the ball game.
There's also some undefined behavior [1] that can turn connection
registration into a bit of a limbo without additional planning (should
you ever decide to go that route). Thanks.


[1] https://github.com/ircv3/ircv3-specifications/pull/400#issuecomment-579063998

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[Philip Kaludercic]

"J.P." <jp@neverwas.me> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> Standard replies are quite mysterious. From what I can gather:
>>
>> [...]
>>
>> I understand the issue, but am still hesitant. If this is vague, then
>> it seems better to err on the side of safety
>
> What's mysterious and vague isn't the existence of a capability called
> standard-replies. No such capability currently exists. As mentioned in
> my last reply (not sure if you saw that one), the closest thing is
> inspircd.org/standard-replies. Hope that makes sense.
>
>> Or are there any real downsides to being more explicit?
>
> No downsides at present because you request one cap per line. And you
> have no interdependent caps as yet. So long as both remain true, there's
> nothing to worry about. And rcirc doesn't make you accrue flood debt,
> so early messages (even spurious ones) don't cost extra.

Ok, then I think we should leave it the way it is for now.

> In ERC's case, we *do* have to worry because we implement 302 and have
> multiple dependencies. If any one gets NAK'd, there goes the ball game.
> There's also some undefined behavior [1] that can turn connection
> registration into a bit of a limbo without additional planning (should
> you ever decide to go that route). Thanks.

I think you should report this as a separate bug report.

> [1] https://github.com/ircv3/ircv3-specifications/pull/400#issuecomment-579063998
>

-- 
	Philip Kaludercic

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[Lars Ingebrigtsen]

"J.P." <jp@neverwas.me> writes:

> Nice job on the v3 stuff. I happened across a couple capabilities being
> requested that don't officially exist, a distinction you've probably
> picked up on in the course of pursuing this work [1]. The couple that
> slipped by are always NAK'd but basically harmless, so you may just want
> to leave 'em or otherwise go your own way. If so, please ignore this.

Skimming this thread, I'm not quite sure what the conclusion is.  Should
we leave things as they are here?

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "J.P." <jp@neverwas.me> writes:
>
>> Nice job on the v3 stuff. I happened across a couple capabilities being
>> requested that don't officially exist, a distinction you've probably
>> picked up on in the course of pursuing this work [1]. The couple that
>> slipped by are always NAK'd but basically harmless, so you may just want
>> to leave 'em or otherwise go your own way. If so, please ignore this.
>
> Skimming this thread, I'm not quite sure what the conclusion is.  Should
> we leave things as they are here?

Sounds good, closing.

(There's no actual protocol violation here, just some unneeded messages.)

bug#51342: 29.0.50; remove non-CAPs from rcirc capability list

[J.P.]

Just a note for posterity. Looks like `standard-replies' is now being
formally proposed as a capability:

  https://github.com/ircv3/ircv3-specifications/pull/506