From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Thu, 06 Oct 2022 14:58:37 +0200 Message-ID: <877d1d6rcy.fsf@gmail.com> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57400@debbugs.gnu.org, Antoine Kalmbach To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 06 15:25:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogQsi-0007Hd-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 15:25:44 +0200 Original-Received: from localhost ([::1]:49214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogQsh-0008C7-ND for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 09:25:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogQSs-000114-Gj for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 08:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogQSs-00071i-86 for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 08:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogQSr-0004BU-TO for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 08:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2022 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166506112816065 (code B ref 57400); Thu, 06 Oct 2022 12:59:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 6 Oct 2022 12:58:48 +0000 Original-Received: from localhost ([127.0.0.1]:59364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogQSe-0004B2-2V for submit@debbugs.gnu.org; Thu, 06 Oct 2022 08:58:48 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:33677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogQSb-0004Ap-Sh for 57400@debbugs.gnu.org; Thu, 06 Oct 2022 08:58:46 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id a3so2649084wrt.0 for <57400@debbugs.gnu.org>; Thu, 06 Oct 2022 05:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=OOOm2YkEHBvRu121K89g/WNK7izQU+nsqu4d0Ya4BOw=; b=YpJ4EKFn22LBBw3gMZx3hxNnjgtKRHH8x7au5M2t4vbnSmnNtA4ZBZSBnUkWd7zXMO BsOAwknyS/swBBwt95oiBiXeicZf5PxXOb3MwBLlJKlPkK0k2wxsMg2JwvGQyaRPTd50 B+FpVlyKzSNt3lc1lg5UiRovrfvX6VJGUmALuh8eptCdEoZ/7t7o6ET5uFUgfSnMigo6 DjmV9ijApWMc1F2Gfj+3zeFnqNc9Wm54YYyYfpquhgKtcclbUzBmhMcHRGjXV8bO0rkI J/BJ1/UreWIbGeISxQ6KoOIMqsAUyJlUq4WjDkeoCWpPo/VFEiV38scWN7Hnto5l/oTw w8ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OOOm2YkEHBvRu121K89g/WNK7izQU+nsqu4d0Ya4BOw=; b=m1veefzGG/yu6ajRY0V11gLzp+kgwYjiSsnxet4MrX1glxRgPnGfaWbQWNrTrmF03m KP7GZ00oXJm80r9HfGywoZnUXZHxWzH9jBQuhBWYTwTZx/IF5aw0VofA6/5kRU+48mlA Orfm2O/kPFXwX/VLd4VQsKoAv2zW5YqafPYxjTTYeIjUz+dM8uuePGZwH7n6Ok1Yfpmy nXCuGVLQICxy8TEmAhC/lZeDezzk2XenQt0OvFN4+ISz1ZNEmqZEDenpAzXj2E60LYB9 A/wFZ9MSiv/5jfMu2AWTRA65A4+Mc9MJLsYNMFczJQnJg8mBzk34hgWoZCdZcBXqE1d6 yEKA== X-Gm-Message-State: ACrzQf0Uu0fyUgFYf1aD4E2rafsjdIZX3AYOuaU4AobdGmQU5dTr3q5o wlRph5c3Q+1T531hJhvyHBQ= X-Google-Smtp-Source: AMsMyM4W9B7CpUlbgRrk6b44oNJYcXgtGJzb680MxwTquF9qHvnU/rzkRsukUJdwKHOEzhZxWXTzJw== X-Received: by 2002:a5d:5849:0:b0:22b:a0e:11e0 with SMTP id i9-20020a5d5849000000b0022b0a0e11e0mr3277271wrf.72.1665061119738; Thu, 06 Oct 2022 05:58:39 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:912:1b38:fb01:987c]) by smtp.gmail.com with ESMTPSA id l6-20020a5d5606000000b00228d52b935asm18368736wrv.71.2022.10.06.05.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 05:58:38 -0700 (PDT) In-Reply-To: <8735c1nn3y.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 06 Oct 2022 12:38:25 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244665 Archived-At: >>>>> On Thu, 06 Oct 2022 12:38:25 +0000, Philip Kaludercic said: Philip> +(defcustom vc-prepare-patches-inline nil Philip> + "Non-nil means that `vc-prepare-patch' creates a single Philip> message. >>=20 >> "Whether `vc-prepare-patch' attaches all revision in a single messag= e." >>=20 >> I=CA=BCm not sure this should have the suffix '-inline', because you= can >> have inline attachments and attached attachments, but it=CA=BCs not = a big >> deal. Philip> If you have a better name, there is no better time to change it= than now. `vc-prepare-patch-attach'? `vc-prepare-patch-attach-patches'? It=CA=BCs all a bit of a mouthful to type, and it doesn=CA=BCt feel like much of an improvement over what you have. >> I also wonder about the default. Creating 100 mail buffers by accide= nt >> is harder to recover from than a single one with 100 attachments, but >> I guess experience will inform us. Philip> The only case where this might happen by accident is when someo= ne Philip> invokes `vc-prepare-patch' in a log-edit buffer where all (or a= t least a Philip> lot) of revisions have been marked. In that case, one could ad= d a Philip> "safely check" and make sure that the user actually wants to pr= oceed. That sounds sufficiently hard to achieve by accident that we should leave it alone for now. Philip> +A single message is created by attaching all patches to the bo= dy Philip> +of a single message. If nil, each patch will be sent out in a Philip> +separate message, which will be prepared sequentially." Philip> + :type 'boolean Philip> + :safe #'booleanp Philip> + :version "29.1") Philip> + >>=20 >> (I didn=CA=BCt check, can this do the [PATCH n/m] stuff with the >> subject that 'git format-patch' can do?) Philip> Yes, as the Git backend just copies the subject name that Philip> git-format-patch generates. Perfect Philip> As this is just the default value for `read-multiple-choice' a = list with Philip> commae should do. That being said, how common is it to have mu= ltiple Philip> people you consistently want to send a patch to? Usually you'd= have a Philip> central mailing list or something like that, I'd assume. Right, and it=CA=BCs a string, so it caters for multiple addresses. >> ? What does `vc-prepare-patches-inline' have to do with the SUBJECT? Philip> Because the subject for an "inline patch" is extracted from the= commit Philip> message. Perhaps mention that in the docstring? Anyway, I think I=CA=BCve picked enough nits for this patch. Robert --=20