From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: browse-url and URL handlers (MS-Windows) Date: Tue, 11 Oct 2022 19:45:46 +0200 Message-ID: <877d16dzjp.fsf@gmail.com> References: <825yh1b5si.fsf@gmail.com> <87czb61xv1.fsf@gnu.org> <82k056r7zw.fsf@gmail.com> <87fsfuee22.fsf@gmail.com> <83ilkqe2ql.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36402"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: pquessev@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 19:49:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiJO7-0009DR-UL for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 19:49:55 +0200 Original-Received: from localhost ([::1]:35118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiJO6-0005vc-Ky for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 13:49:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJKD-000488-IP for emacs-devel@gnu.org; Tue, 11 Oct 2022 13:45:55 -0400 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:36860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiJKA-0007FS-SZ; Tue, 11 Oct 2022 13:45:52 -0400 Original-Received: by mail-ed1-x52b.google.com with SMTP id e18so21214269edj.3; Tue, 11 Oct 2022 10:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M8btWm0/3x3NWPgLgqZUQ7wZzsGOuHt0QggdO+caPo0=; b=UpvK0JiSwcUaaURm6VX/uHwO6cWm1HhpvtnZO9DOB/QkNLhLvpZNEclrGA91lQTymE x7z22dhNC1yDEtUkqhrqmfVfapBqmWghl5SUmb3XHZU/NrAqxBwDWMW4Z9jaKeiLmzBh YxQO2wBqJ6I7ShbuCvFSbQFfJ24DWWnfAo6uU3yeJa7E9TTKUsabUqXK+yU8umBfVm/c xYpJXb8LnKESJG/ccy9BZtWumivUuQfVeOmDJc+V0DVKq202tRhrGWfud0FZHy5fzGGV ZtuomjmgS9RAruZmBPdrDCisEEO7o3AB0WGXGOjgYBCn3l62z8sK8A3g/+e7oUXRgRX+ nKIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M8btWm0/3x3NWPgLgqZUQ7wZzsGOuHt0QggdO+caPo0=; b=mEDfvOScDpujaXosjQEZedYHz8Dp0rMz+UroH2jDJUz8WDPUV/kU+X8YCinF3YQRXw t6SuO4VedgSwPl690TgYhEdJsDEUrpqG7DeEkfo/wdLX0EkJd3qDmFu4D+mh6Kd3YgE5 VxvOxvKLBX8NCMlxT6YZOPY9j8+YpdiMYVYFuR1CSQAT+xfZ6R/2GVzbuEpaTb7Uuh9a H9zXxgdIJpYPO9MGNOTOSe32rHzhPGYUtL44vDlr26jkpGW2tv0Ql/KeuErI1VoTAXM5 0RCZ/d3pszCv32Hmz+3s2EUWy0EjQ6XU/vnCkkezSchLE4XNv7Z2e3AmWBFYaS3RrzNy jSAg== X-Gm-Message-State: ACrzQf31S2SSiaYbC/Q0ucwl+xKJnqJ1RcC5NQV8N85pqYzn/Wm3ee0E RIfTVhdBzJ1ZD/9HkKnN2w1PSD/J0Ik= X-Google-Smtp-Source: AMsMyM44mpuFvYrziadYpYtFk+1oDLJqh1nA8+Xm+edS36wXWKBv9TTP/cG9oZ8KPtiJxLEF7e4mmA== X-Received: by 2002:aa7:c054:0:b0:453:98c6:f6c4 with SMTP id k20-20020aa7c054000000b0045398c6f6c4mr23853097edo.2.1665510348271; Tue, 11 Oct 2022 10:45:48 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::89aa]) by smtp.gmail.com with ESMTPSA id f19-20020a50a6d3000000b0044bfdbd8a33sm9623062edc.88.2022.10.11.10.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 10:45:47 -0700 (PDT) In-Reply-To: <83ilkqe2ql.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Oct 2022 19:36:50 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297515 Archived-At: On Tue, 11 Oct 2022 at 19:36, Eli Zaretskii wrote: > Is the below the right fix? > > diff --git a/lisp/url/url-parse.el b/lisp/url/url-parse.el > index 91f47d0..cc3e236 100644 > --- a/lisp/url/url-parse.el > +++ b/lisp/url/url-parse.el > @@ -201,6 +201,9 @@ url-generic-parse-url > (when (looking-at "\\?") > (skip-chars-forward "^#")) > (setq file (buffer-substring save-pos (point))) > + (if (and (eq system-type 'windows-nt) > + (string-match-p "/[A-Z]:/" file)) > + (setq file (substring file 1))) > ;; 3.5 Fragment > (when (looking-at "#") > (let ((opoint (point))) I would additionally check that the URL in question is a file:// URL. But I'm not sure these generic URL functions are the right place to =E2=80= =9Cfix=E2=80=9D this particular Windows weirdness.