From: Po Lu <luangruo@yahoo.com>
To: Qiantan Hong <qthong@stanford.edu>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add user content APIs for WebKit Xwidgets
Date: Sun, 16 Oct 2022 14:41:03 +0800 [thread overview]
Message-ID: <877d10mfsw.fsf@yahoo.com> (raw)
In-Reply-To: <264D17C0-1FD6-44BA-B8BE-28249374F7A2@stanford.edu> (Qiantan Hong's message of "Sun, 16 Oct 2022 06:29:42 +0000")
Qiantan Hong <qthong@stanford.edu> writes:
> Yes I’m aware. I was fixing them one by one.
Thanks.
> It seems that existing code is connecting signal without adding the marking
> code, guess that should be fixed too...
Where? Existing code should not connect signals to anything other than
`widget_osr' which is destroyed upon the xwidget being killed, a
prerequisite for being marked by GC.
> Those two problems above, I don’t have any existing code to imitate, so it
> would take a while to learn the codebase for me to be able to fix them.
> I’m also not sure if I should just make my part conforming or also fix all existing code.
> Is it acceptable that I submit a patch (with other problems fixed) first,
> and work on fixing these two classes of problems later?
I'd rather not install code with known memory management issues,
especially not this close to the Emacs 29 release.
next prev parent reply other threads:[~2022-10-16 6:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 6:34 [PATCH] Add user content APIs for WebKit Xwidgets Qiantan Hong
2022-10-14 7:01 ` Po Lu
2022-10-14 7:12 ` Qiantan Hong
2022-10-14 7:35 ` Po Lu
2022-10-14 21:13 ` Qiantan Hong
2022-10-15 1:37 ` Qiantan Hong
2022-10-15 7:53 ` Qiantan Hong
2022-10-15 11:23 ` Po Lu
2022-10-15 18:29 ` Qiantan Hong
2022-10-16 0:26 ` Po Lu
2022-10-15 23:33 ` Qiantan Hong
2022-10-16 4:32 ` Po Lu
2022-10-16 6:29 ` Qiantan Hong
2022-10-16 6:41 ` Po Lu [this message]
2022-10-16 6:45 ` Po Lu
2022-10-23 9:11 ` Qiantan Hong
2022-10-23 10:58 ` Po Lu
2022-10-23 22:16 ` Qiantan Hong
2022-10-24 0:30 ` Po Lu
2022-10-24 4:17 ` Qiantan Hong
2022-10-24 5:38 ` Po Lu
2022-10-24 5:44 ` Qiantan Hong
2022-10-24 7:20 ` Po Lu
2022-10-16 20:51 ` [PATCH] Add user extension " Richard Stallman
2022-10-16 21:13 ` Alan Mackenzie
2022-10-18 11:58 ` Richard Stallman
2022-10-17 5:31 ` Eli Zaretskii
2022-10-17 8:28 ` Jean Louis
2022-10-19 17:04 ` Richard Stallman
2022-10-19 19:06 ` Eli Zaretskii
2022-10-20 19:46 ` Richard Stallman
2022-10-21 5:51 ` Eli Zaretskii
2022-10-21 6:02 ` Po Lu
2022-10-23 19:14 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2020-08-28 2:25 [PATCH] Add user content " Qiantan Hong
2020-08-28 14:37 ` Lars Ingebrigtsen
2020-08-28 15:41 ` Qiantan Hong
2020-08-30 13:43 ` Lars Ingebrigtsen
2020-08-29 4:07 ` Richard Stallman
2020-08-29 4:10 ` Richard Stallman
2020-08-29 4:45 ` Qiantan Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d10mfsw.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=qthong@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.