From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Remove js--treesit-backward-up-list or fix it Date: Sat, 29 Oct 2022 21:30:24 +0200 Message-ID: <877d0ijulr.fsf@thornhill.no> References: <8B978AF7-B1CA-4C8A-9E89-84D0DEC7884C@gmail.com> <87h6znxkr0.fsf@thornhill.no> <0849BE6B-B5B4-47E0-B4EA-F93F6947C2B7@gmail.com> <87h6zmscqj.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu To: Stefan Monnier , "Theodor Thornhill via Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 21:31:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oorYE-0008Td-13 for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 21:31:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oorXT-00011o-5M; Sat, 29 Oct 2022 15:30:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oorXR-00011W-Il for emacs-devel@gnu.org; Sat, 29 Oct 2022 15:30:37 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oorXI-0003sv-D5 for emacs-devel@gnu.org; Sat, 29 Oct 2022 15:30:37 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298778 Archived-At: Stefan Monnier writes: >> Because of all the stuff we set before we init tree sitter we get a >> super unwanted behavior of the cursor jumping back to indentation for >> every () {} etc. This is because of these settings, which are IMO pretty >> bad defaults: >> ``` >> (setq-local electric-indent-chars >> (append "{}():;," electric-indent-chars)) ;FIXME: js2-mode adds "[]*". >> (setq-local electric-layout-rules >> '((?\; . after) (?\{ . after) (?\} . before))) >> ``` > > While these may be bad defaults, they should provide reasonable > behavior, so if you get cursor jumping with such settings, then we > should fix that regardless if its the default. > Yuan fixed it :-) -- Theo