From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59075: 29.0.50; Image transforms not applied to svg images Date: Mon, 07 Nov 2022 20:24:05 +0800 Message-ID: <877d077y1m.fsf@yahoo.com> References: <83o7tk1h3m.fsf@gnu.org> <83leoo1cv9.fsf@gnu.org> <87o7tk5j8h.fsf@gmx.net> <877d0858oz.fsf@gmx.net> <87v8nr8v9g.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26932"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59075@debbugs.gnu.org, Eli Zaretskii , Stephen Berman To: Evgeny Zajcev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 13:25:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os1Bn-0006p7-Mn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 13:25:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os1BY-0002l9-8I; Mon, 07 Nov 2022 07:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os1BW-0002ky-RC for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 07:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1os1BW-0007Ej-II for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 07:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1os1BW-0006u6-9G for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 07:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59075 X-GNU-PR-Package: emacs Original-Received: via spool by 59075-submit@debbugs.gnu.org id=B59075.166782386326488 (code B ref 59075); Mon, 07 Nov 2022 12:25:02 +0000 Original-Received: (at 59075) by debbugs.gnu.org; 7 Nov 2022 12:24:23 +0000 Original-Received: from localhost ([127.0.0.1]:33553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os1As-0006t8-Rp for submit@debbugs.gnu.org; Mon, 07 Nov 2022 07:24:23 -0500 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:46613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os1Aq-0006sw-Im for 59075@debbugs.gnu.org; Mon, 07 Nov 2022 07:24:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667823854; bh=3esmxAUmfovD/CaQ4sbNZbzjVLRqwMwcj8ukfMrEpP0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=mIKXTlYOPptHxnnr+O0N9jW/4EGDRLE11VsCIJZ9lsD0D1ohefUHxjVEE5w9Dl96U4VXqQ7scEHIqLMcKXt1QMCCYnNMKUYaZEXPokOaCpGe2wHXcr5Vk4cv2zfa1GRaWzAaFWqSMff0bNLj1ufLpq5XtPO6pcYm+0wP9uXmd+M4XB1A7x6+JEvdK2NdnIWci1+oSc+UgqqyfQI+xUrUbpK8x8ef4ycs/zEUw2uTMe06+p5eFWp9k6bEZo79lPeRRIKX1RhU+LNWX2+jrnJmke+xnG6092v2RQMA83TNpD5Q5E7wNin8cgJ1D9c0davDBg2qIwZ0epi1ICOzQ6Z0DQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667823854; bh=QHvJC7k7xYfnDQTmWnfCu4oA7G+XWeubVI8PF1NZ4JZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PJFnwgYmnwhwIVSvJ4D12ZVLMuTTZ3oxDfFcvMlDEx4F2yOO9D6CN34TcjENn2Yi1bymXxoC83XAdcRD5OP8nQ9d8LRTVjodUxFloBw0sumnexDgTKRlzs3RemlbUS4F+FJ0LEg46GkAW/jkyXp6906OJBDJfUDC1hjGtYgrZrbLSjCUvcilGRPGaX5S6MTsXbXN4S2uyiUw9msfob5K5DfRI4W0r0oPoMTy5/F7hy46K2fILaNlMNQVDdRyO3s8R5nztMO+h24sYf4EuYqPSltWb+OMP7wsqWeN8B8JMlcVIqj16K1el0ZnPUqO041MLYBxDPNIldgJP3Oc5QSebg== X-YMail-OSG: c.SHXJMVM1mfukhQx8Dr379_ebnwHWVAoz_PmMUp1vaAvoi._TqhV4WU3lUwy_G vyQfLjv5kEP3o5dRAfvTJKTEl5y7rnYk4PPklJdPqISRvrwqnl55vl5Uq.gD1QGdDLbwVa08us_x jq758.pOLUTQ2K4ETeBf3YQIgLmdj_uueZzPgxOjY32MYv9Sea0QzJGwehXKGXxEZhnFTcBGb5Cz dQ20skosTDv8SxR1AHtLKcf76MauYNS7v_eH2_6dgWMAwwZaLFEoKg7viirkmLT6Jq5z.5NvBeUx d8Z.pL4MaRWNY_SccskttFNDTd1oZ2fJtdKcCcHm_4vwLLhDmvUXyQzKoKnH5jiLNN9gOH.RBhwF Y.DDzgpM7H3LOIIxhFpEWN0G303h5X886XEsayxQ4t6A7xcfs9z24SyPnypn6Vl0a6TBHgrvGJ78 7rNwUJOff3b7h7l7qMKYSHu4XGr4r_gdSDIy4D.8iwg68qn9nzAMlWoyZ9UKxSkawJcq14fH8hrT I26rycxyVyscRVEZ.OdXPyNUZlXUW3JSoNKD_U73xEbji_6XWFzUM4vMsIYaNe8U5OIA4TVO3q_w rfpH3lIjXmG5fU7JFnEdBce2cgzq8U9UaCtFIXpYZZWVo48K.LFSwSbcfozOXaB4aJWG5d7UamUE a2kT1IP9e7baKx5GEfplLjfS1pDMjQbs44TIzpMU.g_Q.IrjNx17F6Whk_9bmGHJ95E.69p.PDjt hD16vRkik42Glz85U2mdVznWRyg6g742GKgKIIEMZJAHBmlzklNEQl.0M5kavf8aHJzaVer8.oSY N2U3g.e5JVFt7XBKm.uXVY7u52qOee42ZGVNaF5vyh X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 7 Nov 2022 12:24:14 +0000 Original-Received: by hermes--production-sg3-6c8895b545-pb7wm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3a2a59ffe27e995b0d6281070ebd3bef; Mon, 07 Nov 2022 12:24:11 +0000 (UTC) In-Reply-To: (Evgeny Zajcev's message of "Mon, 7 Nov 2022 13:26:00 +0300") X-Mailer: WebService/1.1.20826 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247279 Archived-At: Evgeny Zajcev writes: > =D0=BF=D0=BD, 7 =D0=BD=D0=BE=D1=8F=D0=B1. 2022 =D0=B3. =D0=B2 03:26, Po L= u : > > My suspicion is that librsvg is not being used to display SVGs at all, > on Mac OS 13. What happens if you build without native image APIs? > > Works perfectly without native image API! Resulting svg image gets corre= ct size after applying `:height', > and if I change image type to png, image is not displayed at all as expec= ted. Scratch what I said earlier. Does this fix the problem? diff --git a/src/nsimage.m b/src/nsimage.m index 9cb5090dd0..dd8768664a 100644 --- a/src/nsimage.m +++ b/src/nsimage.m @@ -74,8 +74,10 @@ Updated by Christian Limpach (chris@nice.ch) imageType =3D @"com.compuserve.gif"; else if (EQ (type, Qtiff)) imageType =3D @"public.tiff"; +#ifndef HAVE_RSVG else if (EQ (type, Qsvg)) imageType =3D @"public.svg-image"; +#endif else if (EQ (type, Qheic)) imageType =3D @"public.heic"; =20 If rsvg is present, there is no point in using native image APIs, as they do not scale SVG images nearly as well. And this part of image_set_transform gets in the way: #ifdef HAVE_RSVG /* SVGs are pre-scaled to the correct size. */ if (EQ (image_spec_value (img->spec, QCtype, NULL), Qsvg)) { width =3D img->width / FRAME_SCALE_FACTOR (f); height =3D img->height / FRAME_SCALE_FACTOR (f); } else #endif