From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#56514: ircs:// integration for rcirc (bug#56514) Date: Tue, 08 Nov 2022 06:41:43 -0800 Message-ID: <877d05jyoo.fsf__8769.00722957856$1667918566$gmane$org@neverwas.me> References: <87pmiabvd5.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4400"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 56514@debbugs.gnu.org, emacs-erc@gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 15:42:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osPoD-0000vx-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 15:42:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osPno-0000Xf-Gi; Tue, 08 Nov 2022 09:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPnh-0000V0-S1 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:42:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osPne-00048B-6Z for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:42:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osPnd-0002F9-Sv for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:42:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87pmiabvd5.fsf@neverwas.me> Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56514 X-GNU-PR-Package: emacs Original-Received: via spool by 56514-submit@debbugs.gnu.org id=B56514.16679185188614 (code B ref 56514); Tue, 08 Nov 2022 14:42:01 +0000 Original-Received: (at 56514) by debbugs.gnu.org; 8 Nov 2022 14:41:58 +0000 Original-Received: from localhost ([127.0.0.1]:36745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPna-0002Es-19 for submit@debbugs.gnu.org; Tue, 08 Nov 2022 09:41:58 -0500 Original-Received: from mail-108-mta83.mxroute.com ([136.175.108.83]:46305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPnX-0002Ec-P0 for 56514@debbugs.gnu.org; Tue, 08 Nov 2022 09:41:56 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta83.mxroute.com (ZoneMTA) with ESMTPSA id 18457b0a7db0006e99.001 for <56514@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 08 Nov 2022 14:41:45 +0000 X-Zone-Loop: e71457add43f98afce9f4a7971ab8b99451c86c81cb7 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=32wj/Xzb/EJ4ggnwRWaZ0w0HdXZSA1tgHpn0WsAkti0=; b=A EyLr98nmB7hRNrqGpl42L2WmC/qfe/1ARNC8N7WdpHLkY1DDa69ERWFx1Wi9Ghtitn3VnwhrMj+ra tQdzuTGNoasOmZoXvp+jTNszuKcGekXywKxOF+PwkbS85Rsz4gW5aaWoHVo85Ed/h+wIFaSgu8JOM RcuJK97GHFOigTMHvO/MlYGf+o5sHPUC3rG6ixz7hvGeojpwFqJiR39VYS6D6Fj+PM42phJZNx47w JrsEsfQTYhyWltA61UjoFA1RrzcM6WDfy4FjXoAX+xHp2yiY72PTNqyOdNJwL2Pm6aFjmv+3lyK4h 20jjWgvS13uFJeU9HAewoYobBYNG92adQ==; X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247334 Archived-At: Hi Philip, Just a heads up: I'm in the process of possibly tweaking url-irc (and browse-url) to better support irc:// links in internal Emacs apps. If you're interested, this mostly concerns the second patch here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56514#22 Basically, I wanted a way to tell `url-irc-erc' whether to connect via TLS without relying on port numbers and without changing the signature of `url-irc-function'. Rather than mess with `func-arity' or the like, I've opted to just hijack an existing variable from the url(-vars) library, `url-current-object', which seems ready made for this purpose. The idea is to simply bind it to the parsed URL object during calls to `url-irc-function'. Please let me know if you see any downsides to doing this or if a smarter approach comes to mind. BTW, as the patch shows, I've left the rcirc side alone. But if you want to handle ircs:// links without bothering with all the `url-current-object' business above, simply arranging to switch to 'tls whenever the port is 6697 should have you pretty well covered, I think. Let me know if that doesn't make sense. Thanks, J.P.