From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes Date: Tue, 15 Nov 2022 19:54:43 +0800 Message-ID: <877czwh1q4.fsf@yahoo.com> References: <166850936462.27011.17289179422833914249@vcs2.savannah.gnu.org> <20221115104926.5143AC0E4CA@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 12:55:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouuXQ-0003kD-0o for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 12:55:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouuWs-0003D3-HE; Tue, 15 Nov 2022 06:55:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouuWr-0003CX-NI for emacs-devel@gnu.org; Tue, 15 Nov 2022 06:55:01 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouuWq-0000iA-5q for emacs-devel@gnu.org; Tue, 15 Nov 2022 06:55:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668513296; bh=DEFipQ37cDk/FYw9FZhHCd012zjSJYiITPR2ng1g+Dg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=bNMTBVLhMjUGT0bFmUtKs4p7qmMWHSy0QNUU7GdzMTVMOhWiJn5RaPfgjAQu5diDhkFtYt7o4MJU1X7vi4rd+9iK/wjFq2L40FdfTYCj24V/Nt4LkC5y1NR21OvWpqJLym3XI1dXiLVKuPFZsMXJUNAqsbVydazQDje5fmvvKpa45wxPeZlcNqrCNxwCuqHWU8R96/wJeAHLcHzxCabbSAUqROa06MfLgWtLBrJCcNkaSKf3fqMLn3ALx9hkFyHSjwLI3WuNupgWvT4/bRJOWV2EGk4WLkS7cr44LogkVnZ0na9HSHuSf9GkVguo3R/TdnmXeoJXBT4NRMuVawgBiw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668513296; bh=SEMe6g0AtRfJ4jwQwJcEejXG5V8ZnDxjvPEu9c5vLAw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=lReQxXDR/TaRnLBoGpnBJ85riml50UBMfr3r3zB8cjuFhgO52gCua1cnSDBezWH1nOa0H2XWxEoXmPpy/B+PAd8MmCkY8DrdtHm3TimD8C2WF1eXX70nGxVOj+A2I9uVDruNo9IVYgtVtxaii+I3BzRC2wGV2/jKb+HaIRgYJX8sWCgITjy0WCqNrK9KQ0CVV1B1e/FhXbqRXmsT6KAol2DxInSOzXUfqZU1+1RcdbinEi6LYKWx//vFclUx6dUkia4r7l+rdXjnpcWrLgNKXZMUt8pKORMlOseUSO8aNw2fu9Tg1n3na6BVsmduLWMvT8t+zesMQ6wahpL6f3dXcA== X-YMail-OSG: kJDtYdEVM1md4768jOcFicyAAmaZkUCQV1EKyf7FeOQ4kvfjpJALpCw.Gu_uCf_ YJt4Xk1bZ91jK8WpgeWGzVgDemUWyNMtz_73Blv9xC2ehBbhWmFlC69BvwJjUHCspOd23k3j4C1t uHAGo1xDr0NRPTOqBs_1zqunS8eewyO._shj1uRqccT6dHIkitEoNsel3LWdtyFQsk.zRZAMEMhn 4hN_ll9AMzAdJSS0WQR9TStgt7BekKv.9U2aemGenBsOO6lXCeWiorb7ps2k_QmwupDDdqWUHvpI LUKFMde5q_owkp.MHAhbhvYLqkcgqRswzybnpHcJtKPJ2v7l324Ku.IMzjGoOWgtU1Df9HNrM.Zx QGEz.NUBpJa97vvODh_u4cypLlM03TybzdYUlqetx7YYVwfm3sMXiiOsNbv9K.IXMK8Wj9wm7IWD 3BwNEYZI7XXFb2a7vaHlpp68TU3T..6wEFfA6xJtjHkwXMJICrL9.1W8wJpWBVDJU584MfkBmuWH lZlTPBy_cApSMZjp6Zgo1d8MktaYVtAvj7bPm19ZLVZwYcR2.mJ.XFK0g7PKR1LQ65k6I9paTaFJ tLtNL6w4VbE3GihB9e3tzNh7UubFSDQazK81QfKRc2zMGAZXqgocXXiEe_9G5bfNsX8bUK9gsIl8 wnEbN9yw7tdUzTYzEkaAQvpuDjOU4vOq4LGzlPpezv46Ym81uOziPuo71C7imfbaPnxcVYNzUJMV KzHJb1Qq6Zg8CmrAWnXp1nNYieo83IrLpiE6t4jmVnwRCkzUJ4XoKt.Sg6Nc1krTBpPKKsTbDlOh YAKqkTQu0TaDIHCxXqQoekqegpAUAe4NMmG6.lgxjS X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Tue, 15 Nov 2022 11:54:56 +0000 Original-Received: by hermes--production-sg3-6c8895b545-pb7wm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID df453b3cd88d2391a983584c7319714b; Tue, 15 Nov 2022 11:54:51 +0000 (UTC) In-Reply-To: <20221115104926.5143AC0E4CA@vcs2.savannah.gnu.org> (Yuan Fu's message of "Tue, 15 Nov 2022 05:49:25 -0500 (EST)") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299843 Archived-At: Yuan Fu writes: > +static Lisp_Object > +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *); This should be: static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t, struct buffer *); > + Lisp_Object lisp_ranges = treesit_make_ranges(ranges, len, buf); There is a missing space between "treesit_make_ranges" and its parameters. > + FOR_EACH_TAIL (functions) > + safe_call2(XCAR (functions), lisp_ranges, parser); Here too, between safe_call2 and the parameters. > + treesit_call_after_change_functions(tree, new_tree, parser); And here. > +DEFUN ("treesit-parser-notifiers", > + Ftreesit_parser_notifiers, > + Streesit_parser_notifiers, > + > +DEFUN ("treesit-parser-add-notifier", > + Ftreesit_parser_add_notifier, > + Streesit_parser_add_notifier, > + > +DEFUN ("treesit-parser-remove-notifier", > + Ftreesit_parser_remove_notifier, > + Streesit_parser_remove_notifier, Can't you put all of these on one line?