From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Thu, 24 Nov 2022 14:09:08 -0800 Message-ID: <877czkm2d7.fsf@ericabrahamsen.net> References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <87sfigx58k.fsf@ericabrahamsen.net> <87k03nx2t1.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 23:10:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyKQE-0004R1-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 23:10:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyKQ1-0000UZ-5e; Thu, 24 Nov 2022 17:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyKPz-0000Tc-Gj for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 17:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyKPz-0005pX-88 for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 17:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyKPy-0000r0-2Q for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 17:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.16693277593230 (code B ref 59314); Thu, 24 Nov 2022 22:10:02 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 24 Nov 2022 22:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:60452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyKPH-0000q2-7I for submit@debbugs.gnu.org; Thu, 24 Nov 2022 17:09:19 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:53454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyKPE-0000po-SH for 59314@debbugs.gnu.org; Thu, 24 Nov 2022 17:09:17 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 35CD3FA08F; Thu, 24 Nov 2022 22:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669327750; bh=2XnBlQC9/bzIk2FSdxsWxM+sHCloGfph18YETAunMks=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=o3VjFIiE48fvBbVYmv/O5oBikGPIbtvQG0FgrMbYQsPRgwbwIbpAKQ2ShU4agsLY8 N9kWgEMwSpdBxF8Dew89AA0fv7CFREeCAjdl9cPKYOPNn8tjtxA1thg1RlsuWF6oZy RD4swUTq55/Ijrwoof+Ho0wiQK0LIxFUCcvNHM90= In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 24 Nov 2022 02:24:10 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248924 Archived-At: On 11/24/22 02:24 AM, Thomas Fitzsimmons wrote: > Thomas Fitzsimmons writes: > >> Eric Abrahamsen writes: >> >>> Thomas Fitzsimmons writes: >>> >>> [...] >>> >>>> That's the extent of my email completion setup. I think the only reason >>>> this setup doesn't generalize (assuming an EUDC EBDB backend in your >>>> case) is that other people like different UIs, e.g., when the same >>>> prefix expands to multiple possible addresses (as you alluded to), what >>>> UI should one use to select? I use the UI provided by EUDC. >>>> >>>> Anyway, tonight I did manage to add ERT tests for the EUDC LDAP backend. >>>> Can you try: >>>> >>>> make -C test lisp/net/eudc-tests.log >>> >>> No love! >>> >>> Running 11 tests (2022-11-21 16:04:40-0800, selector `(not (or (tag :unstable) (tag :nativecomp)))') >>> passed 1/11 eudc--plist-member (0.000396 sec) >>> passed 2/11 eudc-lax-plist-get (0.000433 sec) >>> passed 3/11 eudc-plist-get (0.000417 sec) >>> passed 4/11 eudc-plist-member (0.000390 sec) >>> passed 5/11 eudc-test-make-address (0.000151 sec) >>> passed 6/11 eudc-test-rfc5322-quote-phrase (0.000067 sec) >>> passed 7/11 eudc-test-rfc5322-valid-comment-p (0.000760 sec) >>> skipped 8/11 eudcb-bbdb (0.000102 sec) >>> passed 9/11 eudcb-ecomplete (0.007451 sec) >>> Loading eudcb-ldap... >>> Parsing results... >>> Parsing results... done >>> Parsing results... >>> Parsing results... done >>> Test eudcb-ldap backtrace: >>> signal(error ("No match")) >>> apply(signal (error ("No match"))) >>> (setq value-640 (apply fn-638 args-639)) >>> (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq form- >>> (if (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq f >>> (let (form-description-642) (if (unwind-protect (setq value-640 (app >>> (let ((value-640 'ert-form-evaluation-aborted-641)) (let (form-descr >>> (let* ((fn-638 #'equal) (args-639 (condition-case err (let ((signal- >>> (let ((ldap-process (start-process "slapd" "*slapd*" "/usr/sbin/slap >>> (closure (t) nil (let ((value-636 (gensym "ert-form-evaluation-abort >>> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test >>> ert-run-test(#s(ert-test :name eudcb-ldap :documentation "Test the L >>> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m >>> ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil >>> ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) >>> ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco >>> eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n >>> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/eudc-tests.el" " >>> command-line() >>> normal-top-level() >>> Test eudcb-ldap condition: >>> (error "No match") >>> FAILED 10/11 eudcb-ldap (1.024022 sec) at lisp/net/eudc-tests.el:271 >>> Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... >>> Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... done >>> passed 11/11 eudcb-mailabbrev (0.002174 sec) >>> >>> Ran 11 tests, 9 results as expected, 1 unexpected, 1 skipped (2022-11-21 16:04:41-0800, 1.151547 sec) >>> >>> 1 unexpected results: >>> FAILED eudcb-ldap >>> >>> 1 skipped results: >>> SKIPPED eudcb-bbdb >> >> Thanks for trying. >> >> > [...] > >> (In a subsequent patch I'll replace the sleep with a retry loop to >> make this more reliable.) > > I pushed this patch to the master branch. When you get a chance, can > you retry: > > make -C test lisp/net/eudc-tests.log > > and see if it succeeds for you now? slapd refuses to run without root permissions on my laptop for some reason, so this will have to wait until next Monday when I'm back at my desktop.