From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals-release/org e2366ac283: * lisp/org-persist.el: Do not litter /tmp when native compiling Date: Wed, 21 Dec 2022 19:15:48 +0000 Message-ID: <877cyka7q3.fsf@localhost> References: <167164907706.9937.9724677162932540750@vcs2.savannah.gnu.org> <20221221185757.74391C00613@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 21 20:17:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p84aK-0008Z9-2S for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Dec 2022 20:17:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p84ZN-0000rD-8Z; Wed, 21 Dec 2022 14:16:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p84ZL-0000qh-Ky for emacs-devel@gnu.org; Wed, 21 Dec 2022 14:15:59 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p84ZJ-00008M-8v for emacs-devel@gnu.org; Wed, 21 Dec 2022 14:15:59 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 64C3424002A for ; Wed, 21 Dec 2022 20:15:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671650155; bh=jxASyX/Z2P6uhmhXi0yhEKEvtMFS20i/E8cFRqp5aIk=; h=From:To:Cc:Subject:Date:From; b=JMlpgiicik/gCcpWgh2QTyMRoDHCmYZNO2aAVP5aVuhPostkjSWBiUe0PC0yKKi+B XHMiFTf4mm0l6hHhxhHbr/MF453J0DFmWts6jFj4gjzQPvEQiZv8VzagPJ/0N/UPQW K7fVhncG6i1I7U+MhN7x0z51jf2UObaerkrOZDynpQoix80J6/BmmlC/Xy2/EE1NcE wVZ8r5sI1AIvtNpmGCE3JL/E1indflxX/eFR7rIub3sI6TxycVIDgVNaHCKy53y9dA H7BReoS3lAlj61Y4lNamxjPfkA6XeaOZTkbNEhssqjxFvlaeonbqZf5tQjFUjnmbAw PgZ0eEc6CpHPg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NcjpL3GPhz9rxF; Wed, 21 Dec 2022 20:15:53 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301771 Archived-At: Stefan Monnier writes: >> + (setq org-persist-directory >> + (make-temp-file "org-persist-" 'dir)) >> + ;; We don't need the temp directory to exist. >> + ;; `org-persist-write-all' will refrain from creating and writing to the dir if >> + ;; none exists yet. >> + (delete-directory org-persist-directory)) > > Could we skip the "create dir" so we can skip the `delete-directory` > part as well? It would be wonderful, but There is a race condition between calling make-temp-name and later creating the file, which opens all kinds of security holes. For that reason, you should normally use make-temp-file instead. which scared me. > Also, this smells like a security hole: after `delete-directory`, with > the /tmp setup as mode #o1777, some other user can come and create > a directory at that location, so that our `org-persist-directory` will > then point to their directory (where they may be able to read the > things we write) or they can replace it with a link to a directory of > our own tricking us into overwriting some of our own files. This also means that other user has access to Elisp machine state (the value of org-persist-directory). If we are in that situation, your scenario is the least of our concerns. Also, do note that this branch of code is only executed with emacs -Q. > IOW, I suggest we use something like > > (setq org-persist-directory "/non-existing") > or > (setq org-persist-directory (make-temp-name "/non-existing")) > > [ Not sure if there is a standard such name that's "guaranteed" not to > exist. ] If you confirm that it is safe to use `make-temp-name' here, I will go with your suggestion. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at