all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals-release/org e2366ac283: * lisp/org-persist.el: Do not litter /tmp when native compiling
Date: Wed, 21 Dec 2022 19:15:48 +0000	[thread overview]
Message-ID: <877cyka7q3.fsf@localhost> (raw)
In-Reply-To: <jwv3598r38i.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  (setq org-persist-directory
>> +        (make-temp-file "org-persist-" 'dir))
>> +  ;; We don't need the temp directory to exist.
>> +  ;; `org-persist-write-all' will refrain from creating and writing to the dir if
>> +  ;; none exists yet.
>> +  (delete-directory org-persist-directory))
>
> Could we skip the "create dir" so we can skip the `delete-directory`
> part as well?

It would be wonderful, but

    There is a race condition between calling make-temp-name and
    later creating the file, which opens all kinds of security holes.
    For that reason, you should normally use make-temp-file instead.

which scared me.

> Also, this smells like a security hole: after `delete-directory`, with
> the /tmp setup as mode #o1777, some other user can come and create
> a directory at that location, so that our `org-persist-directory` will
> then point to their directory (where they may be able to read the
> things we write) or they can replace it with a link to a directory of
> our own tricking us into overwriting some of our own files.

This also means that other user has access to Elisp machine state (the
value of org-persist-directory). If we are in that situation, your
scenario is the least of our concerns. Also, do note that this branch of
code is only executed with emacs -Q.

> IOW, I suggest we use something like
>
>     (setq org-persist-directory "/non-existing")
> or
>     (setq org-persist-directory (make-temp-name "/non-existing"))
>
> [ Not sure if there is a standard such name that's "guaranteed" not to
>   exist.  ]

If you confirm that it is safe to use `make-temp-name' here, I will go
with your suggestion.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



  reply	other threads:[~2022-12-21 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167164907706.9937.9724677162932540750@vcs2.savannah.gnu.org>
     [not found] ` <20221221185757.74391C00613@vcs2.savannah.gnu.org>
2022-12-21 19:07   ` [elpa] externals-release/org e2366ac283: * lisp/org-persist.el: Do not litter /tmp when native compiling Stefan Monnier
2022-12-21 19:15     ` Ihor Radchenko [this message]
2022-12-21 19:54       ` Stefan Monnier
2022-12-25  9:22         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cyka7q3.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.