[Bug] isearch errors when org-fold-core-style is 'overlays

[Bug] isearch errors when org-fold-core-style is 'overlays

[Matt Lundin]

I'm finding that isearch fails to unfold the correct region or to search
in the correct region when there are folded regions in a buffer and
`org-fold-core-style` is set to 'overlays.

Here is a minimal recipe for reproducing the bug:

Use a minimal emacs startup file:

--8<---------------cut here---------------start------------->8---
(add-to-list 'load-path "~/org-mode/lisp/")
(setq org-startup-folded t)
(setq org-fold-core-style 'overlays)
--8<---------------cut here---------------end--------------->8---

Open the following file:

--8<---------------cut here---------------start------------->8---
* One
word
* Two
word
--8<---------------cut here---------------end--------------->8---

Issue #1:

Go to the beginning of headline "Two" when the trees are folded.

Type "M-x isearch word [RET]".

Expected behavior: isearch should reveal the entry under headline two
and shift the highlighted region dynamically as the characters typed
begin to match.

What happens: the beginning of the highlighted region remains stuck at
the beginning of the headline and the entry does not unfold until after
the return key is pressed.

Issue #2:

Cycle headlines to folded state. Go to the beginning of headline "Two".

Type "M-x isearch word [RET]".

Note that during this second search dynamically highlighted region
expands to include the folded headline "One". Once return is pressed,
isearch reveals the entry under headline "One" and moves the point to
the "word" there. 

After running git bisect, I traced the issue to commit
6cd7c6fb1cf6363f1057086760bed9875cdd97c7

Thanks,

Matt

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Matt Lundin <mdl@imapmail.org> writes:

> Here is a minimal recipe for reproducing the bug:
>
> Use a minimal emacs startup file:
>
> --8<---------------cut here---------------start------------->8---
> (add-to-list 'load-path "~/org-mode/lisp/")
> (setq org-startup-folded t)
> (setq org-fold-core-style 'overlays)
> --8<---------------cut here---------------end--------------->8---
>
> Open the following file:
>
> --8<---------------cut here---------------start------------->8---
> * One
> word
> * Two
> word
> --8<---------------cut here---------------end--------------->8---
>
> Issue #1:
>
> Go to the beginning of headline "Two" when the trees are folded.
>
> Type "M-x isearch word [RET]".

Confirmed.
Part of the problem is some undocumented behaviour of isearch.
I will need to consult Emacs devs before fixing.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Samuel Wales]

possibly related: are links still not searchable with iserch without
being in reveal mode or similar?  [9.4 here.)

On 12/28/22, Ihor Radchenko <yantar92@posteo.net> wrote:
> Matt Lundin <mdl@imapmail.org> writes:
>
>> Here is a minimal recipe for reproducing the bug:
>>
>> Use a minimal emacs startup file:
>>
>> --8<---------------cut here---------------start------------->8---
>> (add-to-list 'load-path "~/org-mode/lisp/")
>> (setq org-startup-folded t)
>> (setq org-fold-core-style 'overlays)
>> --8<---------------cut here---------------end--------------->8---
>>
>> Open the following file:
>>
>> --8<---------------cut here---------------start------------->8---
>> * One
>> word
>> * Two
>> word
>> --8<---------------cut here---------------end--------------->8---
>>
>> Issue #1:
>>
>> Go to the beginning of headline "Two" when the trees are folded.
>>
>> Type "M-x isearch word [RET]".
>
> Confirmed.
> Part of the problem is some undocumented behaviour of isearch.
> I will need to consult Emacs devs before fixing.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Samuel Wales <samologist@gmail.com> writes:

> possibly related: are links still not searchable with iserch without
> being in reveal mode or similar?  [9.4 here.)

Unrelated.
The reported issue is related to the new org-fold implementation.

The old issue with searching links is known. It is simply because
isearch does not support searching inside invisible text. And links are
abbreviated by applying invisible text property to the hidden parts.

You either upgrade or set isearch-invisible to t.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Part of the problem is some undocumented behaviour of isearch.
> I will need to consult Emacs devs before fixing.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Samuel Wales]

more below.

On 12/29/22, Ihor Radchenko <yantar92@posteo.net> wrote:
> Samuel Wales <samologist@gmail.com> writes:
>
>> possibly related: are links still not searchable with iserch without
>> being in reveal mode or similar?  [9.4 here.)
>
> Unrelated.
> The reported issue is related to the new org-fold implementation.

ok didn't men to lower s/n.

tanks for your patience.

>
> The old issue with searching links is known. It is simply because
> isearch does not support searching inside invisible text. And links are
> abbreviated by applying invisible text property to the hidden parts.

>
> You either upgrade or set isearch-invisible to t.


i look forward to it if it is fixed.  fwiw i vaguely thought the issue
was overlays or so, as the default value is 'open.  but it sounds like
you are saying this was fixed in emacs or org.  i do have a vague
inkling that it was fixed in future emacs or org.


>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Part of the problem is some undocumented behaviour of isearch.
>> I will need to consult Emacs devs before fixing.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399

There seems to be no easy way to fix isearch yet retaining the ability
to obey `org-fold-show-context-detail'.  I have disabled
`org-fold-show-context-detail' when revealing folds temporarily +
`org-fold-core-style' = 'overlays.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=df4a5d86d

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>