all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Andreas Gerler <baron@bundesbrandschatzamt.de>
Cc: Ruijie Yu <ruijie@netyu.xyz>, emacs-orgmode@gnu.org
Subject: Re: [O] [PATCH] ob-eval: display error fix
Date: Fri, 27 Jan 2023 13:10:11 +0000	[thread overview]
Message-ID: <877cx886oc.fsf@localhost> (raw)
In-Reply-To: <94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de>

Andreas Gerler <baron@bundesbrandschatzamt.de> writes:

> +(defcustom org-babel-eval-error-display-notify nil
> +  "Display org-babel-eval-errors always or only if exit code is not 0."

This docstring is confusing. What will happen if the value is nil?
non-nil? I cannot answer these questions by reading the docstring.

Also, what is "org-babel-eval-errors"? Symbol?

Finally, I do not think that "nil" is a good default here. It is better
to display warnings by default and let people disable them only
consciously, when needed. Ideally, we may allow the value to be a list
of backends where to display/not display the warnings.

> +  :group 'org-babel
> +  :version "29.1"

Please use :package-version instead.

And add the new customization to etc/ORG-NEWS.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  parent reply	other threads:[~2023-01-27 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07 13:24 [O] [PATCH] ob-eval: display error fix Andreas Gerler
2023-01-07 21:33 ` Ruijie Yu via General discussions about Org-mode.
2023-01-08 11:16   ` Andreas Gerler
2023-01-27  1:48     ` Ruijie Yu via General discussions about Org-mode.
2023-01-27 13:10     ` Ihor Radchenko [this message]
2023-02-03 17:04       ` Andreas Gerler
2023-04-14 12:44 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cx886oc.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=baron@bundesbrandschatzamt.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=ruijie@netyu.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.