From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict Date: Wed, 01 Feb 2023 14:44:26 +0100 Message-ID: <877cx1o5z9.fsf@gmail.com> References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <831qna3frm.fsf@gnu.org> <87mt5yogct.fsf@gmail.com> <83y1pi1wz4.fsf@gnu.org> <87ilgmodk4.fsf@gmail.com> <83mt5y1r5u.fsf@gnu.org> <87bkmdo8e4.fsf@gmail.com> <831qn91qo0.fsf@gnu.org> <137753af-777d-2da3-c111-7e2d414633f1@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33035"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 01 14:45:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNDQM-0008OI-6r for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Feb 2023 14:45:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNDPj-000837-Ut; Wed, 01 Feb 2023 08:44:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNDPg-00082I-GC for emacs-devel@gnu.org; Wed, 01 Feb 2023 08:44:36 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNDPe-0008SR-NY; Wed, 01 Feb 2023 08:44:36 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso2579683wmb.0; Wed, 01 Feb 2023 05:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=NrF9CXSWi4FLJucQi7mrAbDFczcmfoDMIpvyP8To1Tg=; b=i3U4szNklY7G39tNjl9uBR98gc8XUTAlb0dWIFkBrSuumDfF1yEKOazBwMWjhBMZKB Vqeu7Vey2KFcYSLR7zfI6pBbh5/Pzd0V78We6O7FHdd28pK0Mnhbl0bfnOzxJfML5lni GMrupKnzhQah8L8XvzoI/sAMpj/rdtmKSSdlgKdjE+5gd+k9v80SCL9eLhIfpdkfwtJz maHruVflQTKot+iZFChlKfyl5ZtxON4il3Q4PBZeV9cbjQcfIj1eR7OLct9IvTfMrazI wPmzakaFKQxKBtPwxckRxad8fgiBqB4o6+dZZEN9rez8WyjVNeaR1W2R7gOt8v1H0dM+ AA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NrF9CXSWi4FLJucQi7mrAbDFczcmfoDMIpvyP8To1Tg=; b=iNwV7qOi/WIEmoEnknuG4KHQhGZWm0u9PfciHm0Jw1xvdrguUaWfI71WDgjJvlbG7i 6dkEyEJy4GsUPhl9OsKkMJ6BQas9HHkFNGlXEZtZi1L+rmrRgxV7Gj9wfXwvm7atK1FN tbpqjzX6lxM7U76omA/UAdyVvU2JgXo3FcusmFL26WvO6XZL+5jr4ddwqPkBiJ6HCetz 4FH4m6Tsuh7Vgzy2CXJv7I2sHa/vRDzjv4ZSROOWiqQtqmd21Hk6AMSyHzkWEFLMtdf2 bzAD4S3hoCnKwrS3qfpFdEMr+A1mwigt07qpcV/f7QcAqvDKq5jKwJQRkhrNwTqJ24Fz 0fsg== X-Gm-Message-State: AO0yUKXY0zznnHHZ7Zqr2RMuHe3xoWW5w7EaDcpvB6/VezOkltpPvtum ioUXMMGtX2YEY/ZSXKTOHtg= X-Google-Smtp-Source: AK7set86B4f7XuBkzYSOwcgT0YvnS242GPtDP9BCCokMhTAr8LufLSOyVoJI4Hz6eWhGtCmJicS3lg== X-Received: by 2002:a7b:c8ce:0:b0:3d9:ebf9:7004 with SMTP id f14-20020a7bc8ce000000b003d9ebf97004mr2124120wml.29.1675259068318; Wed, 01 Feb 2023 05:44:28 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q17-20020a05600c2e5100b003dd1aa227afsm1660739wmf.31.2023.02.01.05.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 05:44:27 -0800 (PST) In-Reply-To: <137753af-777d-2da3-c111-7e2d414633f1@daniel-mendler.de> (Daniel Mendler's message of "Wed, 1 Feb 2023 14:13:25 +0100") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302860 Archived-At: >>>>> On Wed, 1 Feb 2023 14:13:25 +0100, Daniel Mendler said: >> Yes, exactly. Thanks. >>=20 >> Unless anyone else objects, please install this in a day or two. Daniel> I object. With this change the non-interactive implementation is Daniel> polluted with an unnecessary INTERACTIVE argument, which would = then Daniel> allow the non-interactive caller to still pass vector arguments= . You Daniel> could as well call the argument ALLOW-VECTOR. If the non-intera= ctive Daniel> function gets extended at some point with additional arguments = how Daniel> should we proceed then? I also argue that the primary use case = of these Daniel> functions is non-interactive and that should be prioritized. I use `local-set-key' interactively all the time, so I=CA=BCm not convinced that=CA=BCs generally true. Daniel> Why can you not just move the whole conversion business into the Daniel> `interactive' form? This means we cannot use a string as intera= ctive Daniel> form but we have to implement our own `keymap--read` function w= hich is Daniel> then used like this: `(interactive (list (keymap--read ...) ...= ))`. It Daniel> is not as concise as the string form but would avoid any proble= ms. That=CA=BCs basically my previous patch with the repetitive code moved into a separate function as Stefan suggested. Or we could avoid the extra arg by using `called-interactively-p' Daniel> As better alternative we could also go with Stefan's proposal t= o allow Daniel> vectors as arguments in the first place. This would resolve thi= s issue Daniel> cleanly without any extra code. And this goes against Lars=CA=BC intentions for the new keymap code, so I don=CA=BCt think that=CA=BCs a good idea. Maybe I=CA=BCll just implement my '=CE=9A' idea ;-) Robert --=20