From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-use-headings' Date: Mon, 27 Feb 2023 12:26:08 +0100 Message-ID: <877cw3ic33.fsf@gmail.com> References: <87v8mndrla.fsf@gmail.com> <87ilime025.fsf@gmail.com> <86359pm55x.fsf@mail.linkov.net> <87o7scdb45.fsf_-_@gmail.com> <837cz0z7wj.fsf@gnu.org> <87k0301h16.fsf@gmail.com> <831qp8z5gp.fsf@gnu.org> <87sfhn3tui.fsf@gmail.com> <83wn6zui9n.fsf@gnu.org> <87ilii41p9.fsf@gmail.com> <867cytgk0k.fsf@mail.linkov.net> <871qme5ej3.fsf@gmail.com> <87cz5w7ehu.fsf@gmail.com> <87pm9wcvoe.fsf@gmail.com> <878rgj7hik.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="729"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Juri Linkov , stefankangas@gmail.com, 59888@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 27 12:27:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWbez-000AXQ-RX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Feb 2023 12:27:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWbep-0003FD-Ep; Mon, 27 Feb 2023 06:27:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWbeo-0003F3-GC for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 06:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWbeo-0003nv-7j for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 06:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWben-0003Ej-Tf for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 06:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2023 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167749718012388 (code B ref 59888); Mon, 27 Feb 2023 11:27:01 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 27 Feb 2023 11:26:20 +0000 Original-Received: from localhost ([127.0.0.1]:46244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWbe7-0003Dh-MI for submit@debbugs.gnu.org; Mon, 27 Feb 2023 06:26:19 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:38876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWbe4-0003DR-NF for 59888@debbugs.gnu.org; Mon, 27 Feb 2023 06:26:17 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id cy6so24363166edb.5 for <59888@debbugs.gnu.org>; Mon, 27 Feb 2023 03:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QXJUh+5SQ9u1Qcu9Id1+k6W6X1tFXvs0DU6u7Jgvo6U=; b=IjZ9/fFetATDrYUHnTPxuUYHAPY+HtxLu8mzsP110VHBf3sz6Kmgyzs8rYexmu53cH 3EUqrlNaGmGXLfeTPHSgkG+sUJPQuLujS0SXEXS5Q4b/QNuLm09zA8d1q/zIQvICCOZI 2kuQ25xrEhV6zCpQvu3S19wLX86PSIwDFd8FnUGJVP9KViaCwI8lb0qMzrvvr1Dx9z8C t8EcfC1D4G6us/yWxJTLXA0/LXGTHPHeOGCgZkMLceDd0WYD6oAEyO8BmORqWTQSKZjF X9UP0yzXXgsi+cGZBvgn1iIz5AP3lR87a6BXJHIsatwsTHcX8PUHx2HvQ5IOIXjxw576 WPIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QXJUh+5SQ9u1Qcu9Id1+k6W6X1tFXvs0DU6u7Jgvo6U=; b=b3xpJ9AoJzKf67nJxp2UGJaRQYuNmK/S3vFHZSjft103GEnbDUnPbAevDASTtBX8CD +SELfjIQ9f+Q34SRdJmOeLIO1PtUlgxj228UGWfHKlE/quCWKr36uR6Opc1kjkGmkGlw zXs/a49YVoLbXzLbux/ftklkNVRmtWSzhzvApb8fi/DE7yOPgwmLlr7v6za6QStFpDbh soLjE0tCnVGBNPdUxMkgAKK815vwK5lcY1M64KMZsQHGnHhlxz/J6luzasGL9CoNGRoF jMZ0FN2XJ6y4NrocoxUbGhgWYMSYhl4mh6U9K5E4a9tpDBIzCKsDEHbmsmdAcq+uWn2j kxQw== X-Gm-Message-State: AO0yUKXhzs4kAXIW4hqyENg83cEnyyS+3dSOHQ/IO3+HA223DCLSBAl8 JW8e6qF/W8DdhMknwxHXMhg= X-Google-Smtp-Source: AK7set8py5c6BnhsHi7ua1V25JbcT9TvlqU1RKDc+CKW2k5id9OWMrximrDIv33+BzR8HKLQr2PvdA== X-Received: by 2002:aa7:c489:0:b0:4ad:7056:23a5 with SMTP id m9-20020aa7c489000000b004ad705623a5mr24016319edq.14.1677497170516; Mon, 27 Feb 2023 03:26:10 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id y28-20020a50ce1c000000b004acc61206cfsm3036233edi.33.2023.02.27.03.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 03:26:10 -0800 (PST) In-Reply-To: <878rgj7hik.fsf@gmail.com> (Robert Pluim's message of "Mon, 27 Feb 2023 07:24:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256869 Archived-At: On Mon, 27 Feb 2023 at 07:24, Robert Pluim wrote: > It=CA=BCs a `defcustom', so by definition it=CA=BCs a user option. If you= =CA=BCre not > expecting it to be modified, maybe make it a `defvar'. Oops, I wrote this a couple months back and had forgotten. I don't know if you have an opinion. `grep-regexp-alist' is a defconst, which seems exaggerated, but `grep-match-regexp' is a defcustom although nobody should want to change this except to work around bugs. My new variable has a similar "degree of technicality" and I think that asks for be a defvar.