From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62162: 29.0.60; xref.el doesn't compile on Emacs 26, because multi-pair setq-local Date: Mon, 13 Mar 2023 23:38:54 +0000 Message-ID: <877cvkp6gh.fsf@gmail.com> References: <87bkkwpxms.fsf@gmail.com> <86fsa835yf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62162@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 14 00:38:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbrkN-0009cg-J2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Mar 2023 00:38:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbrk0-0007BI-KK; Mon, 13 Mar 2023 19:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbrju-0007Ad-Sh for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 19:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbrju-0003LG-KF for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 19:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbrju-00013s-9H for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 19:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Mar 2023 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62162 X-GNU-PR-Package: emacs Original-Received: via spool by 62162-submit@debbugs.gnu.org id=B62162.16787506233988 (code B ref 62162); Mon, 13 Mar 2023 23:38:02 +0000 Original-Received: (at 62162) by debbugs.gnu.org; 13 Mar 2023 23:37:03 +0000 Original-Received: from localhost ([127.0.0.1]:35798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbrix-00012G-GT for submit@debbugs.gnu.org; Mon, 13 Mar 2023 19:37:03 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:45792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbriw-00011m-6W for 62162@debbugs.gnu.org; Mon, 13 Mar 2023 19:37:02 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id m18-20020a05600c3b1200b003ed2a3d635eso1238532wms.4 for <62162@debbugs.gnu.org>; Mon, 13 Mar 2023 16:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678750616; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uCki3U2hdeMTzXiepTlSQ9W56f+JyEMJMhkpbLF5pWA=; b=Godv9p09eVy0BHF3D7B4b+BnhErnNyG6FCpo/KN9Nx+d2JXTHSylBt1bQLDy8zEnXy uXmLsbuSY7hGZ3p8I2hXRjBeO0GKkrK8425CJy+SBjDGuxRqAXuVT8UKq9ehC3RAY50n gGfCQgccqHTtx8uGqsf+hrcvNmuPTrcy8sr5/tmoVXq05a3gZOP/kSvKIN1emd+XTANP r7Ey4oMc+HYzPvxEp8+Fy9G5C6pSR+t6lLZpAiRS7GVXeC/Nql3E3pffyqmyJFjjZezx IR354Sbzcp33OVnA9G5OPgzRUbMxARhgvMabXx7e+F8lpQxjAAnaRqfN0o1q6zzn5RyA ecuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678750616; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uCki3U2hdeMTzXiepTlSQ9W56f+JyEMJMhkpbLF5pWA=; b=r3hRLVvMLmL/Ay0Zstk3xH3yrponSDio7oNLMpV3flB0rQB+hB4r2MxcVVYqVoujD4 irA8bstNBy1pwH4xWjvydlaXO10e8kAu/MdseWOohMOKG9ayKogPsVu4vO5xE6YFaqrE LflY9/kDtON2HS2NQyZK/Gr+OYcfz9J/OlRsae+IGAxlDzmJGaTh4eyNvtys8YJDr/tG uvhJTT9ZJpt7t5Zi81gj8es0ZsjmltGQOR5SvIo4wSCVEo5DKSg19UxrF9lAkaOu+KEw Ga3p97tvw17yZqZdWtsoUTQqJbMkI6VGKni3mnb348CIHc+hbsyYOk7D7bEK/eWEBqzM Tdew== X-Gm-Message-State: AO0yUKWPXNpJjKPD7JOG3MMj23NoBPUAnoo/ydvoCnVLreE0G5wPIcud 72Ezpce+4aXjxuhiWS9BFgw= X-Google-Smtp-Source: AK7set8JnVLgUI1Yq6+ThxsIYuWo1WzyQqZlbRqKGeYGc8czcIBGjg/hUj1lnxdlFeBBh5ic/uaMow== X-Received: by 2002:a1c:e913:0:b0:3eb:3912:5ae9 with SMTP id q19-20020a1ce913000000b003eb39125ae9mr12255536wmc.24.1678750616081; Mon, 13 Mar 2023 16:36:56 -0700 (PDT) Original-Received: from krug ([87.196.72.142]) by smtp.gmail.com with ESMTPSA id f24-20020a1cc918000000b003e203681b26sm1042989wmb.29.2023.03.13.16.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 16:36:55 -0700 (PDT) In-Reply-To: <86fsa835yf.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 13 Mar 2023 19:40:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257920 Archived-At: reopen 62162 thanks Juri Linkov writes: > close 62162 29.0.60 > thanks > >> I'm reasonably sure that one of the failures has to do with a multi-pair >> call to `setq-local` in xref.el which appeared in this commit >> >> commit 3573ebfa6d94411257ffefdf9eb72f508dbe502c >> Author: Juri Linkov >> Date: Wed Nov 23 10:38:28 2022 +0200 >> >> That construct should not be used in xref.el because it isn't available >> on Emacs 26, which xref purports to require. In turn, this breaks Eglot >> (and any other packge requiring xref) on those platforms. > > Now this is fixed in emacs-29.=20=20 Thanks but, I think this should have been fixed in master instead, because that's where the :core packages are built from, AFAIK, and emacs-29 doesn't have a problem with that construct. It'll make no difference soon enough, hopefully. > I hope Dmitry will decide when to bump the xref package version. I think you could have bumped the version, too. Is there any reason not to? Closing this is premature, as the problem stands: the upcoming Eglot 1.12 will have this problem on Emacs 26. Re-opening. I'll bump xref.el myself in a day or so if no-one beats me to it, and then close. Jo=C3=A3o