From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Would (Eval-when-compile (require 'treesit)) eliminate the need for (declare-function)s? Date: Mon, 17 Apr 2023 13:29:13 +0000 Message-ID: <877cuaiqmu.fsf@posteo.net> References: <6E9242F5-EC30-4BA5-A290-0AA6CCB7ECE7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , Ruijie Yu To: Ruijie Yu via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 17 15:29:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poOvN-0001ZW-Vq for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Apr 2023 15:29:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poOuX-0002jb-Dv; Mon, 17 Apr 2023 09:28:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poOuV-0002jC-MS for emacs-devel@gnu.org; Mon, 17 Apr 2023 09:28:47 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poOuT-0002Es-NS for emacs-devel@gnu.org; Mon, 17 Apr 2023 09:28:47 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 12D92240173 for ; Mon, 17 Apr 2023 15:28:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681738123; bh=VNnGuqYXcREQRHWpvURinRml6OAg/YmwDqzF7sDg6tc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=jTU6GLT5ByTYYA2WDVjKRqZk03nBnekvtgubhO5tO96Oj6JipPxwmZ+x0PUw1Iuh3 og+G5OQpyMgvpVDSiUcCWtlUdyvfmiQHbwrkq3WmFHUZ6FsfyRF204X3/aUz5mfen6 XAsIu+PmOWb/+ZMcyucIOlVvW391Ri1SaHWG7TruS/E83JnMIdnrjpqMWPvKGnNxEp A044E/nvlQPL6PZ7N54zBViwrAYixX10CX5Wdcerc+aAk4LDeda34UdhdonJrqgJOX AElOZLO47soOecBZceTK4j/SfvQTGwiXDAKYwlszgYRKJBPhIRqOOfMoibuHkPYNum fPdEWJ/uqBVcg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0SYk30lBz6tyH; Mon, 17 Apr 2023 15:28:42 +0200 (CEST) In-Reply-To: (Ruijie Yu via's message of "Mon, 17 Apr 2023 11:31:25 +0800") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305364 Archived-At: Ruijie Yu via "Emacs development discussions." writes: > Yuan Fu writes: > >> I=E2=80=99ve made the mistake of forgetting to add (declare-function tre= esit-xxx) when >> using functions from treesit.c far too many times (sorry!). Since treesi= t.el >> contains declare-function=E2=80=99s for every function in treesit.c, if = we use >> (eval-when-compile (require =E2=80=99treesit)), would it eliminate the n= eed for adding >> declare-function=E2=80=99s? Should we do that? >> >> Yuan > > According to Eli > (https://lists.gnu.org/archive/html/emacs-devel/2023-03/msg00673.html), > no, it wouldn't work. Strictly speaking, he was referring to removing `declare-function', without replacing it with anything else. Replacing that with (eval-when-compile (require 'treesit)) ^ or "eval-and-compile"? would be a different matter, since that file contains all the treesit definitions, which I *believe* should be inherited by the requiring file. > [ Also, for some reason I cannot find the message using the msgid, > 83ilezegs1.fsf@gnu.org? ] [ I could access the message, but I am accessing the list via NNTP ]