all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: "T.V Raman" <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: set-transient-map and a question
Date: Tue, 11 Jul 2023 10:03:34 +0200	[thread overview]
Message-ID: <877cr698o9.fsf@gmail.com> (raw)
In-Reply-To: <25772.44146.376434.337848@google.com> (T. V. Raman's message of "Mon, 10 Jul 2023 18:12:18 -0700")

>>>>> On Mon, 10 Jul 2023 18:12:18 -0700, "T.V Raman" <raman@google.com> said:

    T> set-transient-map is used in text-scale-adjust here:
    T> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/face-remap.el?h=master#n423...

    T> But it looks like it passes nil as the keep-pressed arg which sounds
    T> counter to the documentation for set-transient-map; but
    T> text-scale-adjust does work as intended  -- so am I reading the
    T> set-transient-map doc incorrectly?

All the bindings in that map in `text-scale-adjust' call
`text-scale-adjust', which then results in `set-transient-mapʼ being
called again, which means you donʼt need any logic to de-activate the
transient keymap when someone presses a non-text-scale-adjust key.

(Iʼve just realized `text-scale-adjust' actually uses a minor-mode,
which seems like overkill, but it works)

Robert
-- 



  reply	other threads:[~2023-07-11  8:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11  1:12 set-transient-map and a question T.V Raman
2023-07-11  8:03 ` Robert Pluim [this message]
2023-07-11 14:09   ` T.V Raman
2023-07-11 16:08     ` Robert Pluim
2023-07-11 17:16       ` T.V Raman
2023-07-11 17:44         ` Robert Pluim
2023-07-11 17:53           ` T.V Raman
2023-07-11 18:10             ` Bob Rogers
2023-07-11 20:29               ` Robert Pluim
2023-07-11 20:53                 ` T.V Raman
2023-07-12  8:51                   ` Robert Pluim
2023-07-12 13:49                     ` T.V Raman
2023-07-12  1:28                 ` Michael Heerdegen
2023-07-12  1:58                   ` T.V Raman
2023-07-12  2:32                     ` Michael Heerdegen
2023-07-12  2:49                       ` Michael Heerdegen
2023-07-12  3:21                         ` T.V Raman
2023-07-12  3:39                           ` Michael Heerdegen
2023-07-12  8:55                             ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cr698o9.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.