From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Tropin Newsgroups: gmane.emacs.devel Subject: [PATCH] notifications: Don't expand-file-name app-icon. Date: Mon, 24 Jul 2023 12:39:06 +0400 Message-ID: <877cqpsnct.fsf@trop.in> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13794"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 24 12:49:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNt7u-0003EK-Gn for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jul 2023 12:49:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNt6z-0005ka-Tv; Mon, 24 Jul 2023 06:48:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNrKz-0003sP-Sk for emacs-devel@gnu.org; Mon, 24 Jul 2023 04:54:43 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNrKw-0000re-Uh for emacs-devel@gnu.org; Mon, 24 Jul 2023 04:54:41 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CC99A60012 for ; Mon, 24 Jul 2023 08:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1690188874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=hd62J7Fzp5l1f5+Tveb/IM/ibjG1xhjbdDkunE38Dmo=; b=ctD1zu8nrE8VCMo0gcR/JYrCysvgjW9YYW7jkiULZt47OinPscTIXM2qRE6w7cDhq5h0LK kRTOKexHoaDL4BCTciBJKaU5KVq2H+jzugqU7it3NnoGZpohW/z18tz0gKMMyFPQV2NUcA fV0qllqsuu+7nliHp9JWWMaMpzLqwG+jOS67/nTR08dsxhk9jk5lohCQzkk4nXYpCiZcAk ry3cOMzBTxZHhkDr7u/L0WVATERaTFeRpydlc5w/29soJrY/fdIBGghB3vswVspNfz2ZHS Dku3zxjoWyCGyP0J/J0uNIliZMAJAKboJvsznC827yBfnnLrkc+0jy4g6TQTaA== X-GND-Sasl: andrew@trop.in Received-SPF: pass client-ip=217.70.183.195; envelope-from=andrew@trop.in; helo=relay3-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 24 Jul 2023 06:48:20 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308048 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Icon is not always a file name, but can be just an icon name. https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-la= test.html * lisp/notifications.el (notifications-notify): Don't expand-file-name app-icon. =2D-- Otherwise it not possible to send a notification similiar to: notify-send -i multimedia-player "I am playing music" lisp/notifications.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/notifications.el b/lisp/notifications.el index 984ddbec5e9..c314858d0ae 100644 =2D-- a/lisp/notifications.el +++ b/lisp/notifications.el @@ -304,7 +304,7 @@ notifications-notify notifications-application-name) :uint32 (or replaces-id 0) :string (if app-icon =2D (expand-file-name app-icon) + app-icon ;; If app-icon is nil because user ;; requested it to be so, send the ;; empty string =2D-=20 2.41.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmS+O8IACgkQIgjSCVjB 3rAXgg/8DdxNuAtQsWZDHVfd/8w9ujug1UECvATTe4AWgDeWUvXtAjX6DQEzzOfb 8JzvY1SOmmXyWEY8lVNleFLc7RLdY1CCtvyIlXAHcbbL0hdqiuNH4wYCwTVfQx6Z eBlajjejjHevFgObyzAh4d05g0rDX279aWnk8Nn9n5WP74Q52rtp9dTMZsnIfMa7 pqePzv/3nbhVoFkF3gwy38uoUZuMlkF+YKRPe9LvNSJUmEnVrT68D+PuT05DVMtW H7nkAZ+WLTd9f57gg3hSsTgtkNuErkxXj8TmFUY5Cbr9RiXprxIKQVis6gTC7kDn VqWZxSwQXY+xGQApxfW4Mef4fL6K/8B/+NQLF42MIS+E/vWpKHv2CRepCKXsShHY 3a1UNjla6fdeQGi/Gj0qhWHHTBY7KXrSjrDu+RUiM4Q4JLmaazItUbHkdk3KyJjx ta6ZBpCIuNbp+o+Ob+JSA0J9SBfkkxSjHHVp7UzaS7Kyk8A6RY0Zznb4SNspMcp1 C4qlxG2Tl6tAJ/B+YKIQScgXbWBjoHdkSgUrtpGMtXHtsjKJqtiLPUMSNCdCYChK jeyRZd6tnB+hrkr7Hjj+gWdqxmVWmudff0Q9WNHDw15mAw/4KP+8G03O5jRB32LA lemBHAUpvDh1Yc/jXUcjer3nttXyJlfyb+ZJlCO7xJK+tBkA1cA= =uXGX -----END PGP SIGNATURE----- --=-=-=--