From: Robert Pluim <rpluim@gmail.com>
To: Visuwesh <visuweshm@gmail.com>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
"Eli Zaretskii" <eliz@gnu.org>,
65030@debbugs.gnu.org, eller.helmut@gmail.com,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Subject: bug#65030: 30.0.50; Check keyword args of make-process
Date: Tue, 08 Aug 2023 15:52:58 +0200 [thread overview]
Message-ID: <877cq5abet.fsf@gmail.com> (raw)
In-Reply-To: <87fs4t64f7.fsf@gmail.com> (Visuwesh's message of "Tue, 08 Aug 2023 19:07:32 +0530")
>>>>> On Tue, 08 Aug 2023 19:07:32 +0530, Visuwesh <visuweshm@gmail.com> said:
Visuwesh> [Tuesday August 08, 2023] Robert Pluim wrote:
>>>>>>> On Sun, 6 Aug 2023 10:49:59 +0200, Mattias Engdegård <mattiase@acm.org> said:
>>
Mattias> 6 aug. 2023 kl. 06.58 skrev Eli Zaretskii <eliz@gnu.org>:
>> >> Any specific comments to the proposed patch? Or do you think it is
>> >> good to go?
>>
Mattias> Good to go as far as I'm concerned. It will be genuinely useful, and I
Mattias> see no serious problems with the implementation.
>>
Mattias> It can be extended but that would not prevent it from being committed
Mattias> as-is. For example, something that detects omitted values in the
Mattias> middle, not just the end, of the argument list. (The feasibility of
Mattias> this depends on the likelihood of argument values being keywords
Mattias> themselves.)
>>
>> I donʼt think any of the `make-process' keywords accept keywords as
>> values, but missing values tends to cause catastrophic failure, so I
>> donʼt think itʼs that common a mistake.
Visuwesh> Can you not pass keywords as non-nil values to :query and :stop?
Visuwesh> Something like,
Visuwesh> (make-process :name NAME :command COMMAND :query :yes)
Only because :yes is non-nil. Also the docstring says:
:noquery BOOL -- When exiting Emacs, query the user if BOOL is nil and
the process is running. If BOOL is not given, query before exiting.
which implies you can say
(make-process :name "foo" :noquery :stop nil)
which is not true, since :noquery is checked with `plist-get'.
Whilst weʼre at it, this is inaccurate as well:
:stop BOOL -- BOOL must be nil. The `:stop' key is ignored otherwise
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
since the following will error:
(make-process :name "foo" :command "ls" :stop t)
Robert
--
prev parent reply other threads:[~2023-08-08 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 6:47 bug#65030: 30.0.50; Check keyword args of make-process Helmut Eller
2023-08-05 9:21 ` Eli Zaretskii
2023-08-05 23:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 4:58 ` Eli Zaretskii
2023-08-06 8:49 ` Mattias Engdegård
2023-08-08 8:52 ` Robert Pluim
2023-08-08 9:16 ` Mattias Engdegård
2023-08-08 9:27 ` Robert Pluim
2023-08-08 9:42 ` Mattias Engdegård
2023-08-08 12:16 ` Eli Zaretskii
2023-08-08 13:05 ` Mattias Engdegård
2023-08-08 13:18 ` Robert Pluim
2023-08-08 16:38 ` Mattias Engdegård
2023-08-08 17:14 ` Helmut Eller
2023-08-08 20:15 ` Mattias Engdegård
2023-08-08 17:43 ` Eli Zaretskii
2023-08-08 17:51 ` Mattias Engdegård
2023-08-08 17:54 ` Stefan Kangas
2023-08-08 18:28 ` Eli Zaretskii
2023-08-08 13:37 ` Visuwesh
2023-08-08 13:52 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cq5abet.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=65030@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.