all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Richard Copley <rcopley@gmail.com>
Cc: 65175@debbugs.gnu.org
Subject: bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro
Date: Wed, 09 Aug 2023 20:44:02 +0800	[thread overview]
Message-ID: <877cq4wfl9.fsf@yahoo.com> (raw)
In-Reply-To: <CAPM58oiBY2fX1zPD50uJKNpdXZGdWNP=u8ae-DF7ewVev39KpA@mail.gmail.com> (Richard Copley's message of "Wed, 9 Aug 2023 11:49:21 +0100")

Richard Copley <rcopley@gmail.com> writes:

> When isearch is invoked from a keyboard macro, an error is signalled.
>
> Recipe:
>  C-x (      ;; kmacro-start-macro
>  C-s      ;; isearch-forward
>  e      ;; isearch-printing-char
>  <return> ;; isearch-exit
>  C-x )      ;; kmacro-end-macro
>  C-x e      ;; kmacro-end-and-call-macro
>
> Backtrace:
> Lisp error: (error "Invalid argument macro in ‘get-device-terminal’")
>   error("Invalid argument %s in `get-device-terminal'" macro)
>   get-device-terminal(macro)
>   frames-on-display-list(macro)
>   framep-on-display(macro)
>   device-class(macro nil)
>   isearch-mode(t t nil nil)
>   isearch-forward-regexp(nil 1)
>   funcall-interactively(isearch-forward-regexp nil 1)
>   command-execute(isearch-forward-regexp)
>   kmacro-call-macro(1 nil)
>   kmacro-end-and-call-macro(1)
>   funcall-interactively(kmacro-end-and-call-macro 1)
>   command-execute(kmacro-end-and-call-macro)
>
>>From the docstring for ‘last-event-frame’: "If the last event came
> from a keyboard macro, this is set to ‘macro’." When the value is
> ‘macro’, it should not be passed to ‘device-class’.
>
> Introduced in commit:
>   e3b50ec8ec1b8d1246aa2496f3fe8bf98d354545
>   Author:     Po Lu <luangruo@yahoo.com>
>   AuthorDate: Sat Jan 28 14:29:51 2023 +0800
>
>   Update Android port

I think this should be fixed now.  Please test and ack, thanks.





  reply	other threads:[~2023-08-09 12:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 10:49 bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro Richard Copley
2023-08-09 12:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-09 16:22   ` Richard Copley
2023-08-10  0:02     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cq4wfl9.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=65175@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.