all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/compat 6a60af22da: Optimize string-search
       [not found] ` <20230809135738.457BDC038BF@vcs2.savannah.gnu.org>
@ 2023-08-11  6:07   ` Philip Kaludercic
  2023-08-11  6:23     ` Eli Zaretskii
  2023-08-11  7:12     ` Daniel Mendler
  0 siblings, 2 replies; 5+ messages in thread
From: Philip Kaludercic @ 2023-08-11  6:07 UTC (permalink / raw)
  To: emacs-devel; +Cc: Daniel Mendler

ELPA Syncer <elpasync@gnu.org> writes:

> branch: externals/compat
> commit 6a60af22da1f1a7b08457a4016b9412a475afe4a
> Author: Daniel Mendler <mail@daniel-mendler.de>
> Commit: Daniel Mendler <mail@daniel-mendler.de>
>
>     Optimize string-search
> ---
>  compat-28.el | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/compat-28.el b/compat-28.el
> index fe69315522..b305ab2fff 100644
> --- a/compat-28.el
> +++ b/compat-28.el
> @@ -52,9 +52,8 @@ issues are inherited."
>    (when (and start-pos (or (< (length haystack) start-pos)
>                             (< start-pos 0)))
>      (signal 'args-out-of-range (list start-pos)))
> -  (save-match-data
> -    (let ((case-fold-search nil))
> -      (string-match (regexp-quote needle) haystack start-pos))))
> +  (let (case-fold-search)
> +    (string-match-p (regexp-quote needle) haystack start-pos)))
>  
>  (compat-defun length= (sequence length) ;; [[compat-tests:length=]]
>    "Returns non-nil if SEQUENCE has a length equal to LENGTH."

I don't believe this is a legal optimisation, even if the regular
expression is quoted.  Consider

(progn
  (string-match (rx (* "a") (group (* "b")) (* "a")) "abba")
  (match-data))
; => (0 4 1 3)

and

(progn
  (string-match (rx (* "a") (group (* "b")) (* "a")) "abba")
  (string-search "foo" "foobar")
  (match-data))
; => (0 4 1 3)

but

(progn
  (string-match (rx (* "a") (group (* "b")) (* "a")) "abba")
  (let ((case-fold-search nil))
    (string-match (regexp-quote "foo") "foobar" 0))
  (match-data))
; => (0 3)



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [elpa] externals/compat 6a60af22da: Optimize string-search
  2023-08-11  6:07   ` [elpa] externals/compat 6a60af22da: Optimize string-search Philip Kaludercic
@ 2023-08-11  6:23     ` Eli Zaretskii
  2023-08-11  8:15       ` Philip Kaludercic
  2023-08-11  7:12     ` Daniel Mendler
  1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-08-11  6:23 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: emacs-devel, mail

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Daniel Mendler <mail@daniel-mendler.de>
> Date: Fri, 11 Aug 2023 06:07:32 +0000
> 
> I don't believe this is a legal optimisation, even if the regular
> expression is quoted.

It is certainly "legal", in the sense that it breaks no laws.

The GNU Coding Standards frown on using "legal" or "illegal" for
anything that doesn't involve the laws and jurisprudence; we use
"valid" and "invalid" instead.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [elpa] externals/compat 6a60af22da: Optimize string-search
  2023-08-11  6:07   ` [elpa] externals/compat 6a60af22da: Optimize string-search Philip Kaludercic
  2023-08-11  6:23     ` Eli Zaretskii
@ 2023-08-11  7:12     ` Daniel Mendler
  2023-08-11  8:17       ` Philip Kaludercic
  1 sibling, 1 reply; 5+ messages in thread
From: Daniel Mendler @ 2023-08-11  7:12 UTC (permalink / raw)
  To: Philip Kaludercic, emacs-devel



On 8/11/23 08:07, Philip Kaludercic wrote:
> ELPA Syncer <elpasync@gnu.org> writes:
> 
>> branch: externals/compat
>> commit 6a60af22da1f1a7b08457a4016b9412a475afe4a
>> Author: Daniel Mendler <mail@daniel-mendler.de>
>> Commit: Daniel Mendler <mail@daniel-mendler.de>
>>
>>     Optimize string-search
>> ---
>>  compat-28.el | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/compat-28.el b/compat-28.el
>> index fe69315522..b305ab2fff 100644
>> --- a/compat-28.el
>> +++ b/compat-28.el
>> @@ -52,9 +52,8 @@ issues are inherited."
>>    (when (and start-pos (or (< (length haystack) start-pos)
>>                             (< start-pos 0)))
>>      (signal 'args-out-of-range (list start-pos)))
>> -  (save-match-data
>> -    (let ((case-fold-search nil))
>> -      (string-match (regexp-quote needle) haystack start-pos))))
>> +  (let (case-fold-search)
>> +    (string-match-p (regexp-quote needle) haystack start-pos)))
>>  
>>  (compat-defun length= (sequence length) ;; [[compat-tests:length=]]
>>    "Returns non-nil if SEQUENCE has a length equal to LENGTH."
> 
> I don't believe this is a legal optimisation, even if the regular
> expression is quoted.  Consider

Hi Philip,

did you notice that I replaced `string-match' with `string-match-p'?

Daniel



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [elpa] externals/compat 6a60af22da: Optimize string-search
  2023-08-11  6:23     ` Eli Zaretskii
@ 2023-08-11  8:15       ` Philip Kaludercic
  0 siblings, 0 replies; 5+ messages in thread
From: Philip Kaludercic @ 2023-08-11  8:15 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel, mail

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: Daniel Mendler <mail@daniel-mendler.de>
>> Date: Fri, 11 Aug 2023 06:07:32 +0000
>> 
>> I don't believe this is a legal optimisation, even if the regular
>> expression is quoted.
>
> It is certainly "legal", in the sense that it breaks no laws.
>
> The GNU Coding Standards frown on using "legal" or "illegal" for
> anything that doesn't involve the laws and jurisprudence; we use
> "valid" and "invalid" instead.

Ok, I did not know that.  Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [elpa] externals/compat 6a60af22da: Optimize string-search
  2023-08-11  7:12     ` Daniel Mendler
@ 2023-08-11  8:17       ` Philip Kaludercic
  0 siblings, 0 replies; 5+ messages in thread
From: Philip Kaludercic @ 2023-08-11  8:17 UTC (permalink / raw)
  To: Daniel Mendler; +Cc: emacs-devel

Daniel Mendler <mail@daniel-mendler.de> writes:

> On 8/11/23 08:07, Philip Kaludercic wrote:
>> ELPA Syncer <elpasync@gnu.org> writes:
>> 
>>> branch: externals/compat
>>> commit 6a60af22da1f1a7b08457a4016b9412a475afe4a
>>> Author: Daniel Mendler <mail@daniel-mendler.de>
>>> Commit: Daniel Mendler <mail@daniel-mendler.de>
>>>
>>>     Optimize string-search
>>> ---
>>>  compat-28.el | 5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/compat-28.el b/compat-28.el
>>> index fe69315522..b305ab2fff 100644
>>> --- a/compat-28.el
>>> +++ b/compat-28.el
>>> @@ -52,9 +52,8 @@ issues are inherited."
>>>    (when (and start-pos (or (< (length haystack) start-pos)
>>>                             (< start-pos 0)))
>>>      (signal 'args-out-of-range (list start-pos)))
>>> -  (save-match-data
>>> -    (let ((case-fold-search nil))
>>> -      (string-match (regexp-quote needle) haystack start-pos))))
>>> +  (let (case-fold-search)
>>> +    (string-match-p (regexp-quote needle) haystack start-pos)))
>>>  
>>>  (compat-defun length= (sequence length) ;; [[compat-tests:length=]]
>>>    "Returns non-nil if SEQUENCE has a length equal to LENGTH."
>> 
>> I don't believe this is a legal optimisation, even if the regular
>> expression is quoted.  Consider
>
> Hi Philip,
>
> did you notice that I replaced `string-match' with `string-match-p'?

No, I missed that.  Never mind then.

> Daniel



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-11  8:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <169158945793.6388.8459711282582712176@vcs2.savannah.gnu.org>
     [not found] ` <20230809135738.457BDC038BF@vcs2.savannah.gnu.org>
2023-08-11  6:07   ` [elpa] externals/compat 6a60af22da: Optimize string-search Philip Kaludercic
2023-08-11  6:23     ` Eli Zaretskii
2023-08-11  8:15       ` Philip Kaludercic
2023-08-11  7:12     ` Daniel Mendler
2023-08-11  8:17       ` Philip Kaludercic

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.