From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Proposal for 'package-isolate' command Date: Sun, 20 Aug 2023 06:40:16 +0000 Message-ID: <877cpq9p7s.fsf@posteo.net> References: <87r0oftgye.fsf@posteo.net> <87350vt1wz.fsf@posteo.net> <871qgen1ln.fsf@posteo.net> <87edke4mou.fsf@posteo.net> <87wmy6kuan.fsf@posteo.net> <87wmy6w070.fsf@posteo.net> <87zg2sjleg.fsf@posteo.net> <87pm3nlbm7.fsf@posteo.net> <87zg2ri9g9.fsf@posteo.net> <87bkf7b7ls.fsf@posteo.net> <87v8dfi6zy.fsf@posteo.net> <877cpvb361.fsf@posteo.net> <87pm3mj0ot.fsf_-_@posteo.net> <87v8de9qel.fsf@posteo.net> <87pm3mgj8d.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8283"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 20 08:57:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXcN5-0001xO-4p for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Aug 2023 08:57:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXcMU-0002KC-QC; Sun, 20 Aug 2023 02:56:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXcMT-0002Jd-8d for emacs-devel@gnu.org; Sun, 20 Aug 2023 02:56:33 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXcMQ-0001st-Sb for emacs-devel@gnu.org; Sun, 20 Aug 2023 02:56:33 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 05E33240027 for ; Sun, 20 Aug 2023 08:56:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692514587; bh=Sc/1BLQ5BkRZh7reVwLZQt8Z3FvP2vJSIwyn/FSPrPI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=fVjVe3XyerrwVNWltzIm4WaeVkFfsL7t+mg6KlQUnpGphUMGjeD6vOKfPLYVsQLdG yo/Yq9E0BRRizWvKK+zBHyRUMT1YqZMD0TO8T3V94loz7ZB1xOSd6Bkh7wYlDc3+a0 SXzp7RpNPbuNz/V2SuKJ72SePRx58QtjYB0LBVzUfF+CXesVRrvfwaCiNzOtLkN6Ja aYoJnemBdU/kjFmjJwHFI5oC81aVu2bHDnvJKAK9R2g/mh3Nwv3hwvgM3+ncLPgvzM BmI/u0v0tyxL31mU5x8c3EWLgejfGhTwq814AW5hYZpt40MefcyTZhbBY/QxJ8r7IA yPhfTUW3M7Ozw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RT5xQ3FNcz6tx7; Sun, 20 Aug 2023 08:56:26 +0200 (CEST) In-reply-to: <87pm3mgj8d.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308951 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Philip, Philip Kaludercic writes: > How about this patch, that will use a temporary directory when > `package-isolate' is invoked with a prefix argument (not sure what the > default should be, I guess reusing `user-emacs-directory' is less > surprising): > > [2. text/x-diff; 0001-Add-command-to-start-Emacs-with-specific-packages.p= atch]... I was reading the code of the new version of `package--dependencies` and had some questions: =2D-8<---------------cut here---------------start------------->8--- (named-let more ((pkg-desc desc)) (let (deps) (dolist (req (package-desc-reqs pkg-desc)) (setq deps (nconc (catch 'found (dolist (p (apply #'append (mapcar #'cdr (package--= alist)))) (when (and (string=3D (car req) (package-desc-nam= e p)) (version-list-<=3D (cadr req) (package= -desc-version p))) (throw 'found (more p))))) deps))) (delete-dups (cons pkg-desc deps)))) =2D-8<---------------cut here---------------end--------------->8--- Why are you using `string=3D` to compare (car req)=20 with (package-desc-name p)? Isn't (apply #'append (mapcar #'cdr (package--alist))) same as (mapcar #'cadr (package--alist))? I am not a fan of named-let but isn't using deps as a second arg of 'more' more in the named-let spirit? (fully not tested) =2D-8<---------------cut here---------------start------------->8--- (named-let more ((pkg-desc desc) (deps nil)) (dolist (req (package-desc-reqs pkg-desc)) (setq deps (nconc (catch 'found (dolist (p (apply #'append (mapcar #'cdr (package--al= ist)))) (when (and (string=3D (car req) (package-desc-name = p)) (version-list-<=3D (cadr req) (package-d= esc-version p))) (throw 'found (more p deps))))) deps))) (delete-dups (cons pkg-desc deps))) =2D-8<---------------cut here---------------end--------------->8--- Thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmThuRgTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk5X3C/9fV4idOGPNtddFO7fYUKQOzvNu7acd DYiIGKtNM9NRzrr0c5fnrlfPpJCEF2f7KvskYajJNfnO9ojQLsg1VJGC4m/dJaED 6/To1XhQ1RQYTa5PMVXf5kS5rZrlK2JoM/KDY/eaVoQ2BgUAu1MKCM5s+VTzicXl jPofqOCutLqEfuPyMoWpQldeTBYonzTprjsY0fnW+GFN4ah0LShyttW3uQY/Ek+5 Arb+zy5X0Z0RwS4eIE0+Gnc7kK2CaPasz+RyzbhpGUoflF5iMS+LaqaTqsi0UEH3 TbLo7129csYmiBBzZHihhNdrsWE5j4EDKvRCjjOnHQDHft1cD7J2ocxl8j7qd1/s mV8SrBmanV5mJJJ1kfSyejhExJRxBXR54jhsRXiegbr/f29uQ8qKxBsb+anBNucE ri1kHGfdj3nRh7F7CJ3klNqEAs+JmMwMw0ITy65OfP9VhjRSpQ65dwhpLSA+SBnl cghizQsKTLmzihg5gDw63gkEWJVZlO7vHjo= =uPX/ -----END PGP SIGNATURE----- --=-=-=--