From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#65518: 30.0.50; [FR Eglot] Completions over all workspace symbols Date: Sun, 27 Aug 2023 01:14:43 +0100 Message-ID: <877cphcpe4.fsf@gmail.com> References: <87ttsnqxw6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29607"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65518@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 27 02:13:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qa3PB-0007Zv-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Aug 2023 02:13:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qa3Oq-0006aU-GQ; Sat, 26 Aug 2023 20:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qa3Ok-0006a8-9Z for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 20:12:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qa3Oi-0005Xw-TU for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 20:12:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qa3Oo-0001Y9-AT for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2023 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65518 X-GNU-PR-Package: emacs Original-Received: via spool by 65518-submit@debbugs.gnu.org id=B65518.16930951445909 (code B ref 65518); Sun, 27 Aug 2023 00:13:02 +0000 Original-Received: (at 65518) by debbugs.gnu.org; 27 Aug 2023 00:12:24 +0000 Original-Received: from localhost ([127.0.0.1]:43594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qa3O7-0001XA-T3 for submit@debbugs.gnu.org; Sat, 26 Aug 2023 20:12:24 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:44420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qa3O1-0001Wt-Q1 for 65518@debbugs.gnu.org; Sat, 26 Aug 2023 20:12:18 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4fe27849e6aso3196867e87.1 for <65518@debbugs.gnu.org>; Sat, 26 Aug 2023 17:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693095122; x=1693699922; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7Oci7dkTX/G+UDVxTuxILvl7IUemWPdznr3PK2ruyts=; b=hhlYVYar4+pQNXR62HimlsQ8JE0iodJBBJtwfGT4XjT23k1/Fo9tZUVvQxbZMlpLR8 QvBAiW3L7kefVWbIrIJvYZuz1C4XWti5JwyyQSoLS+nA/6ixS02wuNMRyMtxsZ2NxufF grekeIeAmxv06IBADB4grDg3y+6tCFJFEKsiGHQuXvEce7MvZAl7x7vJYDO9oksQRRep sIhKfeXl9bKUswlhrtO5vwU2+XPvXU9PcPKR6mq7b/Jj/QQUbDkrqKB57L5BodjhvDUE 6hb1AyGbysJbR1Fyv/EgOVY7tO9356t2QQYBXAhvBGQ4AVwJlv5xNL6tgFVahzTh2M/R hGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693095122; x=1693699922; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7Oci7dkTX/G+UDVxTuxILvl7IUemWPdznr3PK2ruyts=; b=iPAof41U9Iul9zqRf2wmWGjOwYPCI5f10RUnwxtEwhd0nPuvX0rZpun2YemercnQZs fnv2addtzzX5yaNWGiKal53ygd/h/bXAvTNCu43H4C0L9nwSjV2vt3SgVHbP/4MT0Laf dabGpnH2jEV1vdegc0v+1mA/FOOMQiFrHXnFyMsXXZxyfxMa1eeoUW5l79YEcQ1HK6sg l4Z01YN381nRFqOFAyAAuSdUgeXG8hQ+pteIkbyhT+URmeEdkERDk3LqMi8AiC0uSbC4 JRa9jUQ9KovWBkjjmfqJHkL4tHtU+T4odEIXpSLnBVEIApaUkrOFJs/YX4rAiqIJqsWS 9tYA== X-Gm-Message-State: AOJu0YyG0SuiKUksJ4I8qC1qB5Q+enH74Gf/P53zlipICyGosJ/c85iz EiJQmYtFturQciNtI4z1t1AkONyZQ7jR4g== X-Google-Smtp-Source: AGHT+IFwTicX3BqcOCDi9wvmi1bT4dqHmOi2np/fxqRv2DUMy9W12hVSsTtVG41ruxUWSd0xiLsKIA== X-Received: by 2002:a05:6512:689:b0:4fb:9631:4bb with SMTP id t9-20020a056512068900b004fb963104bbmr19496809lfe.11.1693095121692; Sat, 26 Aug 2023 17:12:01 -0700 (PDT) Original-Received: from krug ([87.196.72.219]) by smtp.gmail.com with ESMTPSA id a2-20020a056000100200b0031c6cc74882sm6027944wrx.107.2023.08.26.17.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Aug 2023 17:12:01 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 26 Aug 2023 09:57:12 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268523 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > If you want a comparative analysis to lsp-mode, to increase > the chances that this is addressed, I'd also need to know exactly > how you set it up. As far as I understand, lsp-mode doesn't > do miracles, it uses the same LSP interfaces available to Eglot > (in this case, more than likely `symbol/workspace`, which I've > already described). Out of curiosity, I've had a look at lsp-mode.el. It does not use 'symbol/workspace', rather 'textDocument/documentSymbol'. So C-u M-. provides a complete list of symbols upfront. But -- crucially -- that list is limited to contain symbols for the current document only . So, at first glance, I'd say it's lsp-mode who is missing (lots and lots of) symbols. In contrast, Eglot's C-u M-. reaches all the symbols in the whole project, a much better implementation of 'xref-find-deinitions' IMNSHO. In a large project, like LLVM, using Eglot in combination with something like `M-x fido-vertical-mode` gives you an interactive incremental completion interface that is able reach millions of symbols across in thousands of C++ files. Jo=C3=A3o