all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com,  spacibba@aol.com,  emacs-devel@gnu.org
Subject: Re: c-ts-mode
Date: Thu, 07 Sep 2023 18:53:58 +0100	[thread overview]
Message-ID: <877cp1lvih.fsf@gmail.com> (raw)
In-Reply-To: <83y1hhykni.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Sep 2023 20:10:09 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: João Távora <joaotavora@gmail.com>
>> Date: Thu, 7 Sep 2023 16:58:29 +0100
>> Cc: casouri@gmail.com, spacibba@aol.com, emacs-devel@gnu.org
>> 
> I think c-ts-mode--indent-styles needs to be refactored toallow fine
> control on the indentation parameters that are currently hard-coded
> for each supported style.  They will need to have different names,
> because tree-sitter doesn't use the CC Mode terminology for the
> syntactical constructs.  Also, there seem to be many more parameters
> than in CC Mode.

I've been doing some experiments with c-ts-mode-indent-style, which can
be set to a function that returns a list that adds new items in front of
the list returned by with:

   (alist-get 'gnu (c-ts-mode--indent-styles 'cpp))

It's not super clean (notice the '--'), but not very dirty either.

The hard part is writing the rule in question, but I'll get there I
think.

> First, please submit a bug report about this with all the details.

Done.  bug#65810

> And second, I don't seem to be able to reproduce this, assuming that
> by C-M-foo you meant C-M-f and C-M-b.  Maybe this needs some
> particular source file to reproduce?  (I tried with one C file and one
> C++ file.)

You assumed correctly, And no, it works with an empty file even.  The
recipe is so simple I might as well repost it here:

  ~/Source/Emacs/emacs/src/emacs -nw -Q ~/tmp/simple.cpp -f c++-ts-mode

Then just try any C-M-f or C-M-b or C-M-u etc, and see the error
happening.

I installed my grammar with M-x treesit-install-language-grammar today.
But it also happens with a grammar installed in the same way many months
ago.

Doesn't seem to happen in c-ts-mode.

>> Setting the variable to nil brings me to more familar
>> and satisfactory terrain where, and I suppose the non-treesit
>> syntax table is being used for that.  Is there any big
>> advantage in switching to treesitter's forward-sexp-function?
>
> Yes, see treesit-defun-tactic.

Will check it out, thanks.

João



  reply	other threads:[~2023-09-07 17:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <r6t7xfcchagyl72ltdrcavncbpvba7badcoh4yimleoynmzfvb.ref@elkspm3vozuv>
2023-08-30 23:52 ` c-ts-mode Ergus
2023-09-01  4:14   ` c-ts-mode Yuan Fu
2023-09-07  9:25     ` c-ts-mode João Távora
2023-09-07  9:37       ` c-ts-mode Eli Zaretskii
2023-09-07 15:58         ` c-ts-mode João Távora
2023-09-07 17:10           ` c-ts-mode Eli Zaretskii
2023-09-07 17:53             ` João Távora [this message]
2023-09-07 18:13               ` c-ts-mode Eli Zaretskii
2023-09-07 18:23                 ` c-ts-mode João Távora
2023-09-07 18:32                   ` c-ts-mode Eli Zaretskii
2023-09-07 22:01                     ` c-ts-mode João Távora
2023-09-08  6:14                       ` c-ts-mode Eli Zaretskii
2023-09-08  7:25                         ` c-ts-mode João Távora
2023-09-08 11:25                           ` c-ts-mode Eli Zaretskii
2023-09-08 12:38                             ` c-ts-mode João Távora
2023-09-08 13:11                               ` c-ts-mode Eli Zaretskii
2023-09-08 13:32                                 ` c-ts-mode Eli Zaretskii
2023-09-08 15:15                                   ` c-ts-mode João Távora
2023-09-08 15:34                                     ` c-ts-mode Eli Zaretskii
2023-09-08 15:56                                       ` c-ts-mode João Távora
2023-09-08 18:23                                         ` c-ts-mode Eli Zaretskii
2023-09-08 18:30                                           ` c-ts-mode João Távora
2023-09-08 18:54                                             ` c-ts-mode Eli Zaretskii
2023-09-08 19:42                                               ` c-ts-mode João Távora
2023-09-09  6:09                                                 ` c-ts-mode Eli Zaretskii
2023-09-08 19:58                               ` c-ts-mode Petteri Hintsanen
2023-09-08 20:27                                 ` c-ts-mode João Távora
2023-09-09  6:19                                 ` c-ts-mode Eli Zaretskii
2023-09-13 16:15                                   ` c-ts-mode Petteri Hintsanen
2023-09-12  0:34                             ` c-ts-mode Yuan Fu
2023-09-12  7:45                               ` c-ts-mode João Távora
2023-09-12  8:00                                 ` c-ts-mode Po Lu
2023-09-12  9:51                                   ` c-ts-mode João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cp1lvih.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.