From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxim Cournoyer Newsgroups: gmane.emacs.bugs Subject: bug#66450: 29.1; Debbugs/Gnus sometimes corrupt git formatted patches Date: Sat, 14 Oct 2023 11:35:04 -0400 Message-ID: <877cnp43pz.fsf@gmail.com> References: <87y1gafi0n.fsf@gmail.com> <87a5sovqsn.fsf@ericabrahamsen.net> <87edhx44a6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66450@debbugs.gnu.org, Bruno Victal , Michael Albinus To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 17:36:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrggO-0007Kq-2V for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 17:36:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrgfz-0004l5-UD; Sat, 14 Oct 2023 11:35:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrgfy-0004ey-FC for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 11:35:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrgfy-0005qI-7M for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 11:35:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrggL-00080x-Rc for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 11:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66450 X-GNU-PR-Package: emacs Original-Received: via spool by 66450-submit@debbugs.gnu.org id=B66450.169729774030774 (code B ref 66450); Sat, 14 Oct 2023 15:36:01 +0000 Original-Received: (at 66450) by debbugs.gnu.org; 14 Oct 2023 15:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:50211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrgfz-00080H-N3 for submit@debbugs.gnu.org; Sat, 14 Oct 2023 11:35:40 -0400 Original-Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:46088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrgfv-0007zy-CQ for 66450@debbugs.gnu.org; Sat, 14 Oct 2023 11:35:37 -0400 Original-Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-4194d89a6dfso20989451cf.0 for <66450@debbugs.gnu.org>; Sat, 14 Oct 2023 08:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697297706; x=1697902506; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=B6Oa+l18TnCu3Em9/wnITPS1/hbxC3EIjubSdQpT2KY=; b=U6OeLEQEn5zM3nIdH6wrWmcCafaKb054a/9twRrmMa/xx2SUNwADPKJLZGHRyTBsMu wNgTBhhbjarRCyQYyN7IGCs0lv2EOX32VywAfGiB5Ku7U/UnQzd040hknEj+eu4M+HBO lWhXTNBxiqsvwzVBLbIlUyv+4AgaeDNcBLpH8QTfZgCi/nN3Uy3rKokZMH17X5fEE8AS y2a/jh0bJw6yP1eaQ4wUtoFZWZYHw3Cd+N3U6WjlHT6V72SmrFbhXvQ13LbAB/2pG1eL dyMIvKQm/sFLpIfO4b7byW4a245LuU5riBbx3CbE3uWpibQPMCdUdj+YNS818TzIQlZv Lo1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697297706; x=1697902506; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B6Oa+l18TnCu3Em9/wnITPS1/hbxC3EIjubSdQpT2KY=; b=iCenXSiVPsH5IJUvE3sO9pfMNqktNtC9MGqcTF70Kp3c0lkji1cn9w7DGWG9yP+WX9 kTxCl10Jx/pezPkk97SADlYjsoS6/Hgm5rvBArQnVgt1WVWNVzuQEfjn5UDbALMwQ606 vrAvhqiGf/jxu8BmZ/lAIL51vPh6Zc1NCRwjBEC1PLmDAh+XDr5odCwx5YODJeCxh5f/ sRuvPPPT05h0lrhcKZt+u5fuG3sfo4TJ5WWhIeUIBD2XX7tolnqFl2PHfOdEXfph54Ct QsIb1CRCKUosQDtMZ7Q4TYKpySz6IAyNOG+IfeHMszvgwgQ6g2OLFbOGl3n9gZ+XBfGN 1xug== X-Gm-Message-State: AOJu0Yyx4S0yR09Y4k6cpdhXCLlLyOV2QBhDUaHyHCgh6xqF/fJyU0lx x3wx+p8/6SybuCwX06Byzmk= X-Google-Smtp-Source: AGHT+IHQ3zbOtu9mGYogVCQH3pTLLmJuHSDZiWGiLcQA2lM0hY8Rw535Uo/jsJ9BjSAX4NJ4UTfI/w== X-Received: by 2002:ac8:7dd3:0:b0:410:9089:6b74 with SMTP id c19-20020ac87dd3000000b0041090896b74mr40748775qte.15.1697297705981; Sat, 14 Oct 2023 08:35:05 -0700 (PDT) Original-Received: from hurd (dsl-156-181.b2b2c.ca. [66.158.156.181]) by smtp.gmail.com with ESMTPSA id bp32-20020a05622a1ba000b004181a3eeff4sm1582162qtb.5.2023.10.14.08.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 08:35:05 -0700 (PDT) In-Reply-To: <87edhx44a6.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 14 Oct 2023 11:22:57 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272433 Archived-At: Hi again, Maxim Cournoyer writes: [...] > Eric Abrahamsen writes: [...] >> Gnus is treating the article with the `gnus-display-mime' treatment >> function, which ends up inserting newlines between detected MIME parts, >> in order to look "nice". It's not necessary to save the article to see >> this: the newlines are present if you just open Bruno's message and look >> at it. If you run `gnus-summary-show-raw-article', you'll see the >> original raw article with no newlines. >> >> The problem is that the Gnus summary "save-article" commands operate on >> the treated article, not the raw article. > > It'd be nice if that 'gnus-display-mime' procedure tried hard to *not* > break 'git format-patch' messages; perhaps it could use a simple > heuristic to do so. Out of the 63 patches in the series linked in the > reproducer steps, only patch 10/63 was corrupted by it, so it appears to > be a relatively rare occurrence. To follow-up on that, it seems the case likely to break with 'gnus-display-mime' is when a 'git format-patch' (or maybe even just a plain 'patch' one) includes patches, such as in the 10/63 patch above. -- Thanks, Maxim