From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Xiyue Deng Newsgroups: gmane.emacs.bugs Subject: bug#66782: 29.1; ERT tests report test redefined depending on loading sequence Date: Fri, 03 Nov 2023 10:56:00 -0700 Message-ID: <877cmyiuvj.fsf@debian-hx90.lan> References: <87msw393z8.fsf@debian-hx90.lan> <83y1fncl4k.fsf@gnu.org> <87o7gjgk65.fsf_-_@debian-hx90.lan> <83pm0zcc25.fsf@gnu.org> <87jzr7gfso.fsf@debian-hx90.lan> <83jzr7c74y.fsf@gnu.org> <87cywzge42.fsf@debian-hx90.lan> <83h6mbc5ss.fsf@gnu.org> <962518D0-36A0-4626-9652-0A0A977DBB2C@gmail.com> <87wmv6fnrn.fsf@debian-hx90.lan> <121E7FF6-4D07-40D5-A2D9-1B108605A117@gmail.com> <87pm0xf63w.fsf@debian-hx90.lan> <877cn3kfba.fsf@debian-hx90.lan> <87fs1ohy7m.fsf@debian-hx90.lan> <143B680E-F34D-4E5E-9D11-2C50F7263920@gmail.com> <87bkcbizns.fsf@debian-hx90.lan> <4E3AEBFB-5041-44D5-A14B-DC5E3B9E9AFA@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29537"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 66782-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 03 18:56:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyyPT-0007U9-1I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Nov 2023 18:56:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyyPD-0004tz-Uu; Fri, 03 Nov 2023 13:56:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyyPC-0004to-QD for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 13:56:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qyyPC-0007td-I1 for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 13:56:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qyyPl-0004Eq-V0 for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 13:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Xiyue Deng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2023 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66782 X-GNU-PR-Package: emacs Original-Received: via spool by 66782-done@debbugs.gnu.org id=D66782.169903420616268 (code D ref 66782); Fri, 03 Nov 2023 17:57:01 +0000 Original-Received: (at 66782-done) by debbugs.gnu.org; 3 Nov 2023 17:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:59709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyyPV-0004EK-Jf for submit@debbugs.gnu.org; Fri, 03 Nov 2023 13:56:45 -0400 Original-Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:61489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyyPU-0004E2-3d for 66782-done@debbugs.gnu.org; Fri, 03 Nov 2023 13:56:44 -0400 Original-Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6bb4abb8100so2226753b3a.2 for <66782-done@debbugs.gnu.org>; Fri, 03 Nov 2023 10:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699034162; x=1699638962; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ae814CCRX6UkIWFHUO8KO1KOX/UdMmU6CbFYzAnmpYQ=; b=YJ89izSZNxDAxIA2Ic53R2Yg7FtC+8Tx7Fx/BQQVYGbdqt60IiTTX/jc/xjH6SGlHJ hkIIwXAERUEqw5zyQAStLexdoMKD/LKV/LGr61rzovLKOGZjtnZKLwnl9e0Cwborjk3s 8BKdTHO8FZs4G/PvM/hEx16miq7MG8s65YVdBVD6ZbuTatRdPjJOzyzd1NgZWYr6zHxg lThr4S6Ijh7FqUSzi4PgSTFL9qYdIIiKx1hiV9+HCfX62FLzFcuPMb9tto6pP0Hf0WfY FT9lIppW23h1+1FSqRnC12MG+8Wk+H6Tn5fFdvyhKyqYGQ5Pnccg11/TBbk7+xWgVaVS dT6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699034162; x=1699638962; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ae814CCRX6UkIWFHUO8KO1KOX/UdMmU6CbFYzAnmpYQ=; b=lRvqtreEaFIjU9QASRQ3KA1G5hM22Xl/pnJFWbQR4iEFrd3r6Wu4yhPkJFt+FO5sQt zEUjk6oF8t5yUg0vnM29L/VoGM90pDkaK7iBxK+OtS4rt7/EkRevjKQHK/Sg1gPEHocf 24gZdwqM4/wu4soMt9ekJsD+K15QDqmctGiG1iTggv99ezWPxT9CowtBI1cxZby+niO2 EuWihSliD8PCSKfT/jkRE5tFAvJnKDW7x8O691C0pP6HqUUmBxsTFPNZBP3OKTkYUrNJ n2eUcR5xLeu2xGlK67dwUooYQZv4TvtOLrIIw1bNn+K3zdNzT6WUR0qTniNGu/NiRMIk 7C+Q== X-Gm-Message-State: AOJu0YzqMQ7KTVjuh5gxezFTwie4m8A09/sBZYQY3QzFUn1uq3Q/SNTE 1JnMvp6zd77NDR3G0kLYXdtDSa5ftDSlPQ== X-Google-Smtp-Source: AGHT+IEsxkipIdb5nfV56FphBueT679bg9xojj75SVJ/CG45ugehB4Zff9Mr/phWOBuVgghW8vwEwQ== X-Received: by 2002:a05:6a20:9599:b0:131:b3fa:eaaa with SMTP id iu25-20020a056a20959900b00131b3faeaaamr22984506pzb.61.1699034161956; Fri, 03 Nov 2023 10:56:01 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-c371-f95e-ac9f-a385.res6.spectrum.com. [2603:8000:a400:cdc:c371:f95e:ac9f:a385]) by smtp.gmail.com with ESMTPSA id t6-20020a17090ad50600b0027d219d3ac6sm1692409pju.47.2023.11.03.10.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 10:56:01 -0700 (PDT) In-Reply-To: <4E3AEBFB-5041-44D5-A14B-DC5E3B9E9AFA@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Fri, 3 Nov 2023 18:14:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273717 Archived-At: Mattias Engdeg=C3=A5rd writes: > 2 nov. 2023 kl. 23.00 skrev Xiyue Deng : > >> 1) Tests that are different but use the same test name. >>=20 >> 2) There is no tests sharing the same name, but caused by double loading >> the same test unit through a dependency by require. >>=20 >> Case 1 happens a lot in the wild and has caused many FTBFS bugs in >> Debian after upgrading Emacs to 29.1 (e.g. [1][2]), and the fix is >> simply to rename the tests. > > Thank you, I'm happy to hear that the check actually caught the kind of e= rrors it was supposed to find. > >> As a matter of fact I've spent a non-trivial time >> trying to debug this one as it depends on the loading sequence which >> caused the failure to be flaky. So I hope my proposed change can help >> people on realizing that it's case 2 a bit faster. > > That's fine, adding something like what you suggested doesn't cost us any= thing: now done on master (425d23fbea). > > I'm closing the bug now, but do say if there is something I forgot. > Thanks Mattias! Would be better if this can be applied to 29 branch as well now that 29.2 is around the corner :-) --=20 Xiyue Deng