From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.bugs Subject: bug#68395: 30.0.50; ERC 5.6-git: erc-cmd-GMSG, erc-cmd-AMSG, erc-cmd-GME, erc-cmd-AME Date: Fri, 12 Jan 2024 06:52:42 +0100 Message-ID: <877ckfw11x.fsf@dataswamp.org> References: <87h6jjw58t.fsf@dataswamp.org> <871qanp12g.fsf__35629.0631972783$1705037744$gmane$org@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68395@debbugs.gnu.org Cancel-Lock: sha1:fN5zwTYyuu4D/1jBrD/nMm07tgI= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 06:54:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOAUw-0003zj-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 06:54:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOAUZ-0003Bi-9P; Fri, 12 Jan 2024 00:54:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOAUW-0003BH-SI for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 00:54:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOAUW-0006Dg-Ji for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 00:54:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOAUU-0007iA-BC for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 00:54:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h6jjw58t.fsf@dataswamp.org> Resent-From: Emanuel Berg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 05:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68395 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170503878329556 (code B ref -1); Fri, 12 Jan 2024 05:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2024 05:53:03 +0000 Original-Received: from localhost ([127.0.0.1]:34625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOATX-0007gd-Dp for submit@debbugs.gnu.org; Fri, 12 Jan 2024 00:53:03 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:33282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOATV-0007g7-Ku for submit@debbugs.gnu.org; Fri, 12 Jan 2024 00:53:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOATS-0002zo-45 for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 00:52:58 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOATQ-0005av-7L for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 00:52:57 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rOATM-0001sf-RS for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 06:52:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277990 Archived-At: J.P. wrote: >> Patch > > I think debbugs wants the full "Tags: patch". It is there, what you cite is just what I wrote in the message instead of a bug report. > At some point, you'll need to include a commit message. I added a message, if not 'git commit' wouldn't have worked. >> --- >> lisp/erc/erc.el | 156 ++++++++++++++++++++++++++++-------------------- >> 1 file changed, 90 insertions(+), 66 deletions(-) >> >> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el >> index 478683a77f5..12078f6970d 100644 >> --- a/lisp/erc/erc.el >> +++ b/lisp/erc/erc.el >> @@ -2003,10 +2003,10 @@ erc-get-buffer >> (defun erc--buffer-p (buf predicate proc) >> (with-current-buffer buf >> (and (derived-mode-p 'erc-mode) >> - (or (not proc) >> - (eq proc erc-server-process)) >> - (funcall predicate) >> - buf))) >> + (or (not proc) >> + (eq proc erc-server-process)) >> + (funcall predicate) >> + buf))) > > I haven't looked at the proposed commands yet, but can you > remove all these hopefully inadvertent white space changes > in the meantime, please? Ah, you are using tabs in the source, saving the buffer changed them to whitespace. This is what happens if you use tabs! But you are right it wasn't intended for the patch. -- underground experts united https://dataswamp.org/~incal