From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 69555@debbugs.gnu.org, rahguzar@zohomail.eu
Subject: bug#69555: 30.0.50; shr - Preserve indentation when shr-fill-text is nil
Date: Tue, 05 Mar 2024 20:22:52 +0100 [thread overview]
Message-ID: <877cigzdo3.fsf@gmail.com> (raw)
In-Reply-To: <861q8onan6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 Mar 2024 14:09:01 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: Rahguzar <rahguzar@zohomail.eu>
>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Mon, 04 Mar 2024 23:08:20 +0100
>>
>> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>>
>> > Will post an updated patch once I have a
>> > bug number to replace the "bug#TODO" placeholders.
>>
>> See attached.
>
> The change in behavior is unconditional, AFAIU. Should we have a
> separate knob for that? Perhaps someone out there doesn't want text
> to be indented when shr-fill-text is nil?
Perhaps; I could look into adding that knob. FWIW nothing in the
original feature request (bug#66676) gives me the impression that this
new option should affect indentation; the stated motivation was:
> 1) Using `visual-line-mode` for line wrapping. I think this is more
> natural for html and makes resizing windows work more nicely.
That's why I interpret the indentation change as a side-effect; curious
to hear Rahguzar's thoughts though.
Another reason I'm not overly fond of adding another knob is figuring
out what should happen if a user keeps shr-fill-text set to t, but sets
that hypothetical indentation option to nil. Should we support that?
Or should shr-fill-text become a tri-state? (nil, 'indent-only, t)
I'm open to biting the bullet, but I'd also like to make sure we don't
sophisticate shr.el further than we want to.
> Also, please time the code on some substantially large body of text,
> with and without shr-fill-text, and compare that with the current
> version. I think performance is an important aspect of any change in
> this area.
Can do; would "(elisp) Profiling" be the starting point? (For all my
list lurking, I confess my eyes have always glossed over discussions
involving benchmarks)
(Also wondering if we have any "standard" or preferred HTML documents or
websites to throw at shr.el for benchmarking purposes; if not, I guess
I'll peruse <https://en.wikipedia.org/wiki/Special:LongPages> 🤔)
Thanks for the review!
next prev parent reply other threads:[~2024-03-05 19:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 22:02 bug#69555: 30.0.50; shr - Preserve indentation when shr-fill-text is nil Kévin Le Gouguec
2024-03-04 22:08 ` Kévin Le Gouguec
2024-03-05 12:09 ` Eli Zaretskii
2024-03-05 19:22 ` Kévin Le Gouguec [this message]
2024-03-05 19:47 ` Eli Zaretskii
2024-03-05 23:16 ` Kévin Le Gouguec
2024-03-06 11:53 ` Eli Zaretskii
2024-03-06 21:18 ` Kévin Le Gouguec
2024-03-07 6:39 ` Eli Zaretskii
2024-03-06 7:27 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-13 19:55 ` Kévin Le Gouguec
2024-03-13 20:28 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-13 21:41 ` Kévin Le Gouguec
2024-03-14 5:04 ` Eli Zaretskii
2024-03-15 7:10 ` Kévin Le Gouguec
2024-03-15 8:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cigzdo3.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=69555@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.