From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#72059: [PATCH] Ensure that git diffs without signature (--) are properly identified Date: Thu, 11 Jul 2024 15:36:35 +0200 Message-ID: <877cdshwyk.fsf@gmail.com> References: <87h6cwm86n.fsf@orpheu.olymp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25148"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72059@debbugs.gnu.org To: Luis Henriques Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 15:38:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRu0C-0006HI-DY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 15:38:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRtzo-0002AF-S4; Thu, 11 Jul 2024 09:38:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRtzn-00023y-6u for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:38:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRtzm-0006ho-Sy for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRtzm-0004eN-8K for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72059 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72059-submit@debbugs.gnu.org id=B72059.172070506817854 (code B ref 72059); Thu, 11 Jul 2024 13:38:02 +0000 Original-Received: (at 72059) by debbugs.gnu.org; 11 Jul 2024 13:37:48 +0000 Original-Received: from localhost ([127.0.0.1]:51294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRtzX-0004dt-MJ for submit@debbugs.gnu.org; Thu, 11 Jul 2024 09:37:48 -0400 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:50390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRtzT-0004df-Td for 72059@debbugs.gnu.org; Thu, 11 Jul 2024 09:37:46 -0400 Original-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52e9c6b5a62so965214e87.0 for <72059@debbugs.gnu.org>; Thu, 11 Jul 2024 06:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720704998; x=1721309798; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yCCIw/dDwlkY4TsYyKc7brdDZvLr2Xfc/SR8es4QlHI=; b=ToPM9dLSjvc1r39TMPBDDaoidV4gwT0KVZH2E1wKN+sG2a1DPLkTbExWTzlZSkOJQf 8ltNW+ITPVDaQRsxgxc1tLjRN4KzcheBL9zVMWMruzAN5CVa8kBBHz+3INuXmUvjTWE1 7d4NwQousIxVSEpM5wi0DWRQxE16MgHD94+9S2c4bqnCz5p44uVOxAGVFfTu5o8P8zBF lhtasiZSmxY+2UUySHxh0Smdzehjg8skhcTFatoT1iqEttDkn2Y0ejx0RkfCPp3Dx8AZ 6el487KzUIUza9l1q8obtltnRBfhvK4mrQ1XpcFvUn2zKCcTZ9Fd8hFxxKFWNCPxeHbP V7lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720704998; x=1721309798; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yCCIw/dDwlkY4TsYyKc7brdDZvLr2Xfc/SR8es4QlHI=; b=qBAhvXNvwfCSYqFj7YLRX1iGipVQnK95GOtCYOYlxBwM6a8WmZMsXbxbgAaciephC8 XxKkqz8eRX18R/I24UrRTX4nkDEsxXGJ1gI9Vu3NuzShuVz5S4OIJXFHjIHHgSyv4/sN tHFKkH5QEg/R70CTGjgtpcv4xqRRFbhQunxxB7pSzTpjHMPbmooGUyIrhpON5lQIDt0J 0Zf8BNtx84R9iezoi+5kF2PseX00N7ylKsiagCa7N4v5zHHfnfHGs4w+niFyVspEn39e hsLKRhT+/UoWC9LLMccnOnM2l9hrszsWptILmcPCA+hPDrQ/zzLMwpqAfsbrTWfo9Dkt tuXQ== X-Gm-Message-State: AOJu0YyeThRsScwXkb/00vIQEcDuqPVIfy65NnjXHvI5gtD6XawftJ3W +9MLISpjpxmbxxPNnUypDo4hUWX70njwduskiRcu+YzJD4RjV70GalDkKA== X-Google-Smtp-Source: AGHT+IEajg/GiU1czbgDi5NrMNZ87F029Px9u2Tr2sBvQmuxyt1Smk1OMsqF/xN3L+KTnHiDocao0w== X-Received: by 2002:a05:6512:114c:b0:52c:e0bc:ca3a with SMTP id 2adb3069b0e04-52eb99d76a5mr5521337e87.64.1720704997256; Thu, 11 Jul 2024 06:36:37 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a1f22acsm288128075e9.24.2024.07.11.06.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jul 2024 06:36:36 -0700 (PDT) In-Reply-To: <87h6cwm86n.fsf@orpheu.olymp> (Luis Henriques's message of "Thu, 11 Jul 2024 13:20:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288736 Archived-At: >>>>> On Thu, 11 Jul 2024 13:20:32 +0100, Luis Henriques said: Luis> Hi! Luis> [Resending as I don't see message in the list after a few hours.] I see both those messages. There is moderation for unsubscribed users, so sometimes there is lag. Luis> I'd like to have git-format-patch diffs to be properly identified= when I'm Luis> using Gnus to read mailing-lists. It mostly works fine, *if* the Luis> (inlined) patches include a signature at the end ('--'). If the = signature Luis> is missing then the patch isn't identified as such. Luis> Since all the other diff formats in mm-uu-type-alist don't have t= he Luis> 'end-point' I thought it would be fine to also remove it from the Luis> 'git-format-patch'. git-format-patch only produces patches like that if you pass it '--no-signature', I think. Luis> The issue I'm trying to fix can be easily seen in Gnus by compari= ng two Luis> emails with the following message-ids from the emacs-devel@gnu.org Luis> mailing-list: Luis> 87v81dmhxi.fsf@orpheu.olymp That one actually looks like just 'git diff' rather than 'git format-patch' I=CA=BCm trying to work out the benefit here compared to the status quo vs the risk of breaking something. If Gnus doesn=CA=BCt identify such messages as containing patches, you don=CA=BCt get the in-article buttons, but you can still pipe the message to 'git apply'. Also, how does this work for messages containing multiple patches? Is detection of just the start of each patch enough? Maybe adding a new detection method would be better? Robert --=20