From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Thu, 05 Sep 2024 10:26:52 +0000 Message-ID: <877cbqjt03.fsf@posteo.net> References: <87le083m1s.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15027"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73004@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 12:40:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sm9uY-0003jn-HQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 12:40:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sm9uC-0004YK-9t; Thu, 05 Sep 2024 06:40:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sm9uA-0004Xv-2I for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 06:39:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sm9u9-0001sx-OY for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 06:39:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=I4Lf89XLIvj4nY6xAsDXGHfkO346KEoyKnT4Yt6YhXc=; b=Qhkw6EWIS/gB4aIjrvPFndB124OgtS571eHLq9BzJid99ZtcrpSfxaOfEBoEuv6IqzIaXLyu7yV+OeCJCfI5ALdQ3SH+maNzfCn6gbljQspqxl3qg/eKhkEeFEKFhG3IT3DY/F6oqEthQ77AqODxS0CfO2xwn3ZbYyo55gGzqZKo7Rxl3mwzlGGa7GZ4DlfBWP7SjOpAIrzr57qSpMPBr0Du8odAh2cz8JdK32WYV8D8WCTNs18cM684GG1R3Xr/RX23qmw581GE5i+azNxaq9FNTnoMn9q5g5KwUjRiusHJyX0sGopgKNi/GJ40Hd0FF/8e8SKlJBSV/7e5pDHO8w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sm9vC-00050t-BO for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 06:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73004-submit@debbugs.gnu.org id=B73004.172553282219135 (code B ref 73004); Thu, 05 Sep 2024 10:41:02 +0000 Original-Received: (at 73004) by debbugs.gnu.org; 5 Sep 2024 10:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:36258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm9uW-0004yW-D6 for submit@debbugs.gnu.org; Thu, 05 Sep 2024 06:40:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:36053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sm9ie-00044Y-4W for 73004@debbugs.gnu.org; Thu, 05 Sep 2024 06:28:06 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7A5B2240103 for <73004@debbugs.gnu.org>; Thu, 5 Sep 2024 12:26:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1725532013; bh=Td0mmSPn2UzIvlWgBkmEfj0nS2buoaD8uDkSOBBnhqg=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=WojthrEonHduNoy/8UnmO2IAMEuhZekh8hSeJTgPAFORKli2KtEWV2XtRcuuC5PVo Q78aKDx0YVm0IhcknntLUSzTo7CT2cV8dzu3Mm3Qkcg04/q6y6cWmcVbdj1ldaic80 2QEYJ5rd31Gw+YwtbjyMGXb2wPFQfb/iau3V7nVHFiIVAGNwCLTBiTaCQWizQrTbvS tdBdSmeRBNp1fPZVM6W3lVDqpsqpy9f5szPASz6zD6ACdEkMRydDAHLLt20Xl8SJ9u 2OlohP6ysMpMJgjA9liIvHIx563Q7xtCKvZ/I5RUc0l6mMaRRC0RHbRowhg5hplJ0B YiLaYfOrMcAZg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WzwWw6nwrz9rxD; Thu, 5 Sep 2024 12:26:52 +0200 (CEST) In-Reply-To: <87le083m1s.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 03 Sep 2024 15:26:55 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291249 Archived-At: Manuel Giraud writes: > Tags: patch > > Hi, > > Here is a patch to make `dired-do-open' work on some non GNU/Linux > systems. I have tested it on OpenBSD with "xdg-open" installed. > > Thanks, > > In GNU Emacs 31.0.50 (build 19, x86_64-unknown-openbsd7.6) of 2024-09-02 > built on computer > Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 > System Description: OpenBSD computer 7.6 GENERIC.MP#294 amd64 > > Configured using: > 'configure CC=egcc CPPFLAGS=-I/usr/local/include > LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs > --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo > --without-compress-install' > >>>From ab26a89395b5745c8e3d87a8907344ba774a5ca1 Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Tue, 3 Sep 2024 15:13:51 +0200 > Subject: [PATCH] Make `dired-do-open' work on non GNU/Linux systems > > * lisp/dired-aux.el (dired-do-open): Permit this function to > work on some non GNU/Linux systems. > --- > lisp/dired-aux.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index cd948bd7dd9..97b1e28a4ff 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -1472,7 +1472,7 @@ dired-do-open > (when command > (dolist (file files) > (cond > - ((memq system-type '(gnu/linux)) > + ((memq system-type '(gnu/linux berkeley-unix)) Are these the only systems with xdg-open? And is xdg-open reliably available on BSD systems, so that we don't generate an opaque error message if that is not the case? > (call-process command nil 0 nil file)) > ((memq system-type '(ms-dos)) > (shell-command (concat command " " (shell-quote-argument file)))) > -- > 2.46.0 -- Philip Kaludercic on siskin