From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Mankoff Newsgroups: gmane.emacs.bugs Subject: bug#73218: [PATCH] Fix Fortran indent below do_not_a_loop=42 Date: Fri, 13 Sep 2024 08:44:45 -0700 Message-ID: <877cbfeexe.fsf@kenmankoff.com> References: <87o74semoz.fsf@kenmankoff.com> <86y13wjcyi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34843"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73218@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 13 17:46:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sp8V4-0008uW-5L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Sep 2024 17:46:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp8Ug-0001Zh-4N; Fri, 13 Sep 2024 11:45:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp8Ud-0001PW-Iy for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2024 11:45:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sp8Ub-0002zn-7e for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2024 11:45:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=DI/n85lXk01/dwJwF38n8XJHaFcCSXwgpdq3E/+xe5U=; b=p9Zkgtv8yzFyirgA/nk6zE8uwASeanHQRInbKHpWflFgaXEqX15jmh7pDxfIOILSp0Z4SF9v4O48umBHnldwIf3/7wMzyCoOLyUcIz/SgKmWlklrVmM4MClsZWuMtc+3fMTiXzuBfAXxW6BS1K0kf2iBcYrIKXsnqjVctv5vbENVdAHPfzCeZDCNR7Vdwtn3LbDFmRvbjjrSxHhMVifTOvmNiA75aM0OTkGTkzm49v34mWgkgKIxWi1ILMIiUJ7QNraFpEJO5gyNXbri4gODDB5WxkWijb3dBcUJrAAClbHAaUl8ZEy0e7/LakE4ZkxwUb9gHzG13eGMa8DHSW5yAA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sp8Uk-00075D-FB for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2024 11:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Mankoff Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2024 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73218-submit@debbugs.gnu.org id=B73218.172624230426608 (code B ref 73218); Fri, 13 Sep 2024 15:46:02 +0000 Original-Received: (at 73218) by debbugs.gnu.org; 13 Sep 2024 15:45:04 +0000 Original-Received: from localhost ([127.0.0.1]:44063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8To-0006v6-1C for submit@debbugs.gnu.org; Fri, 13 Sep 2024 11:45:04 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:47426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8Tm-0006uJ-6f for 73218@debbugs.gnu.org; Fri, 13 Sep 2024 11:45:02 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7c3e1081804so1359038a12.3 for <73218@debbugs.gnu.org>; Fri, 13 Sep 2024 08:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726242287; x=1726847087; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DI/n85lXk01/dwJwF38n8XJHaFcCSXwgpdq3E/+xe5U=; b=V+Hu3jXsERhsV1Q0+ArxJUnKeDCS8wCNN0gSFnPDL5b24OVGlH1oMSnCnVGluU0r9C 2rLK+WCTz6eFkGkqFbEZHStMyFsXs9QUfTu0lnSnTcvyRCEimUJaiFOAHYmqPMmcj/D6 5HIXIJckpx76yJxY4sfLKXtz0CrKEelbRL1eX9GVwvOrxDJCUYLqt77RqPkKxaK+lTIY QfFcXN7tU/G6ZL2nuVAVIOZucKrD8J6ubQvoI3ou6M39vync/7FIbpn56CAFCeD8Iarh LDySxM0yxrZ3YTWFDPc/RrPW1AghOCvLq6IctR2m1QFX6o9KQr7SkG5AWxckLGOIyeqF +NvQ== X-Gm-Message-State: AOJu0Yw1tQFQjHGt9DaEw/DD2JTB0fecrEhskG6w/JwRLJ6tP/Fk5FGf XvsPAC825728xH5qX5/aDPla/AkdVQrNMHYty0u632cNYhvTl8Z6g6p1ZQ== X-Google-Smtp-Source: AGHT+IGLLXB+rAA3eiCbcdH020xxUz0KsCDwKDN3KkYD4Eak3F62Ze7UtG7Sp4DdkjuQp+XDQNPUBQ== X-Received: by 2002:a05:6a21:60c4:b0:1cf:2cae:eb0a with SMTP id adf61e73a8af0-1cf7635901fmr9741163637.31.1726242286934; Fri, 13 Sep 2024 08:44:46 -0700 (PDT) Original-Received: from t480 (97-126-4-246.tukw.qwest.net. [97.126.4.246]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dbb9d93a3fsm1899847a91.50.2024.09.13.08.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 08:44:46 -0700 (PDT) In-Reply-To: <86y13wjcyi.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Sep 2024 09:16:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291661 Archived-At: Hi Eli, On 2024-09-12 at 23:16 -07, Eli Zaretskii wrote... >> --- a/lisp/progmodes/fortran.el >> +++ b/lisp/progmodes/fortran.el >> @@ -1631,7 +1631,7 @@ fortran-calculate-indent >> (setq icol (+ icol fortran-if-indent))) >> ((looking-at "where[ \t]*(.*)[ \t]*\n") >> (setq icol (+ icol fortran-if-indent))) >> - ((looking-at "do\\b") >> + ((looking-at "do[\\ |0-9]+.*=[\\ a-z0-9_]*,[\\ a-z0-9_]*") > > What do you intend with the likes of "[\\ |0-9]+" ? Is this a > character alternative, or is that an alternative of matches? If the > former, there's no need to escape a backslash, but then why is '|' > there? I agree the '|' is not needed. I'm not sure what 'character alternative' or 'alternative of matches' means. I meant the '|' as an "OR" (is that an alterntative?), but realize now it is not needed. I now suggest "do[\\ 0-9]+.*=[\\ a-z0-9_]*,[\\ a-z0-9_]*" The pattern attempts to match "do", then either (space, numbers, or nothing), then equal sign, then something that looks like two numbers or valid variable names separated by a comma. I used these as tests: do42I=1,42 ! match do_foo = bar() do i = 1,42 ! match do i = 1,n ! match do i_var = a_var,b_var ! match do i_var5 = a_var,b_var ! match do42i_var = a_var,b_var ! match DO42 = [1,2] DO6I=5 7 DO6I=5,7 ! match do_not_loop = [a,b] donot_loop = (/4,5/) donotloop = 42 do_notloop = 42 Should I submit an updated patch? Or is the patch applier able to make this small change? Thanks, -k.