From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Thu, 03 Oct 2024 08:50:37 +0800 Message-ID: <877caq3t7m.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> <878qv9scps.fsf@melete.silentflame.com> <12b28146-5cbc-48cd-b0e2-0c528d4b9b1c@yandex.ru> <87ikudqocz.fsf@melete.silentflame.com> <86jzet2po6.fsf@gnu.org> <875xqcr6ho.fsf@melete.silentflame.com> <868qv73joh.fsf@gnu.org> <877carfg6l.fsf@melete.silentflame.com> <86jzer0yd9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, juri@linkov.net, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 03 02:51:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swA3l-0006Fr-5Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Oct 2024 02:51:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swA3c-0008T6-Ru; Wed, 02 Oct 2024 20:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swA3a-0008St-E0 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 20:51:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swA3a-0003Cj-56 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 20:51:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=qdjLL3zvyadv5wG3NJPd1JiFN9n4ZhYl11iD2l9AiXs=; b=AC1N60A0lX3BnZkAqnwcVdrW+OZU20Jy0PmBpyX7+VHXdyIciw4s+wJeFimUESGjQJ9Ao+9cD+T1VHGZBiNPik7V+LuhLHPM10C6lN+toevrcjf6XSMsnwy72SQFZt0MxITFufWZruO0otmSQBeqauCqFz0DTAC+IZzce4M3z37auEDWt5Iiq99fyhUSRAjLAYDkQQcBZKnddm4J2RcFfLP+zbiNeUfqUX+N4fMothlDigKAU5kjRkDSeRjLXanyQJH2i5faGdabRv54dF+q1zsteX4NAEjTS5WA0ci0rXY145YcVHqYLhoSP6znMl9pDfAsX6r6Rc6LFhxYGgfRuA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swA3a-0004mc-7I for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 20:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2024 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.172791665018366 (code B ref 73387); Thu, 03 Oct 2024 00:51:02 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 3 Oct 2024 00:50:50 +0000 Original-Received: from localhost ([127.0.0.1]:59525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swA3N-0004m9-J2 for submit@debbugs.gnu.org; Wed, 02 Oct 2024 20:50:49 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swA3M-0004lu-20 for 73387@debbugs.gnu.org; Wed, 02 Oct 2024 20:50:49 -0400 DKIM-Signature: a=rsa-sha256; b=Wpn8ues6PxK0G59oOClU309rg+VRZctNkl0+oFMZqBh5AMtAKIY/LK7KgjaiVHFBEGUCvKJAaCAJssqUXdvkXb1fl7Xz1bb0rrxZqFE8FdAFsDRdM+KnBpw7QeYvDKGQu7pFWttJptAMfICqWHLwJOvbmDydyuX/6hZ2bfg0hVENbpAognXO33MDvOQ33MtkAr4E2tIwbZnp8xKeludMD2pKeO5yFFPiV4gd492oJsIXFQoOpnXsLphZDu2P2jOv768Fzepn1gsjNJFZ4mXlsP9YebEalb7kxZuia819RCNUANViphWIZPHUQyehAuk1aAdQMq30tQQ9n4v7Ur3O8g==; s=purelymail2; d=spwhitton.name; v=1; bh=JjpGKGbpdnniAKg4K6s3B6zD+wuJIPnkN2CnlrmqD/M=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=DgXu0T/G8648Y5hDI1iJIB/PYyPIlyTTYJAG7q0mUMQI4nlF8JSm3C3ynlWnZpShFgJEoPttUdfOkveQV4kBWuE0dBpUcxl+xsm9tqqLnxIpoHhTrfVeovSZgO749YEDTBWkwJN5m/vxyUFubm8AgCEDvBBofulCLehLgWsiDlP13AJWrwInN3d093/+ylV3B8XgfigAvtJtnM1Abwhmdolnxx40P5lEIKXiq4Un5//3srFBiF9HmKm+i0FqVH3y+DWp87d4exMlPUhlCBYRXv/90CLzNbEHHDbL8DQbvCAU1O4Fc4omW3B4IG1pnTQ9EnQXPIACG0GMmnzkkN3U7Q==; s=purelymail2; d=purelymail.com; v=1; bh=JjpGKGbpdnniAKg4K6s3B6zD+wuJIPnkN2CnlrmqD/M=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1303589503; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Oct 2024 00:50:41 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E7A967E4426; Thu, 3 Oct 2024 08:50:37 +0800 (CST) In-Reply-To: <86jzer0yd9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Oct 2024 10:15:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292875 Archived-At: Hello, On Wed 02 Oct 2024 at 10:15am +03, Eli Zaretskii wrote: > This doesn't really address the issue, IMO. > > The main problem I have here is with the "all" part of the first > sentence, which is then contradicted by the second. Also, in other > places, you describe the behavior when region is active, but not when > it isn't. > > Here's what I would suggest to say in the manual: > > @item C-c @key{RET} k > Delete diff hunks other than the current one. If the region is > active, this command deletes the hunks overlapped by the region; > otherwise it deletes all the hunks other than the current hunk. Do > @emph{not} invoke this command in a narrowed buffer, as that could > produce unexpected results. Okay, I've rewritten based on this, though I haven't included the imprecation, because invoking it in a narrowed buffer could never produce unexpected results -- the function will always do nothing. > And this is for the command's doc string: > > (defun diff-delete-other-hunks (&optional beg end) > "Delete diff hunks other than the current one. > Interactively, if the region is active, delete all the hunks which > the region overlaps; otherwise delete all the hunks except the > current one. > When calling from Lisp, pass BEG and END as the bounds of region in > which to delete diff hunks; BEG and END omitted or nil means to > delete all the hunks but the one which contains point. Done, thanks. -- Sean Whitton