A lot of warnings building Emacs master

A lot of warnings building Emacs master

[Angelo Graziosi]

Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I 
get about 10615 (grep -c ...) "Warning" like this:

org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use 
`if-let*' instead.


Ciao,
   Angelo.

Re: A lot of warnings building Emacs master

[Andy Moreton]

On Sun 27 Oct 2024, Angelo Graziosi wrote:

> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> about 10615 (grep -c ...) "Warning" like this:
>
> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> instead.

I see this also. The change to mark this as obsolete is premature.

Marking as obsolete to avoid new uses being introduced should only be
done after reworking the existing  codebase  to remove the majority of
existing calls.

The current situation of leaving hundreds of lines of warning noise in
the build output makes it harder to see other problems, and is not good.

    AndyM

Re: A lot of warnings building Emacs master

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sun, 27 Oct 2024 01:37:12 +0100
> 
> On Sun 27 Oct 2024, Angelo Graziosi wrote:
> 
> > Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> > about 10615 (grep -c ...) "Warning" like this:
> >
> > org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> > instead.
> 
> I see this also. The change to mark this as obsolete is premature.
> 
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
> 
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.

Agreed.

Sean, how do we plan to handle this? and how soon?

Re: A lot of warnings building Emacs master

[Sean Whitton]

Hello,

On Sun 27 Oct 2024 at 08:22am +02, Eli Zaretskii wrote:

> Sean, how do we plan to handle this? and how soon?

I fixed all the warnings when I marked it as obsolete, except for
externally maintained packages.

Org I fixed today, after talking to upstream.

Michael reports he has the TRAMP warnings fixed in tramp.git, and
expects to import it to emacs.git within ~5 days.

Then only transient.el remains.  I sent a patch upstream.  But I could
also just commit my patch here to get rid of the warnings?

-- 
Sean Whitton

Re: A lot of warnings building Emacs master

[Michael Albinus]

Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello,

Hi,

> Michael reports he has the TRAMP warnings fixed in tramp.git, and
> expects to import it to emacs.git within ~5 days.

If it really matters, I could apply a Tramp patch soon. However, I
prefer to run comprehensive regression tests first in Tramp's git repo,
this will take some few days, as Sean has said.

Best regards, Michael.

Re: A lot of warnings building Emacs master

[Stefan Kangas]

Sean Whitton <spwhitton@spwhitton.name> writes:

> Then only transient.el remains.  I sent a patch upstream.  But I could
> also just commit my patch here to get rid of the warnings?

Please apply that patch, yes.

Re: A lot of warnings building Emacs master

[Sean Whitton]

Hello,

On Sun 27 Oct 2024 at 04:41am -05, Stefan Kangas wrote:

> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> Then only transient.el remains.  I sent a patch upstream.  But I could
>> also just commit my patch here to get rid of the warnings?
>
> Please apply that patch, yes.

Okay, installed that on master, and confirmed with a bootstrap build
that only TRAMP remains.

-- 
Sean Whitton

Re: A lot of warnings building Emacs master

[Po Lu]

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Sun 27 Oct 2024, Angelo Graziosi wrote:
>
>> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
>> about 10615 (grep -c ...) "Warning" like this:
>>
>> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
>> instead.
>
> I see this also. The change to mark this as obsolete is premature.
>
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
>
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.
>
>     AndyM

+1.  I don't understand why it was necessary to obsolete if-let anyway.

Re: A lot of warnings building Emacs master

[Andrea Corallo]

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Sun 27 Oct 2024, Angelo Graziosi wrote:
>
>> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
>> about 10615 (grep -c ...) "Warning" like this:
>>
>> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
>> instead.
>
> I see this also. The change to mark this as obsolete is premature.
>
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
>
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.
>
>     AndyM

Agree, we should strive for pushing only warning free commits.

I see Sean is putting effort in fixing this, but I often even see
commits introducing new warnings in the hope that other contributors fix
them in the future, this is not okay.

That said I don't understand as well why was necessary to obsolete
if-let in favor of if-let*, but bug#73853 has some reference to previous
discussions (which I had no time to go through) and the change was
agreed by a maintainer.

  Andrea

Re: A lot of warnings building Emacs master

[Sean Whitton]

Hello,

On Sun 27 Oct 2024 at 01:12am +02, Angelo Graziosi wrote:

> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> about 10615 (grep -c ...) "Warning" like this:
>
> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> instead.

Known issue, sorry for the noise.

-- 
Sean Whitton