all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: 74915@debbugs.gnu.org
Cc: "Björn Bidar" <bjorn.bidar@thaodan.de>
Subject: bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
Date: Mon, 16 Dec 2024 19:15:03 +0100	[thread overview]
Message-ID: <877c7z5wbc.fsf@gmail.com> (raw)
In-Reply-To: <48132.687299379$1734370474@news.gmane.org> ("Björn Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Mon, 16 Dec 2024 19:33:31 +0200")

>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
    Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
    Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
    Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
    Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables

    Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
    Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
    Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
    Björn> (gnus-treat-display-face, gnus-treat-display-face)
    Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
    Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
    Björn> (gnus-treat-body-boundary): Fix custom types to
    Björn> include all possible choices mentioned in the docstrings
    Björn> and manual.

The commit message only needs to mention the type you actually
changed, in this case `gnus-article-treat-head-custom'

    Björn> ---
    Björn>  lisp/gnus/gnus-art.el | 5 ++++-
    Björn>  1 file changed, 4 insertions(+), 1 deletion(-)

    Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
    Björn> index 8243e4e632b..13dfb737243 100644
    Björn> --- a/lisp/gnus/gnus-art.el
    Björn> +++ b/lisp/gnus/gnus-art.el
    Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
 
    Björn>  (defvar gnus-article-treat-head-custom
    Björn>    '(choice (const :tag "Off" nil)
    Björn> -	   (const :tag "Header" head)))
    Björn> +	   (const :tag "Header" head)
    Björn> +           (const :tag "First" first)
    Björn> +           (const :tag "Last" last)
    Björn> +           (boolean :tag "All body parts" t)))

`t' is a const, not a boolean, the same as `nil', in the context of
defcustom. Plus a lot of the docstrings look cut&paste, so Iʼm not
entirely sure that itʼs the existing type that is wrong rather than
the docstring.

Robert
-- 





  reply	other threads:[~2024-12-16 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 17:33 bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-16 18:15 ` Robert Pluim [this message]
2024-12-16 22:30   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-17  7:28     ` Robert Pluim
2024-12-17 10:22       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 11:16         ` Robert Pluim
2024-12-17 13:02           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 13:08             ` Robert Pluim
2024-12-17 13:30               ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c7z5wbc.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=74915@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.