From: Hong Xu <hong@topbug.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefankangas@gmail.com>, 74983@debbugs.gnu.org
Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro
Date: Fri, 20 Dec 2024 13:50:15 -0800 [thread overview]
Message-ID: <877c7u58iw.fsf@topbug.net> (raw)
In-Reply-To: <86pllmkfcm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2024 09:01:29 +0200")
On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Hong Xu <hong@topbug.net>
>> Date: Thu, 19 Dec 2024 14:36:29 -0800
>>
>> * Since `define-key' is considered legacy and we encourage `keymap-set'
>> now.
>
> Thanks. But the second chunk is not really right, since we have many
> more define-key there than keymap-set.
>
> So my suggestion is not to _replace_ define-key with keymap-set, but
> instead describe _both_, explaining that as of Emacs 29 we are
> migrating towards keymap-set, which is preferred.
Thanks, I agree. I've made a followup patch. For some reason the
followup patch didn't attach to the Message ID of this thread and a new
bug 74999 was created.
--
Hong
next prev parent reply other threads:[~2024-12-20 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 22:36 bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Hong Xu
2024-12-20 7:01 ` Eli Zaretskii
2024-12-20 9:35 ` Stefan Kangas
2024-12-20 21:42 ` bug#74999: [PATCH v2] Recommend " Hong Xu
2024-12-21 7:19 ` Eli Zaretskii
2024-12-21 8:03 ` bug#74999: [PATCH v3] " Hong Xu
2024-12-21 8:06 ` bug#74999: [PATCH v2] " Hong Xu
2024-12-20 15:43 ` bug#74983: [PATCH] Use " Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-20 21:50 ` Hong Xu [this message]
2024-12-21 7:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c7u58iw.fsf@topbug.net \
--to=hong@topbug.net \
--cc=74983@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.