From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75199: 30.0.93; Emacs crashes when completing with corfu Date: Mon, 30 Dec 2024 19:43:34 +0100 Message-ID: <877c7hc8q1.fsf@daniel-mendler.de> References: <87cyh9qq64.fsf@fuzy.me> <86ttalnsj4.fsf@gnu.org> <87r05pmctv.fsf@fuzy.me> <86ldvxnqgv.fsf@gnu.org> <8ac665654425902f3deb81481ac0242c@fuzy.me> <87a5cdcape.fsf@daniel-mendler.de> <86bjwtnhyh.fsf@gnu.org> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4672"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: i@fuzy.me, luangruo@yahoo.com, 75199@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 30 19:44:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSKkg-00014g-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Dec 2024 19:44:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSKkU-0000Ue-Kn; Mon, 30 Dec 2024 13:44:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSKkG-0000UI-UF for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:44:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSKkF-000622-JT for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=U3dVzGLasGp8sPfkfRcY2xgrjiVaQlrELOn7j13klBI=; b=VGZBOXtMsJo/GQV2LbPI+t3rbbRJprjbHqTxtdw548xE/chuugBFx7KKHbb1LO17ZfcWFxbheJw1KG7pXQL7sCIlJ6jVJumSSdm0wCrMgGWLKnMdA+jcR+80Jp6klHzl7EPtCO9nNdSgg9rMX7KMojgmXQ9zveJJuXnQGncuRUYqklZEilw8jpxIGTxOoNw1Vgct2IdtxMdQdzhn2jY7yqSlHvkhZBFkMySy050OCypAf0P7L3aPC/2yUPzIQTr+wHhpUnndI8Ab6jUeOdbKaDQg0JnbAzaKBWipriRNxCbElM+jF7pmrKyVwPkxBANA1KDUYVtq2WEfM/02Yeg6AA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSKkE-0000dG-Hw for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2024 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75199 X-GNU-PR-Package: emacs Original-Received: via spool by 75199-submit@debbugs.gnu.org id=B75199.17355842272393 (code B ref 75199); Mon, 30 Dec 2024 18:44:02 +0000 Original-Received: (at 75199) by debbugs.gnu.org; 30 Dec 2024 18:43:47 +0000 Original-Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSKjz-0000cW-DT for submit@debbugs.gnu.org; Mon, 30 Dec 2024 13:43:47 -0500 Original-Received: from server.qxqx.de ([49.12.34.165]:42175 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSKju-0000c2-Cd for 75199@debbugs.gnu.org; Mon, 30 Dec 2024 13:43:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=U3dVzGLasGp8sPfkfRcY2xgrjiVaQlrELOn7j13klBI=; b=wAZJvQ+LaryqKm3o8MH9TcUvp4 G7jYo8KNeQuNrxzZIkE4vrpkqDKlUeG0h8nZX16fHQ+CemT/CdullnE0DvKwZJ+B0B9KGlrMIxZDv XUQgjU0Z6dqntlGMGJP9vCHGRmp9yqtCFEyfS6Qs5gWOb54YAeOdBinbg52hCvPST8Mk=; In-Reply-To: <86bjwtnhyh.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Dec 2024 20:28:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298017 Archived-At: Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: Eli Zaretskii , luangruo@yahoo.com, 75199@debbugs.gnu.org >> Date: Mon, 30 Dec 2024 19:00:45 +0100 >> >> Zhengyi Fu writes: >> >> > On 2024-12-30 23:24, Eli Zaretskii wrote: >> > >> >> Earlier you wrote: >> >> >> >>> The error is probably caused by the width value of 0 passed to >> >>> XCreatePixmapFromBitmapData(). >> >>> It seems gui_intersect_rectangles() returns true even if the resulted >> >>> rectangle is empty. Is that correct behavior? >> >> Can you tell how this happens? Is corfu doing something special with >> >> the fringes? >> > >> > I noticed the following calls in corfu--popup-show before the error: >> > >> > * define-fringe-bitmap(corfu--bar [-241] 1 8 (top periodic)) >> > * define-fringe-bitmap(corfu--nil []) >> >> I've adjusted the second call to the following, also for compatibility >> with older Emacs versions. >> >> (define-fringe-bitmap 'corfu--nil [0] 1 1) > > Doesn't > > (define-fringe-bitmap 'corfu--nil [0]) > > work as well? If it doesn't, I guess the doc string is inaccurate? Yes. If I understand [info:elisp#Customizing Bitmaps] correctly, in this case the HEIGHT would be 1, but the WIDTH would be 8. This is slightly different from the above, but it should work just as well given that the bitmap is all zero. The corfu--nil bitmap is just a placeholder for the empty fringe. Daniel