From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: suspicious GCPROs Date: Mon, 20 Mar 2006 01:38:17 -0500 Message-ID: <8764m9k4dx.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1142875259 2354 80.91.229.2 (20 Mar 2006 17:20:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Mar 2006 17:20:59 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 20 18:20:57 2006 Return-path: Envelope-to: ged-emacs-devel@gmane.org Original-Received: from mail-relay.eunet.no ([193.71.71.242]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FLO3d-0004yv-Ba for ged-emacs-devel@gmane.org; Mon, 20 Mar 2006 18:20:42 +0100 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by mail-relay.eunet.no (8.13.1/8.13.1/GN) with ESMTP id k2KHKaJS027542 for ; Mon, 20 Mar 2006 18:20:37 +0100 (CET) (envelope-from emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org) Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLO3O-0003rT-4f for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2006 12:20:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FLE21-0006VO-PA for emacs-devel@gnu.org; Mon, 20 Mar 2006 01:38:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FLE20-0006Ur-Ur for emacs-devel@gnu.org; Mon, 20 Mar 2006 01:38:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLE20-0006Ue-S6 for emacs-devel@gnu.org; Mon, 20 Mar 2006 01:38:20 -0500 Original-Received: from [209.226.175.97] (helo=tomts40-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FLE7V-0007ti-KE for emacs-devel@gnu.org; Mon, 20 Mar 2006 01:44:01 -0500 Original-Received: from alfajor ([70.55.140.81]) by tomts40-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060320063819.ITKC1823.tomts40-srv.bellnexxia.net@alfajor>; Mon, 20 Mar 2006 01:38:19 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id D234CD73BE; Mon, 20 Mar 2006 01:38:17 -0500 (EST) Original-To: Kenichi Handa In-Reply-To: (Kenichi Handa's message of "Thu, 16 Mar 2006 15:33:40 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51893 Archived-At: > I've just checked all occurrences of GCPRO and found a few > suspicious places. Attached is the patch I propose. > The first two patches (fileio.c and keymap.c) are clearly > necessary because GCPROed variables are not yet initialized > when GC occurs. > The last two patchs (xfns.c and xterm.c) are also necessary > for the same reason, but it seems to me that there's no need > of GCPRO in the first place. What do yo think? Looks good to me, thanks, Stefan