From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Fix previous-button to work with connected buttons Date: Sun, 01 Apr 2007 13:15:09 -0400 Message-ID: <87648gkode.fsf@stupidchicken.com> References: <87wt1o8xl6.fsf@x3y2z1.net> <87648gzv45.fsf@x3y2z1.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1175448048 28146 80.91.229.12 (1 Apr 2007 17:20:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 1 Apr 2007 17:20:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Diane Murray Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 01 19:20:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HY3jN-0003de-T5 for ged-emacs-devel@m.gmane.org; Sun, 01 Apr 2007 19:20:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HY3mJ-0001lK-V7 for ged-emacs-devel@m.gmane.org; Sun, 01 Apr 2007 13:23:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HY3mH-0001l3-AM for emacs-devel@gnu.org; Sun, 01 Apr 2007 13:23:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HY3mG-0001ks-Ue for emacs-devel@gnu.org; Sun, 01 Apr 2007 13:23:40 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HY3jK-0008Oc-0Z for emacs-devel@gnu.org; Sun, 01 Apr 2007 13:20:38 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l31HKa7f029226; Sun, 1 Apr 2007 13:20:37 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id l31HFACY006434; Sun, 1 Apr 2007 13:15:13 -0400 (EDT) Original-Received: from localhost ([18.19.7.211]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l31HF9Ok017240; Sun, 1 Apr 2007 13:15:10 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HY3e1-00028g-00; Sun, 01 Apr 2007 13:15:09 -0400 In-Reply-To: <87648gzv45.fsf@x3y2z1.net> (Diane Murray's message of "Sun\, 01 Apr 2007 04\:28\:10 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68890 Archived-At: Diane Murray writes: > The latest changes to button.el have added a new distinct button > property which makes it possible to correctly determine that > neighboring buttons are different and to navigate through them even > when they are right next to each other. There is still one little > bug, however, which I corrected in a patch I sent in my original email > - the problem it fixes is that any previous adjacent button is > skipped. Please see the patch below with a new diff from the latest > revision. Thanks for the report. The patch you suggested didn't give good results. I've checked in a different patch to handle this case.