From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: wdired-change-to-wdired-mode needs a key binding in dired-mode Date: Sat, 28 Jul 2007 12:14:42 +0300 Organization: JURTA Message-ID: <876444yjp5.fsf@jurta.org> References: <200707240216.l6O2GiND022670@oogie-boogie.ics.uci.edu> <7dbe73ed0707232231w790d93f4o8b095a19bdc1757f@mail.gmail.com> <87bqe2493t.fsf@ambire.localdomain> <87y7h15zrk.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185615027 29043 80.91.229.12 (28 Jul 2007 09:30:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 Jul 2007 09:30:27 +0000 (UTC) Cc: dann@ics.uci.edu, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 28 11:30:21 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IEicr-0002QV-Bn for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2007 11:30:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IEicq-0003Lc-Ri for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2007 05:30:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IEiac-0002y2-5P for emacs-devel@gnu.org; Sat, 28 Jul 2007 05:27:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IEiaa-0002xU-MW for emacs-devel@gnu.org; Sat, 28 Jul 2007 05:27:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IEiaZ-0002xD-Du for emacs-devel@gnu.org; Sat, 28 Jul 2007 05:27:55 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IEiaY-0004rl-Ov for emacs-devel@gnu.org; Sat, 28 Jul 2007 05:27:55 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1IEiaV-0003BL-Bc; Sat, 28 Jul 2007 12:27:51 +0300 In-Reply-To: (Stefan Monnier's message of "Fri\, 27 Jul 2007 23\:53\:41 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Scanner-Signature: 068dd79c68aafbc760c35e97c5d420ed X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1293 [July 27 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75742 Archived-At: >> Since wdired doesn't work in modes that inherit from dired-mode, >> it would be useful to leave the original binding to toggle-read-only >> in them: > > Rather than "fix" each derived mode one by one, how 'bout doing > > (define-key dired-mode-map "\C-x\C-q" > '(menu-item nil wdired-change-to-wdired-mode > :filter (lambda (x) (if (eq major-mode 'dired-mode) x)))) > > Or maybe more simply create a new function dired-toggle-read-only which > either calls wdired-change-to-wdired-mode or toggle-read-only depending on > whether wdired makes sense or not (by testing (eq major-mode 'dired-mode) or > whatever else). I prefer a new function. That's what I already thought about after seeing that Dan mentioned vc-dired. -- Juri Linkov http://www.jurta.org/emacs/