From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: valgrind emacs Date: Sat, 22 Mar 2008 17:47:10 -0400 Message-ID: <8763veo2ht.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1206222627 15052 80.91.229.12 (22 Mar 2008 21:50:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Mar 2008 21:50:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Neal Becker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 22 22:50:57 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JdBc0-0005yy-Bz for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2008 22:50:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JdBbP-0004Tw-Oh for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2008 17:50:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JdBbL-0004Ro-Ah for emacs-devel@gnu.org; Sat, 22 Mar 2008 17:50:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JdBbJ-0004R8-V5 for emacs-devel@gnu.org; Sat, 22 Mar 2008 17:50:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JdBbJ-0004R5-PN for emacs-devel@gnu.org; Sat, 22 Mar 2008 17:50:05 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JdBbJ-0003qd-Ff for emacs-devel@gnu.org; Sat, 22 Mar 2008 17:50:05 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 3DF0E4E4B8; Sat, 22 Mar 2008 17:47:10 -0400 (EDT) In-Reply-To: (Neal Becker's message of "Sat\, 22 Mar 2008 13\:47\:56 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.92 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93210 Archived-At: Neal Becker writes: > Anyone try valgrind on emacs? I get some errors: > ==15930== Invalid free() / delete / delete[] > ==15930== at 0x4A05AF7: realloc (vg_replace_malloc.c:306) > ==15930== by 0x536A0D: xrealloc (alloc.c:788) > ==15930== by 0x4F9DBF: enlarge_buffer_text (buffer.c:5095) > ==15930== by 0x50458B: make_gap_larger (insdel.c:528) > ==15930== by 0x46FE5B: alloc_destination (coding.c:1124) > ==15930== by 0x4701B1: produce_chars (coding.c:6068) > ==15930== by 0x4750ED: decode_coding (coding.c:6403) > ==15930== by 0x476326: decode_coding_object (coding.c:7054) > ==15930== by 0x476AF8: code_convert_string (coding.c:8281) > ==15930== by 0x4DC268: main (emacs.c:555) > ==15930== Address 0x256FB60 is not stack'd, malloc'd or (recently) free'd I don't see how this code path could occur. This seems to be complaining that b->text->beg in enlarge_buffer_text (buffer.c:5095) is not a malloc'ed pointer. But this code path is only activated when BUFFERP (coding->dst_object) in alloc_destination (buffer.c:1142). Which means that we already have a valid buffer. I haven't used valgrind before, so I don't know how reliable it is. Does anyone know how easy it is to confuse it? (I haven't studied the rest of the errors closely, but they seem to be of the same variety.)