bug#868: [PATCH] Make url-basic-auth support non-ascii passwords

[Magnus Henoch <mange@freemail.hu>]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Package: emacs,url

Just making sure that this doesn't get lost.  Will get to it later...


[-- Attachment #2: Type: message/rfc822, Size: 4209 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 264 bytes --]

Hi,

url-basic-auth uses base64-encode-string but the password string can
contain non-ascii characters. In which case encode-coding-string
should be used. Attached patch fixes the issue.

Regards,
ismail

-- 
Programmer Excuse #26: I suspect it's a bus collision.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: url-basic-auth-utf8.patch --]
[-- Type: text/x-diff; name=url-basic-auth-utf8.patch, Size: 498 bytes --]

diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index ce730ce..d089b18 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -93,7 +93,7 @@ instead of the filename inheritance method."
 		       (cons file
 			     (setq retval
 				   (base64-encode-string
-				    (format "%s:%s" user pass)))))
+				    (format "%s:%s" user (encode-coding-string pass 'utf-8))))))
 		 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))