From: Yann Hodique <yann.hodique@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#3037: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 17:48:19 +0200 [thread overview]
Message-ID: <8763h39t8c.fsf@gmail.com> (raw)
When using `rcirc' with argument (prompt for connection parameters), the
global default values for :port, :nick and :channels are proposed
instead of the server-specific ones.
Reason is that current code tries to get properties 'port, 'nick
and 'channels, which is not correct.
Following patch fixes this issue.
Yann.
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..1f31284 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -375,16 +375,16 @@ If ARG is non-nil, instead prompt for connection parameters."
(server-plist (cdr (assoc-string server rcirc-server-alist)))
(port (read-string "IRC Port: "
(number-to-string
- (or (plist-get server-plist 'port)
+ (or (plist-get server-plist :port)
rcirc-default-port))))
(nick (read-string "IRC Nick: "
- (or (plist-get server-plist 'nick)
+ (or (plist-get server-plist :nick)
rcirc-default-nick)))
(channels (split-string
(read-string "IRC Channels: "
(mapconcat 'identity
(plist-get server-plist
- 'channels)
+ :channels)
" "))
"[, ]+" t)))
(rcirc-connect server port nick rcirc-default-user-name
--
"Once more the drama begins."
-The Emperor Paul Muad'dib on his ascension to the Lion Throne
next reply other threads:[~2009-04-17 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87eivqipxg.fsf@cyd.mit.edu>
2009-04-17 15:48 ` Yann Hodique [this message]
2009-04-18 3:50 ` bug#3037: marked as done (23.0.92; rcirc picks incorrect connection settings) Emacs bug Tracking System
2009-04-18 1:52 bug#3037: 23.0.92; rcirc picks incorrect connection settings Chong Yidong
2009-04-18 2:30 ` Ryan Yeske
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763h39t8c.fsf@gmail.com \
--to=yann.hodique@gmail.com \
--cc=3037@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.