From: Miles Bader <miles@gnu.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'Stefan Monnier' <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: face-remap.el patch to resize window
Date: Tue, 11 Aug 2009 02:37:39 +0900 [thread overview]
Message-ID: <8763cvbme4.fsf@catnip.gol.com> (raw)
In-Reply-To: <E44F700362064ED192B85CF2DED5FBF4@us.oracle.com> (Drew Adams's message of "Mon, 10 Aug 2009 10:15:26 -0700")
"Drew Adams" <drew.adams@oracle.com> writes:
>> How 'bout Miles's suggestion to use your code but without a separate
>> config var, using text-scale-mode-hook instead? That would sound like
>> a good idea to me.
>
> (No reason given.) Why?
Well the obvious reason is that it avoids hard-wiring behavior which we
believe to be to inflexible, and is a smaller change.
[The hook, after all, already exists; my patch mainly just records a bit
more information for it to use.]
> I mentioned some disadvantages to using a hook.
Hmm, the only real disadvantage I can see is that hooks aren't
well-supported by customize. [As for "buffer localness", hooks, after
all, can also be buffer-local, or can examine a buffer-local variable to
determine their behavior.]
> No one has mentioned any advantages.
See above: Smaller; more flexible.
Hooks (like other indirection mechanisms) are generally more flexible,
at some cost in user-friendliness and clarity. So if there's very
commonly desired behavior, sometimes it's good to hard-wire it instead
of telling people to use a hook or whatever (even if an appropriate hook
already exists). However as I've mentioned, it's not clear to me that
the described behavior in this case is generally useful/universal enough
to hard-wire.
-Miles
--
`...the Soviet Union was sliding in to an economic collapse so comprehensive
that in the end its factories produced not goods but bads: finished products
less valuable than the raw materials they were made from.' [The Economist]
next prev parent reply other threads:[~2009-08-10 17:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 1:04 face-remap.el patch to resize window Drew Adams
2009-08-10 3:00 ` Stefan Monnier
2009-08-10 3:27 ` Drew Adams
2009-08-10 5:04 ` Miles Bader
2009-08-10 17:00 ` Drew Adams
2009-08-10 3:34 ` Miles Bader
2009-08-10 15:01 ` Stefan Monnier
2009-08-10 16:31 ` Drew Adams
2009-08-10 16:52 ` Miles Bader
2009-08-10 16:59 ` Drew Adams
2009-08-10 17:16 ` Stefan Monnier
2009-08-10 17:00 ` Stefan Monnier
2009-08-10 17:15 ` Drew Adams
2009-08-10 17:37 ` Miles Bader [this message]
2009-08-10 21:41 ` Drew Adams
2009-08-10 18:03 ` Stefan Monnier
2009-08-10 21:50 ` Drew Adams
2009-08-11 3:45 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 22:10 Drew Adams
2009-06-22 20:40 Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763cvbme4.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.