From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5513: Archives disregard special mode-class Date: Thu, 04 Feb 2010 21:52:29 +0200 Organization: JURTA Message-ID: <87636dhrjm.fsf@mail.jurta.org> References: <873a1j2p71.fsf@mail.jurta.org> <873a1h26c9.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1265313483 12228 80.91.229.12 (4 Feb 2010 19:58:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2010 19:58:03 +0000 (UTC) Cc: 5513@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 20:57:57 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7pj-0005Fs-9b for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2010 20:57:47 +0100 Original-Received: from localhost ([127.0.0.1]:52553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nd7pi-0005Xj-SP for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2010 14:57:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nd7pe-0005WE-1K for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:42 -0500 Original-Received: from [199.232.76.173] (port=58983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nd7pd-0005Vw-ND for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:41 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nd7pZ-0006xL-02 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:40 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45940) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nd7pY-0006xF-Bm for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nd7p0-00005V-WF; Thu, 04 Feb 2010 14:57:03 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2010 19:57:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5513 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5513-submit@debbugs.gnu.org id=B5513.1265313409319 (code B ref 5513); Thu, 04 Feb 2010 19:57:02 +0000 Original-Received: (at 5513) by debbugs.gnu.org; 4 Feb 2010 19:56:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7ob-00004w-8C for submit@debbugs.gnu.org; Thu, 04 Feb 2010 14:56:48 -0500 Original-Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7oW-0008WS-LX for 5513@debbugs.gnu.org; Thu, 04 Feb 2010 14:56:36 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.52.53.cable.starman.ee [82.131.52.53]) by mx2.starman.ee (Postfix) with ESMTP id 236C73F40D5; Thu, 4 Feb 2010 21:56:22 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Thu, 04 Feb 2010 10:22:30 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 04 Feb 2010 14:57:03 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34898 Archived-At: >> I think all `view-buffer' calls should respect the property `mode-class', >> so I moved this code from `view-file' to `view-buffer'. `view-buffer-1' >> is a new function with the old content of `view-buffer' for the case when >> some package would prefer to ignore `mode-class' for some reasons. > >> I hesitate to install this patch now because it changes the behavior of >> `view-file' for a non-critical bug. > > Indeed, in this form I don't think it's acceptable for `trunk'. > If you switch the names around, OTOH it should be safe. I think in the long run the correct behavior of `view-buffer' should be to check `mode-class'. Instead of switching the behavior after the release, we could wait and install the final version of `view-buffer' (that checks for `mode-class') after feature freeze (or install now to the `pending' branch). -- Juri Linkov http://www.jurta.org/emacs/